OpenStack Compute (nova)

Merge lp:~soren/nova/default-public-interface into lp:~hudson-openstack/nova/trunk

  1. default-public-interface
  2. Merge into trunk
Proposed by Soren Hansen
Status: Merged
Approved by: Devin Carlen
Approved revision: 688
Merged at revision: 695
Proposed branch: lp:~soren/nova/default-public-interface
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
nova/network/linux_net.py (+1/-1)
To merge this branch: bzr merge lp:~soren/nova/default-public-interface
Reviewer Review Type Date Requested Status
Vish Ishaya (community) Approve
Devin Carlen (community) Approve
Christian Berendt (community) Approve
Thierry Carrez (community) Approve
Review via email: mp+50141@code.launchpad.net

Commit message

Make eth0 the default for the public_interface flag.

Description of the change

Make eth0 the default for the public_interface flag.

To post a comment you must log in.
Revision history for this message
Thierry Carrez (ttx) wrote :

Looks sane to me. Maybe Vish could tell us if he had a good reason for having vlan1 as the default...

review: Approve
Revision history for this message
Christian Berendt (berendt) wrote :

lgtm

review: Approve
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
Revision history for this message
Vish Ishaya (vishvananda) wrote :

lgtm. No reason vor vlan1. We just always used a specific vlan internally, and we changed it to a generic one when we were cleaning up. eth0 makes far more sense.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/network/linux_net.py'
2--- nova/network/linux_net.py 2011-02-14 05:48:14 +0000
3+++ nova/network/linux_net.py 2011-02-17 12:57:34 +0000
4@@ -44,7 +44,7 @@
5
6 flags.DEFINE_string('networks_path', '$state_path/networks',
7 'Location to keep network config files')
8-flags.DEFINE_string('public_interface', 'vlan1',
9+flags.DEFINE_string('public_interface', 'eth0',
10 'Interface for public IP addresses')
11 flags.DEFINE_string('vlan_interface', 'eth0',
12 'network device for vlans')