OpenStack Compute (nova)

Merge lp:~soren/nova/accept-missing-vcs-info into lp:~hudson-openstack/nova/trunk

  1. accept-missing-vcs-info
  2. Merge into trunk
Proposed by Soren Hansen
Status: Merged
Approved by: Todd Willey
Approved revision: 1053
Merged at revision: 1053
Proposed branch: lp:~soren/nova/accept-missing-vcs-info
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
nova/tests/test_misc.py (+1/-1)
To merge this branch: bzr merge lp:~soren/nova/accept-missing-vcs-info
Reviewer Review Type Date Requested Status
Todd Willey (community) Approve
Vish Ishaya (community) Approve
Review via email: mp+59995@code.launchpad.net

Commit message

Don't fail the test suite in the absence of VCS history.

Description of the change

It's ok if there's no commit history. Otherwise the test suite in the tarball will fail.

To post a comment you must log in.
Revision history for this message
Vish Ishaya (vishvananda) wrote :

seems reasonable

review: Approve
Revision history for this message
Soren Hansen (soren) wrote :

Oh, and this is a regression. It used to work this way before the git stuff was added.

Revision history for this message
Todd Willey (xtoddx) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/tests/test_misc.py'
2--- nova/tests/test_misc.py 2011-04-19 20:52:32 +0000
3+++ nova/tests/test_misc.py 2011-05-04 21:13:49 +0000
4@@ -68,7 +68,7 @@
5 contributors.add(str_dict_replace(email, mailmap))
6
7 else:
8- self.assertTrue(False, 'Cannot read commit history')
9+ return
10
11 for contributor in contributors:
12 if contributor == 'nova-core':