Code review comment for lp:~songofacandy/bzr/i18n-utextwrap

Martin Packman (gz) wrote :

> Nowhere in there is "Is it perfect".

Yes, there's a conflict between "writing everything I think of when I read through the code" and "being clear about what changes are needed so the code can land".

Avoiding a regression in how Russian is handled versus the default TextWrapper class is the main thing, but until there's some Russian help text written that's not actually fatal.

« Back to merge proposal