On 5/7/2011 11:28 PM, Martin [gz] wrote:
> Review: Needs Fixing
>
I just want us to remember the rules for reviewing:
Is it better than what we have, and doesn't reduce test coverage.
Nowhere in there is "Is it perfect".
I don't understand enough here to be able to say where things are at.
But if the current code is an improvement over our existing logic, it
can be landed into core, *and improved from there*, rather than stalling
the work at the review stage.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 5/7/2011 11:28 PM, Martin [gz] wrote:
> Review: Needs Fixing
>
I just want us to remember the rules for reviewing:
Is it better than what we have, and doesn't reduce test coverage.
Nowhere in there is "Is it perfect".
I don't understand enough here to be able to say where things are at.
But if the current code is an improvement over our existing logic, it
can be landed into core, *and improved from there*, rather than stalling
the work at the review stage.
John enigmail. mozdev. org/
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk3 GS7oACgkQJdeBCY SNAAP75ACeL6Tyv VYtwsfo8cc6CACp PFya yjWsd3PcwqZkCtV SC
t4oAoKZo3y3voqN
=Rs3O
-----END PGP SIGNATURE-----