Code review comment for lp:~songofacandy/bzr/i18n-utextwrap

Vincent Ladeuil (vila) wrote :

Haaa, far better :) Thanks a lot !

The tests are a good start but wrap probably deserve more of them given its internal complexity and fill should probably receive some too. Finally one test demonstrating that the width is correctly handled would help (the idea is to make it easier later to debug specific areas of the code by having tests that already exercise it. That makes far easier to debug the code when you didn't write it yourself).

  ./bzr selftest -s bt.test_utext --coverage utext

will help you ensuring a minimal coverage (look into utext/bzrlib.utextwrap.cover).

I just did, so if indeed 'fill' is not tested, there is only a few spots that aren't in 'wrap' so you're really close already. (Forgive my ignorance, but is 'Good Morning' already on multiple lines in Japanese ?).

I'll put the review into 'work in progress', don't forget to set it back to 'NeedsReview' when needed.

review: Needs Fixing

« Back to merge proposal