Merge ~sombrafam/ubuntu/+source/ubuntu-advantage-tools:lp-bug-1840091-uatools into ubuntu/+source/ubuntu-advantage-tools:ubuntu/trusty-devel

Proposed by Erlon R. Cruz
Status: Merged
Approved by: Andreas Hasenack
Approved revision: e239b2c5329e9324f7f392b37e73dc0a8fb5b7ea
Merged at revision: e239b2c5329e9324f7f392b37e73dc0a8fb5b7ea
Proposed branch: ~sombrafam/ubuntu/+source/ubuntu-advantage-tools:lp-bug-1840091-uatools
Merge into: ubuntu/+source/ubuntu-advantage-tools:ubuntu/trusty-devel
Diff against target: 32 lines (+12/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+6/-1)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Canonical Server Pending
Review via email: mp+371818@code.launchpad.net

Description of the change

The stable version of the UA package on trustry miss some dependencies causing a user that has just updated to its last version to get errors while upgrading the repos. This change adds the deps.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks, taking a look. Inline comments.

review: Needs Fixing
Revision history for this message
Andreas Hasenack (ahasenack) wrote :
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I tested the bug scenario, and the fix, and this looks good. Just the two small issues I pointed out before and this can be uploaded.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Looks good, +1

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

oops, one more thing

review: Needs Fixing
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ok now :)

+1

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

looks good again, +1

review: Approve
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Sponsoring e239b2c5329e9324f7f392b37e73dc0a8fb5b7ea

Tagged and uploaded:
$ git push pkg upload/10ubuntu0.14.04.4
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 2 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 1.15 KiB | 1.15 MiB/s, done.
Total 9 (delta 6), reused 0 (delta 0)
To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/ubuntu-advantage-tools
 * [new tag] upload/10ubuntu0.14.04.4 -> upload/10ubuntu0.14.04.4

$ dput ubuntu ../ubuntu-advantage-tools_10ubuntu0.14.04.4_source.changes
Checking signature on .changes
gpg: ../ubuntu-advantage-tools_10ubuntu0.14.04.4_source.changes: Valid signature from AC983EB5BF6BCBA9
Checking signature on .dsc
gpg: ../ubuntu-advantage-tools_10ubuntu0.14.04.4.dsc: Valid signature from AC983EB5BF6BCBA9
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-advantage-tools_10ubuntu0.14.04.4.dsc: done.
  Uploading ubuntu-advantage-tools_10ubuntu0.14.04.4.tar.gz: done.
  Uploading ubuntu-advantage-tools_10ubuntu0.14.04.4_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 602c554..e6fff31 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+ubuntu-advantage-tools (10ubuntu0.14.04.4) trusty; urgency=medium
7+
8+ * d/control: Fix missing dependency to apt package (LP: #1840091)
9+
10+ -- Erlon R. Cruz <erlon@canonical.com> Fri, 23 Aug 2019 10:12:57 -0300
11+
12 ubuntu-advantage-tools (10ubuntu0.14.04.3) trusty; urgency=medium
13
14 * Enable support for Trusty ESM (LP: #1825239)
15diff --git a/debian/control b/debian/control
16index 836d25e..d296902 100644
17--- a/debian/control
18+++ b/debian/control
19@@ -11,7 +11,12 @@ Vcs-Browser: https://github.com/CanonicalLtd/ubuntu-advantage-script
20
21 Package: ubuntu-advantage-tools
22 Architecture: all
23-Depends: ${misc:Depends}
24+Depends: ${misc:Depends},
25+ apt (>= 1.0.1ubuntu2.23),
26+ apt-transport-https (>= 1.0.1ubuntu2.23),
27+ apt-utils (>= 1.0.1ubuntu2.23),
28+ libapt-inst1.5 (>= 1.0.1ubuntu2.23),
29+ libapt-pkg4.12 (>= 1.0.1ubuntu2.23)
30 Description: management tools for Ubuntu Advantage
31 Ubuntu Advantage is the professional package of tooling, technology
32 and expertise from Canonical, helping organisations around the world

Subscribers

People subscribed via source and target branches

to status/vote changes: