Merge ~sombrafam/ua-reviewkit:add-neutron-gateway-count-check into ua-reviewkit:master

[Erlon R. Cruz]

This should print this kind o warning:

=> application 'neutron-gateway'
[WARN] HA (>=3) (not enough units (value=2, expected='>=3'))

[Edward Hope-Morley (hopem)]

This is ok except that sometimes deployments will use 2 neutron-gateways instead of 3. This will currently produce an error because assert_ha requires a min of 3 [1]. If we want to mandate 3 going forward i guess thats fine but otherwise we will need to add a means to override this minimum number of 3.

[1] https://git.launchpad.net/ua-reviewkit/tree/juju/ua-bundle-check.py#n237

[Edward Hope-Morley (hopem)]

actually i am ok with this because we are doing a warning and not an error.

[Edward Hope-Morley (hopem)]

We will need to land the other charm regex MP first though since it is included in this one.

[Edward Hope-Morley (hopem)]

Erlon, I have landed your other patch but this one now conflicts with master (because it includes an older version of the other patch). Can you rebase and update?

[Erlon R. Cruz (sombrafam)]

Should work now.

diff --git a/juju/checks/openstack.yaml b/juju/checks/openstack.yaml
index ea0f6e2..ac7319c 100644
--- a/juju/checks/openstack.yaml
+++ b/juju/checks/openstack.yaml
@@ -175,6 +175,13 @@ checks:
             While not a hard requirment, we currently recommend using Jumbo
             frames for this setting so as to allow enough flexibility for
             all neutron networks.
+  neutron-gateway:
+    charm: "neutron-gateway"
+    assertions:
+      ha:
+        assert_ha:
+          scope: application
+          warn-on-fail: true
   nova-cloud-controller:
     charm: "nova-cloud-controller"
     assertions: