Merge lp:~soliloque/simple-scan/batch-scan into lp:~simple-scan-team/simple-scan/trunk
Status: | Merged |
---|---|
Merged at revision: | 963 |
Proposed branch: | lp:~soliloque/simple-scan/batch-scan |
Merge into: | lp:~simple-scan-team/simple-scan/trunk |
Diff against target: |
260 lines (+82/-11) 5 files modified
README.md (+2/-2) data/org.gnome.SimpleScan.gschema.xml (+6/-0) src/scanner.vala (+9/-2) src/simple-scan.ui (+43/-6) src/ui.vala (+22/-1) |
To merge this branch: | bzr merge lp:~soliloque/simple-scan/batch-scan |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Approve | ||
Review via email: mp+322088@code.launchpad.net |
Commit message
Add a configurable delay to batch scan type
Description of the change
* Fixed a small typo in build instructions (README.md)
* Add meson to the list of software to install (README.md)
Note: Because simple-scan have dependencies on specific versions of other software packages, the build instructions provided in README.md will not work on Ubuntu 16.04LTS. I think these instructions require at least the yet-to-be-released 17.04 version. Is this correct?
* Add a configurable delay to batch scan type
I used a minimum delay of 0 seconds, a maximum delay of 10 seconds, and a default delay of 1 seconds. Maximum delay is set in simple-scan.ui and org.gnome.
Scanner.vala implement the delay by putting the scanner thread to sleep. Another way would be to add a WAIT ScanState but imho that seemed uselessly complex.
Please comment.
Thanks! I committed with a few changes:
- I merged the build instructions in a separate merge - they don't relate to this change
- I renamed "speed" to "page delay"
- I changed the setting from us to ms (us seems overkill)
- I changed how the slider looks in the UI
The sleep looks fine since this is all running in its own thread.