Merge lp:~snwh/ubuntu-terminal-app/updated-icon into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Sam Hewitt
Status: Merged
Approved by: Niklas Wenzel
Approved revision: 103
Merged at revision: 103
Proposed branch: lp:~snwh/ubuntu-terminal-app/updated-icon
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 2 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~snwh/ubuntu-terminal-app/updated-icon
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Niklas Wenzel (community) Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email:

Commit message

Updated icon in accordance with the new guidelines.

Description of the change

Updated icon to fit the newer guidelines & styles.

To post a comment you must log in.
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thanks, Sam!

While I think that the updated icon looks really good, I'd like to hear an official opinion from some Canonical guys here. The latest batch of icons was created by Canonical designers and I don't know what their plans are regarding the terminal icon.

review: Needs Information
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

They have no plans unless we ask them to create one. We welcome contributions both in terms of code and design to these community apps. Sam has made a bunch of icons for us in the past and we've never had any issue with them. (Until Sam sees them himself on a website a year or so later and feels the need to update them) :)

review: Approve
Revision history for this message
Niklas Wenzel (nikwen) wrote :

@Alan: Yes, I've seen Sam create icons since the very first days when I got in touch with Ubuntu on my Nexus 4. I've always admired them! (By the way, thank you for your fast answer.)

Since there do not seem to be any issues with regards to the design team, we should get this merged as fast as possible. :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.

review: Needs Fixing (continuous-integration)
Revision history for this message
Sam Hewitt (snwh) wrote :

@popey, has it been a year.. oi. If I were using Ubuntu on a device and I saw the icons more frequently I'd have been compelled to change update them sooner.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'terminal64.png'
2Binary files terminal64.png 2014-10-25 04:42:31 +0000 and terminal64.png 2015-07-13 18:43:58 +0000 differ


People subscribed via source and target branches