Merge lp:~snwh/egtk/matching-notebook-styles into lp:~elementary-design/egtk/trunk

Proposed by Sam Hewitt
Status: Rejected
Rejected by: Sam Hewitt
Proposed branch: lp:~snwh/egtk/matching-notebook-styles
Merge into: lp:~elementary-design/egtk/trunk
Diff against target: 210 lines (+59/-47)
1 file modified
gtk-3.0/gtk-widgets.css (+59/-47)
To merge this branch: bzr merge lp:~snwh/egtk/matching-notebook-styles
Reviewer Review Type Date Requested Status
elementary UX Pending
Review via email: mp+256955@code.launchpad.net

Commit message

Match style of .notebook and .dynamic-notebook match

Description of the change

Update to make the style of .notebook and .dynamic-notebook match.

To post a comment you must log in.
452. By Sam Hewitt

Tweaked legacy notebook headers.

453. By Sam Hewitt

Refined notebook style.

454. By Sam Hewitt

Marginally improved the notebook header some more

Unmerged revisions

454. By Sam Hewitt

Marginally improved the notebook header some more

453. By Sam Hewitt

Refined notebook style.

452. By Sam Hewitt

Tweaked legacy notebook headers.

451. By Sam Hewitt

Matched .notebook & .dynamic-notebook styles.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gtk-3.0/gtk-widgets.css'
2--- gtk-3.0/gtk-widgets.css 2015-04-20 18:02:27 +0000
3+++ gtk-3.0/gtk-widgets.css 2015-04-21 19:44:00 +0000
4@@ -1327,7 +1327,7 @@
5 ********************/
6
7 .notebook {
8- border-radius: 2.5px;
9+ border-radius: 0 0 2.5px 2.5px;
10
11 background-clip: border-box;
12 background-color: shade (@titlebar_color, 1.06);
13@@ -1335,14 +1335,13 @@
14 text-shadow: 0 1px alpha (#fff, 0.4);
15 icon-shadow: 0 1px alpha (#fff, 0.4);
16 border: 1px solid shade (@titlebar_color, 0.60);
17-}
18-
19-.notebook.header {
20- border: none;
21- background-color: transparent;
22-}
23-
24+ border-top-width: 0px;
25+}
26+
27+
28+.notebook.header,
29 .dynamic-notebook .notebook.header {
30+ background-color: transparent;
31 background-image: linear-gradient(to bottom,
32 alpha (#000, 0.10),
33 alpha (#000, 0.00) 3px
34@@ -1355,8 +1354,15 @@
35 border-width: 0 0 1px 0;
36 border-color: shade (@titlebar_color, 0.56);
37 border-radius: 0;
38-}
39-
40+ box-shadow: none;
41+}
42+
43+.notebook.header {
44+ border: none;
45+ box-shadow: inset 0 0 0 1px shade (@titlebar_color, 0.56)
46+}
47+
48+.notebook.header:backdrop,
49 .dynamic-notebook .notebook.header:backdrop {
50 background-color: shade (@titlebar_color, 0.96);
51 background-image: linear-gradient(to bottom,
52@@ -1372,18 +1378,22 @@
53 border-width: 0;
54 }
55
56+.notebook .button,
57 .dynamic-notebook .notebook .button {
58 color: shade (@text_color, 1.20);
59 }
60
61+.notebook GtkImage,
62 .dynamic-notebook GtkImage {
63 color: shade (@title_color, 0.75);
64 }
65
66+.notebook GtkImage:insensitive,
67 .dynamic-notebook GtkImage:insensitive {
68 color: @insensitive_color;
69 }
70
71+.notebook .button:hover,
72 .dynamic-notebook .notebook .button:hover {
73 background-color: alpha (#000, 0.05);
74 border-color: alpha (#000, 0.25);
75@@ -1391,24 +1401,14 @@
76 color: shade (@text_color, 1.10);
77 }
78
79+.notebook .button:hover:active,
80 .dynamic-notebook .notebook .button:hover:active {
81 background-color: alpha (#000, 0.10);
82 }
83
84-.notebook tab {
85- background-image: linear-gradient(to bottom,
86- shade (@titlebar_color, 0.75),
87- shade (@titlebar_color, 0.80)
88- );
89-
90- border-radius: 2.5px;
91-
92- padding: 2px 3px 0;
93-}
94-
95+
96+.notebook tab,
97 .dynamic-notebook .notebook tab {
98- padding: 3px;
99-
100 border-radius: 0;
101
102 background-image: none;
103@@ -1422,10 +1422,20 @@
104 ) 0 1 0 0;
105 }
106
107+.notebook tab {
108+ padding: 0 3px;
109+}
110+
111+.dynamic-notebook .notebook tab {
112+ padding: 3px;
113+}
114+
115+.notebook tab > GtkImage,
116 .dynamic-notebook .notebook tab > GtkImage {
117 color: shade (@titlebar_color, 0.35);
118 }
119
120+.notebook tab:nth-child(first),
121 .dynamic-notebook .notebook tab:nth-child(first) {
122 border-width: 0 1px 0 1px;
123 border-image: linear-gradient(to bottom,
124@@ -1434,14 +1444,7 @@
125 ) 0 1 0 1;
126 }
127
128-.notebook tab:active {
129- background-image: linear-gradient(to bottom,
130- shade (@titlebar_color, 1.24),
131- shade (@titlebar_color, 1.06)
132- );
133- color: @text_color;
134-}
135-
136+.notebook tab:active,
137 .dynamic-notebook .notebook tab:active {
138 background-image: linear-gradient(to bottom,
139 shade (@titlebar_color, 0.88),
140@@ -1463,31 +1466,38 @@
141 color: @text_color;
142 }
143
144+.notebook tab:active {
145+ border-width: 1px;
146+ box-shadow: inset 0 1px 0 0 alpha (#fff, 0.40);
147+}
148+
149+.notebook tab:active:backdrop,
150 .dynamic-notebook .notebook tab:active:backdrop {
151 background-image: linear-gradient(to bottom,
152 shade (@titlebar_color, 0.98),
153 shade (@titlebar_color, 0.96)
154 );
155 border-color: shade (@titlebar_color, 0.70);
156- box-shadow: inset 0 0 0 1px alpha (#fff, 0.20),
157- 0 0 0 1px alpha (#000, 0.10);
158+ border-radius: 4px;
159+ border-style: solid;
160+ border-width: 0 1px 1px;
161+
162+ text-shadow: 0 1px alpha (#fff, 0.2);
163+ icon-shadow: 0 1px alpha (#fff, 0.2);
164+
165+ box-shadow: inset 0 0 0 1px alpha (#fff, 0.20);
166 }
167
168-.notebook.header {
169+.notebook tab:active:backdrop {
170 border: none;
171- background-color: transparent;
172-}
173-
174-.notebook {
175- border-radius: 2.5px;
176-
177- background-clip: border-box;
178- background-color: shade (@titlebar_color, 1.06);
179-
180- text-shadow: 0 1px alpha (#fff, 0.4);
181- icon-shadow: 0 1px alpha (#fff, 0.4);
182-
183- border: 1px solid shade (@titlebar_color, 0.60);
184+ box-shadow: inset 0 0 0 1px alpha (#000, 0.20),
185+ inset 0 1px 0 0 alpha (#fff, 0.20),
186+ inset 0 -1px 0 0 alpha (#fff, 0.20),
187+ inset 2px 0 0 0 alpha (#fff, 0.20),
188+ inset -2px 0 0 0 alpha (#fff, 0.20),
189+ inset 1px 0 0 0 shade (@titlebar_color, 0.70),
190+ inset -1px 0 0 0 shade (@titlebar_color, 0.70),
191+ 0 0 1px 1px alpha (#000, 0.10);
192 }
193
194 .notebook.frame {
195@@ -2446,6 +2456,7 @@
196 .popover GtkTreeView.view row:selected {
197 background-color: shade (@base_color, 0.80);
198 color: @text_color;
199+ text-shadow:none;
200 }
201
202 .cell:selected:focus,
203@@ -2453,6 +2464,7 @@
204 .view:selected:focus {
205 background-color: @selected_bg_color;
206 color: @selected_fg_color;
207+ text-shadow:none;
208 }
209
210 /* FIXME: This doesn't work with only-child

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: