Merge lp:~snwh/egtk/header-bar-additions into lp:~elementary-design/egtk/trunk

Proposed by Sam Hewitt
Status: Rejected
Rejected by: Danielle Foré
Proposed branch: lp:~snwh/egtk/header-bar-additions
Merge into: lp:~elementary-design/egtk/trunk
Diff against target: 49 lines (+20/-1)
2 files modified
gtk-3.0/apps.css (+9/-0)
gtk-3.0/gtk-widgets.css (+11/-1)
To merge this branch: bzr merge lp:~snwh/egtk/header-bar-additions
Reviewer Review Type Date Requested Status
Danielle Foré Needs Fixing
Review via email: mp+284525@code.launchpad.net

Commit message

added some header-bar specific styles

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I'm not a fan of the way this affects linked buttons in (for example) Files.

Also be aware that the .header-bar class is no longer present in Gtk >=3.19. You should probably use .titlebar instead

review: Needs Fixing
Revision history for this message
Danielle Foré (danrabbit) wrote :

If you ever wanna revive this, please do so on GitHub

Unmerged revisions

631. By Sam Hewitt

added some header-bar specific styles

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gtk-3.0/apps.css'
2--- gtk-3.0/apps.css 2016-01-15 21:20:28 +0000
3+++ gtk-3.0/apps.css 2016-01-30 23:12:51 +0000
4@@ -31,6 +31,15 @@
5 0 1px 2px alpha (#000, 0.24);
6 }
7
8+/* Header bar */
9+.header-bar .avatar {
10+ border:none;
11+ border-radius: 15%;
12+ box-shadow: inset 0 0 0 1px alpha(#000, 0.25),
13+ inset 0 1px 2px 0 alpha (#000, 0.45),
14+ 0 1px 0 0 alpha( #fff, 0.45);
15+}
16+
17 /*************
18 * Calculator *
19 *************/
20
21=== modified file 'gtk-3.0/gtk-widgets.css'
22--- gtk-3.0/gtk-widgets.css 2016-01-13 05:10:09 +0000
23+++ gtk-3.0/gtk-widgets.css 2016-01-30 23:12:51 +0000
24@@ -1138,7 +1138,6 @@
25 background-color: alpha (#000, 0.05);
26 background-image: none;
27 border-color: alpha (#000, 0.27);
28-
29 box-shadow: inset 0 0 0 1px alpha (#000, 0.05),
30 0 1px 0 0 alpha (@bg_highlight_color, 0.30);
31 }
32@@ -1625,6 +1624,17 @@
33 border-radius: 2.5px;
34 }
35
36+/* GraniteModeButton (linked full-height header-bar buttons) */
37+.header-bar .linked .button,
38+.header-bar .linked button {
39+ border-right-width:0px;
40+}
41+
42+.header-bar .linked .button:last-child,
43+.header-bar .linked button:last-child {
44+ border-right-width:1px;
45+}
46+
47 /********************
48 * Notebook and Tabs *
49 ********************/

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: