Zim

Merge lp:~sneakypete81/zim/pyzim into lp:~jaap.karssenberg/zim/pyzim

Proposed by sneakypete
Status: Merged
Approved by: Jaap Karssenberg
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~sneakypete81/zim/pyzim
Merge into: lp:~jaap.karssenberg/zim/pyzim
Diff against target: 29 lines (+3/-3)
2 files modified
zim/fs.py (+1/-1)
zim/parsing.py (+2/-2)
To merge this branch: bzr merge lp:~sneakypete81/zim/pyzim
Reviewer Review Type Date Requested Status
Jaap Karssenberg Approve
Review via email: mp+17609@code.launchpad.net
To post a comment you must log in.
Revision history for this message
sneakypete (sneakypete81) wrote :

Solves problem under Windows where file:///c:/path/to/file was appearing as /c:/path/to/file and then c:\c:\path\to\file, since the lower-case drive letter was not detected.

This problem meant Zim failed to find existing notebooks.

Hope I've done this properly, I'm a launchpad beginner..

Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Patch looks good to me, will merge it.

review: Approve
lp:~sneakypete81/zim/pyzim updated
193. By sneakypete

Add 'Open' to image context menu

194. By sneakypete

merged from trunk

Revision history for this message
sneakypete (sneakypete81) wrote :

My apologies, Jaap: I've just pushed some extra changes to this branch, and it looks like this merge proposal has been updated too. I didn't expect this to happen.

Please ignore the changes to zim/gui/pageview.py, at least until I've had time to review them properly.

Probably I should have created a new branch for these new changes, correct?

lp:~sneakypete81/zim/pyzim updated
195. By sneakypete

backed out changes in rev 193

196. By sneakypete

previous backout missed a line

197. By sneakypete

whitespace tweak

Revision history for this message
sneakypete (sneakypete81) wrote :

Ok, I've backed out my mistaken changes, leaving the original approved merge proposal.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'zim/fs.py'
2--- zim/fs.py 2010-01-24 19:23:38 +0000
3+++ zim/fs.py 2010-01-29 19:59:11 +0000
4@@ -290,7 +290,7 @@
5 @staticmethod
6 def _abspath(path):
7 # Strip leading / for absolute paths
8- if re.match(r'^[/\\][A-Z]:[/\\]', path):
9+ if re.match(r'^[/\\][A-Za-z]:[/\\]', path):
10 path = path[1:]
11 return os.path.abspath(path)
12
13
14=== modified file 'zim/parsing.py'
15--- zim/parsing.py 2010-01-24 19:23:38 +0000
16+++ zim/parsing.py 2010-01-29 19:59:11 +0000
17@@ -206,10 +206,10 @@
18 is_email_re = Re('^mailto:|^\S+\@\S+\.\w+$')
19 # "mailto:" address
20 # name "@" host
21-is_path_re = Re(r'^(/|\.\.?[/\\]|~.*[/\\]|[A-Z]:\\)')
22+is_path_re = Re(r'^(/|\.\.?[/\\]|~.*[/\\]|[A-Za-z]:\\)')
23 # / ~/ ./ ../ ~user/ .\ ..\ ~\ ~user\
24 # X:\
25-is_win32_path_re = Re(r'^[A-Z]:[\\/]')
26+is_win32_path_re = Re(r'^[A-Za-z]:[\\/]')
27 # X:\ (or X:/)
28 is_win32_share_re = Re(r'^(\\\\[^\\]+\\.+|smb://)')
29 # \\host\share