snappy-hwe-snaps

Merge ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:snap-description-tweak into ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:master

  1. Git
  2. lp:~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager
  3. snap-description-tweak
  4. Merge into master
Proposed by Kyle Nitzsche
Status: Approved
Approved by: Kyle Nitzsche
Approved revision: 219886ba7633a82aef1731b7839feccad3bd032e
Proposed branch: ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:snap-description-tweak
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager:master
Diff against target: 23 lines (+6/-7)
1 file modified
snapcraft.yaml (+6/-7)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Needs Fixing
Alfonso Sanchez-Beato Approve
Review via email: mp+352775@code.launchpad.net

Commit message

Suggested tweak on wording of the modem-manager snap description.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: 219886ba7633a82aef1731b7839feccad3bd032e

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1095/

Reply
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:219886ba7633a82aef1731b7839feccad3bd032e
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/257/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/303/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/303/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/303/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/303/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1095
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/838
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/870/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/257/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve
Reply
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: 219886ba7633a82aef1731b7839feccad3bd032e

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1096/

Reply
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:219886ba7633a82aef1731b7839feccad3bd032e
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/258/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=amd64/304/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=arm64/304/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=armhf/304/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build/ARCHITECTURE=i386/304/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1096
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-cleanup/839
    None: https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-update-mp/871/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/258/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@Kyle, would you mind rebasing this MP to latest in master? Iirc the problem the caused the CI error was solved a while ago.

Reply

Unmerged commits

219886b... by Kyle Nitzsche <email address hidden>

Tweak snap description for style and grammer

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 67403ef..094dcb7 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -1,13 +1,12 @@
6 name: modem-manager
7 version: 1.6.12-4-dev
8-summary: ModemManager is a service which controls mobile broadband
9+summary: ModemManager is a service that controls mobile broadband
10 description: |
11- ModemManager is a DBus-activated daemon which controls mobile broadband
12- (2G/3G/4G) devices and connections. Whether built-in devices, USB dongles,
13- bluetooth-paired telephones or professional RS232/USB devices with external
14- power supplies, ModemManager is able to prepare and configure the modems and
15- setup connections with them.
16- Please find the source code at https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager
17+ ModemManager is a DBus-activated daemon that configures and controls
18+ mobile broadband (2G/3G/4G) devices and connections. Modem manager
19+ handles built-in devices, USB dongles, bluetooth-paired
20+ telephones and RS232/USB modem devices with external power supplies.
21+ Source code: https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/modem-manager
22 confinement: strict
23 grade: stable
24

Subscribers

People subscribed via source and target branches

to all changes: