Merge ~snappy-hwe-team/snappy-hwe-snaps/+git/mesa-runtime:first-runtime into ~snappy-hwe-team/snappy-hwe-snaps/+git/mesa-runtime:master

[Alberto Milone]

This is my initial attempt at providing a mesa runtime.

Note: this also includes some of the relevant X libraries.

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:d0cfb0841563f38727b4ca9b37061f3242a45dda
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1554/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1864/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1462/console
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2246/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1554/rebuild

review: Needs Fixing (continuous-integration)

[Alberto Milone (albertomilone)]

As for the 1st failure, why doesn't it look for snap/snapcraft.yaml?

+ [ -e snapcraft.yaml ]
+ [ -z ]
+ echo WARNING: Can't build snap as no snapcraft.yaml exists!

The 2nd failure seems to be correct, as I haven't provided a spread test yet. I need to learn about them first.

[Simon Fels (morphis)]

CI Fails as you need to have a top-level snapcraft.yaml

Also if you don't provide a run-tests.sh script CI will fail too because it will require you to have some tests around. If you don't have any tests yet you can add a .ci_tests_disabled file

review: Needs Fixing

[System Enablement Bot (system-enablement-ci-bot)]

FAILED: Continuous integration, rev:6ace35bfe7558adf47b5ce61332a902e276ed012
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1555/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1865/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1463/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1555/rebuild

review: Needs Fixing (continuous-integration)

[Alberto Milone (albertomilone)]

I'm a bit confused as to what the actual error is now.

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:b52264ceb56b0a7baea36b4111e0618cc4f3c0a1
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1568/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1928
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1476/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2306
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1503/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1568/rebuild

review: Approve (continuous-integration)

[Konrad Zapałowicz (kzapalowicz)]

one more thing, MAINTAINERS file shall be added.

review: Needs Fixing (code)

[Konrad Zapałowicz (kzapalowicz)]

ack

review: Approve (code)

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:57db9512d4d8d599c353550f3847b01455b554d5
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1569/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1929
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1477/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2307
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1504/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1569/rebuild

review: Approve (continuous-integration)

[Simon Fels (morphis)]

review: Needs Fixing

[Simon Fels (morphis)]

One more thing: Ok, for this MP but for future MPs you should push the branch you want to merge to your own copy of the repository and not ~snappy-hwe-team/snappy-hwe-snaps/+git/mesa-runtime:first-runtime

[Alberto Milone (albertomilone)]

> One more thing: Ok, for this MP but for future MPs you should push the branch
> you want to merge to your own copy of the repository and not ~snappy-hwe-team
> /snappy-hwe-snaps/+git/mesa-runtime:first-runtime

Ok, I'll keep that in mind for the next MP. Thanks.

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:fc9cfbfc7c64879d98540cef61610c7a853b0b02
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1587/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/1967
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1495/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2345
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1538/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1587/rebuild

review: Approve (continuous-integration)

[Roberto Mier Escandon (rmescandon)]

since snapcraft.yaml can be moved to snap/snapcraft.yaml, as that is supposed to be the standard path for that file, let's change it.

Other thing: I guess this project intention is not to duplicate same mesa runtime stuff in different snaps using it, right?. Otherwise this could be distributed as a "part" instead of a snap, as happened with these https://wiki.ubuntu.com/snapcraft/parts.

review: Needs Fixing

[Alberto Milone (albertomilone)]

@Roberto: the funny thing is that snapcraft.yaml used to live in the snap directory, but CI wasn't happy with that (which is why I had to move it).

Also, correct, we want to avoid including the mesa libraries in every single snap that needs it (hence the content interface).

[Roberto Mier Escandon (rmescandon)]

@Alberto I think having snapcraft.yaml in snap subfolder is working for CI since thursday or even friday (a very recent change). That was a change made by Simon and already merged. Maybe you tried it before?

[Alberto Milone (albertomilone)]

> @Alberto I think having snapcraft.yaml in snap subfolder is working for CI
> since thursday or even friday (a very recent change). That was a change made
> by Simon and already merged. Maybe you tried it before?

I last tried that on June 01, and I haven't touched that since.

[System Enablement Bot (system-enablement-ci-bot)]

PASSED: Continuous integration, rev:34d99504309014b6fe49319bd448be757cd3236f
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1634/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2084
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1542/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2455
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/1637/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1634/rebuild

review: Approve (continuous-integration)

[Roberto Mier Escandon (rmescandon)]

LGTM

review: Approve

[Simon Fels (morphis)]

LGTM

review: Approve

diff --git a/.ci_tests_disabled b/.ci_tests_disabled
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/.ci_tests_disabled
diff --git a/MAINTAINERS b/MAINTAINERS
new file mode 100644
index 0000000..15f2e91
--- /dev/null
+++ b/MAINTAINERS
@@ -0,0 +1,3 @@
+Alberto Milone <[e-mail]>
+Alfonso Sanchez-Beato <[e-mail]>
+Roberto Escandon <[e-mail]>
diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
new file mode 100644
index 0000000..6e70310
--- /dev/null
+++ b/snap/snapcraft.yaml
@@ -0,0 +1,52 @@
+name: mesa-runtime
+version: 12.0.6-1
+summary: Mesa runtime for running applications that require acceleration
+description: |
+  Mesa is a 3-D graphics library with an API which is very similar to
+  that of OpenGL.  To the extent that Mesa utilizes the OpenGL command
+  syntax or state machine, it is being used with authorization from
+  Silicon Graphics, Inc.  However, the authors make no claim that Mesa
+  is in any way a compatible replacement for OpenGL or associated with
+  Silicon Graphics, Inc.
+
+  This version of Mesa provides GLX and DRI capabilities: it is capable of
+  both direct and indirect rendering.
+
+  Please find the source code for this snap at:
+  https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/mesa-runtime
+
+grade: stable
+confinement: strict
+
+slots:
+  runtime:
+    content: mesa-runtime1
+    interface: content
+    read:
+      - mesa-runtime
+
+parts:
+  mesa-runtime:
+    plugin: nil
+    stage-packages:
+      - libegl1-mesa
+      - libgl1-mesa-glx
+      - libgles2-mesa
+      - libglu1-mesa
+      - libwayland-egl1-mesa
+      - libgbm1
+    organize:
+      etc: mesa-runtime/etc
+      usr/lib: mesa-runtime/usr/lib
+      usr/share/X11: mesa-runtime/usr/share/X11
+      usr/share/doc: mesa-runtime/usr/share/doc
+    filesets:
+      libraries:
+        - mesa-runtime/etc
+        - mesa-runtime/usr/lib
+        - mesa-runtime/usr/share/doc
+        - -mesa-runtime/usr/lib/gcc
+        - -mesa-runtime/usr/share/doc/gcc-6-base
+        - -usr
+    prime:
+      - $libraries