~snappy-hwe-team/snappy-hwe-snaps/+git/ci-build-544:network-manager/xenial/1.2.2

Last commit made on 2020-11-18
Get this branch:
git clone -b network-manager/xenial/1.2.2 https://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/ci-build-544
Members of Snappy HWE Team can upload to this branch. Log in for directions.

Branch merges

Branch information

Name:
network-manager/xenial/1.2.2
Repository:
lp:~snappy-hwe-team/snappy-hwe-snaps/+git/ci-build-544

Recent commits

ee7b759... by System Enablement CI Bot <email address hidden> on 2020-11-18

Merge remote tracking branch fix-leaks-1.2.2

Merge-Proposal: https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager/+merge/394125

Author: Alfonso Sanchez-Beato <email address hidden>

Fix memory leaks introduced in snap patches

Fix memory leaks that were introducing while adapting NM to use paths
inside the snap (LP#1902271).

10d8373... by Alfonso Sanchez-Beato on 2020-11-18

Fix typo (gfree -> g_free)

c109dcb... by Alfonso Sanchez-Beato on 2020-11-18

Fix memory leaks introduced in snap patches

Fix memory leaks that were introducing while adapting NM to use paths
inside the snap (LP#1902271).

342852a... by System Enablement CI Bot <email address hidden> on 2020-07-08

Merge remote tracking branch wait-pppd-properly

Merge-Proposal: https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager/+merge/387041

Author: Alfonso Sanchez-Beato <email address hidden>

core/pppd-plugin: wait to recover port settings before notifying death
Upstream commit a251712a

3b3e564... by Alfonso Sanchez-Beato on 2019-06-13

core/pppd-plugin: wait to recover port settings before notifying death

pppd restores the previous settings for the serial port it uses right
before exiting. It is especially important to do so because otherwise
ModemManager is not able to recover the port as it can receive a hangup
event from the port due to CLOCAL not being restored. However, there is
currently a race condition that produces this issue. This is because
when PHASE_DEAD is notified, pppd still has not restored the port
settings - it does that a bit later, in the die() function.

This patch delays notifying PHASE_DEAD until when the exitnotify() hook
is called by pppd: when this happens the port settings have already been
restored.

There were previously efforts to fix this in commit fe090c34b724, so
PHASE_DEAD was used instead of PHASE_DISCONNECT to notify MM that the
port was disconnected, but that still early to ensure that the port
settings are restored.

The MM traces seen when the bug is triggered are:

ModemManager[2158]: <warn> (ttyACM1): could not re-acquire serial port lock: (5) Input/output error
ModemManager[2158]: <warn> Couldn't load Operator Code: 'Cannot run sequence: 'Could not open serial device ttyACM1: it has been forced close'

https://mail.gnome.org/archives/networkmanager-list/2019-June/msg00014.html

37cdd7f... by System Enablement CI Bot <email address hidden> on 2019-01-14

Merge remote tracking branch fix-duplicated-conns

Merge-Proposal: https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager/+merge/361687

Author: Alfonso Sanchez-Beato <email address hidden>

Set of patches to prevent duplicated addresses when NM re-starts. Fixes LP: #1811347

c13396f... by Alfonso Sanchez-Beato on 2019-01-11

core: ignore IPv6 multicast in connection comparison

The default multicast route for IPv6 is set by default in some devices.
This makes comparisons between connections that should be the same to
fail, so they are not merged and unneeded connections appear in the
system. This commit make sure this does not happen. The route is
{ dest = "ff00::", prefix = 8 }. Fixes LP: #1811347.

6173f91... by Thomas Haller on 2017-09-01

core: ignore host-routes routes when matching generated connection

When we generate the connection in nm_device_generate_connection(), we
add all routes that have rt_source (roundtrip(NM_IP_CONFIG_SOURCE_USER)).
Especially since commit e470e1392242a088573c4fc317b7b5ffaca4df19, this
includes automatically added host-routes to the gateway, added by
ip4_config_merge_and_apply().

Later, during nm_utils_match_connection() this route most not prevent
matching. Either nm_device_generate_connection() should not add it, or
nm_utils_match_connection() should ignore it.

I think adjusting the matching is better, because ip-configs are used
for several things, including exposing routes on D-Bus. We don't want
to hide this route on D-Bus.

Fixes: e470e1392242a088573c4fc317b7b5ffaca4df19

https://bugzilla.redhat.com/show_bug.cgi?id=1487384

447cbe8... by Thomas Haller on 2017-04-13

src: only compare network parts of routes in nm_utils_match_connection()

Kernel requires that routes have a host part of zero. For NetworkManager
configuration we allow non-zero host parts (but ignore them). Fix
route_compare() to ignore the host part.

This has only effect during assuming connections. That means, on
restart NM would fail to match a connection with static routes
if it has a non-zero host part. So, the impact is rather small.

(cherry picked from commit 034b7fb51c1d16a4002d2902c60aac05e946bb4f)

0e025e8... by Thomas Haller on 2016-04-12

core: add nm_utils_ipx_address_clear_host_address() util