~snappy-hwe-team/snappy-hwe-snaps/+git/ci-build-543:master

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

7dcf2e3... by System Enablement CI Bot <email address hidden> on 2020-11-19

Update snapcraft.yaml to build from right repository

9082df5... by System Enablement CI Bot <email address hidden> on 2020-11-19

Merge remote tracking branch other/fix-leaks-master

bb2eee6... by Alfonso Sanchez-Beato on 2020-11-19

Fix memory leaks introduced in snap patches

Fix memory leaks that were introducing while adapting NM to use paths
inside the snap (LP#1902271). Fixed by MP for network-manager/xenial/1.2.2
branch: https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager/+merge/394125

c6e3b69... by System Enablement CI Bot <email address hidden> on 2020-09-01

Open development for 1.2.2-28-dev

9f74784... by System Enablement CI Bot <email address hidden> on 2020-09-01

Bump version to 1.2.2-27

914689a... by System Enablement CI Bot <email address hidden> on 2020-09-01

Update manifests to 1.2.2-27

7e6cccc... by System Enablement CI Bot <email address hidden> on 2020-09-01

Update ChangeLog for 1.2.2-27

60c3886... by System Enablement CI Bot <email address hidden> on 2020-07-10

Merge remote tracking branch update-docs

Merge-Proposal: https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager/+merge/387195

Author: Alfonso Sanchez-Beato <email address hidden>

* core/pppd-plugin: wait to recover port settings before notifying death
  See code branch MP:
  https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager/+merge/387041
* docs: update to reflect current state

3c8c772... by Alfonso Sanchez-Beato on 2020-07-10

core/pppd-plugin: wait to recover port settings before notifying death

pppd restores the previous settings for the serial port it uses right
before exiting. It is especially important to do so because otherwise
ModemManager is not able to recover the port as it can receive a hangup
event from the port due to CLOCAL not being restored. However, there is
currently a race condition that produces this issue. This is because
when PHASE_DEAD is notified, pppd still has not restored the port
settings - it does that a bit later, in the die() function.

This patch delays notifying PHASE_DEAD until when the exitnotify() hook
is called by pppd: when this happens the port settings have already been
restored.

There were previously efforts to fix this in commit fe090c3, so
PHASE_DEAD was used instead of PHASE_DISCONNECT to notify MM that the
port was disconnected, but that still early to ensure that the port
settings are restored.

The MM traces seen when the bug is triggered are:

ModemManager[2158]: <warn> (ttyACM1): could not re-acquire serial port lock: (5) Input/output error
ModemManager[2158]: <warn> Couldn't load Operator Code: 'Cannot run sequence: 'Could not open serial device
ttyACM1: it has been forced close'

https://mail.gnome.org/archives/networkmanager-list/2019-June/msg00014.html

See code branch MP:
https://code.launchpad.net/~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager/+merge/387041

bfdc2f0... by Alfonso Sanchez-Beato on 2020-07-10

docs: update to reflect current state

Note the even though the master branch does not contain the recipe for
the core18 or core20 snaps, we prefer it to update the documentation.
The reason is that the master branch is the one pulled from the repo
configuration in
https://github.com/canonical-web-and-design/ubuntu-core-docs