Merge lp:~snaiksat/neutron/sumit-fix-profileclient into lp:~cisco-openstack/neutron/plugin-framework

Proposed by Sumit Naiksatam
Status: Merged
Merged at revision: 43
Proposed branch: lp:~snaiksat/neutron/sumit-fix-profileclient
Merge into: lp:~cisco-openstack/neutron/plugin-framework
Diff against target: 24 lines (+3/-3)
1 file modified
quantum/plugins/cisco/ucs/cisco_ucs_network_driver.py (+3/-3)
To merge this branch: bzr merge lp:~snaiksat/neutron/sumit-fix-profileclient
Reviewer Review Type Date Requested Status
Edgar Magana (community) Approve
Review via email: mp+70237@code.launchpad.net

Commit message

The port profile client name generated by the UCS Network Driver may exceed 17 characters, at which point the creation of the port profile client fails. The fix committed limits this name to 16 characters.

Description of the change

The port profile client name generated by the UCS Network Driver may exceed 17 characters, at which point the creation of the port profile client fails. The fix committed limits this name to 16 characters.

To post a comment you must log in.
44. By Sumit Naiksatam

Earlier fix resulted in a different issue (profile client name, was also being used as profile name, hence breaking).

Revision history for this message
Edgar Magana (emagana) wrote :

The fix is working properly.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'quantum/plugins/cisco/ucs/cisco_ucs_network_driver.py'
2--- quantum/plugins/cisco/ucs/cisco_ucs_network_driver.py 2011-07-31 18:38:26 +0000
3+++ quantum/plugins/cisco/ucs/cisco_ucs_network_driver.py 2011-08-03 01:59:35 +0000
4@@ -158,9 +158,9 @@
5 data = data.replace(VLAN_NAME, vlan_name)
6 return data
7
8- def _create_profile_client_post_data(self, profile_name):
9+ def _create_profile_client_post_data(self, profile_name, profile_client_name):
10 data = ASSOCIATE_PROFILE.replace(PROFILE_NAME, profile_name)
11- data = data.replace(PROFILE_CLIENT, profile_name)
12+ data = data.replace(PROFILE_CLIENT, profile_client_name)
13 return data
14
15 def _change_vlan_in_profile_post_data(self, profile_name, old_vlan_name,
16@@ -198,7 +198,7 @@
17 ucsm_password):
18 data = self._create_profile_post_data(profile_name, vlan_name)
19 self._post_data(ucsm_ip, ucsm_username, ucsm_password, data)
20- data = self._create_profile_client_post_data(profile_name)
21+ data = self._create_profile_client_post_data(profile_name, profile_name[-16:])
22 self._post_data(ucsm_ip, ucsm_username, ucsm_password, data)
23
24 def change_vlan_in_profile(self, profile_name, old_vlan_name,

Subscribers

People subscribed via source and target branches