Merge lp:~smspillaz/unity/unity.workaround_977189 into lp:unity

[Sam Spilsbury]

Hack around the nvidia driver losing window pixmaps when minimizing windows. See LP #977189

== Problem ==

See bug 977189 - the nvidia driver loses the pixmaps of windows that are minimized (input shape changes perhaps ?)

== Solution ==

Hack around it - force a rebind of those windows whenever the minimize animation has completed.

== Tests ==

Manual test included

UNBLOCK

[Didier Roche-Tolomelli (didrocks)]

ugly hacks ftw! mhr3 and I confirm it fixes this really ugly bug on nvidia (which is on the priority list). So approving.

review: Approve

[Michal Hruby (mhr3)]

Indeed...

review: Approve

=== added file 'manual-tests/NvMinimizedWindows.txt'
--- manual-tests/NvMinimizedWindows.txt	1970-01-01 00:00:00 +0000
+++ manual-tests/NvMinimizedWindows.txt	2012-04-11 14:21:27 +0000
@@ -0,0 +1,11 @@
+Nvidia white windows in spread
+----------
+This test ensures that windows are not white in the spread using nvidia.
+
+#. Ensure unity is running on a machine with a nvidia GPU using the nvidia driver
+#. Open two windows of the same app
+#. Minimize one
+#. Click the launcher icon to activate the spread
+
+Outcome:
+  The contents of both windows should be visible.

=== modified file 'plugins/unityshell/src/compizminimizedwindowhandler.h'
--- plugins/unityshell/src/compizminimizedwindowhandler.h	2012-03-14 06:24:18 +0000
+++ plugins/unityshell/src/compizminimizedwindowhandler.h	2012-04-11 14:21:27 +0000
@@ -298,7 +298,12 @@
         if (CompOption::getBoolOptionNamed (o, "active", false))
           minimizingWindows.push_back (w);
         else
+        {
+          /* Ugly hack for LP#977189 */
+          CompositeWindow::get (w)->release ();
+          GLWindow::get (w)->release ();
           minimizingWindows.remove (w);
+        }
       }
     }
   }