Code review comment for lp:~smspillaz/unity/unity.oem-fixes

Revision history for this message
Jason Smith (jassmith) wrote :

style fixes:
- please make sure to use brackets around all loops (for loops especially)

GL changes:
There is no reason to disable the scissor bit if you are going to pop the attrib right afterwards. Small change though I remember we ran into another weird state issue not long ago. I can't remember what exactly it was but it was something similar to this (multiple changes to the same bit in a row for no reason)

Please check the result of glGetError

review: Approve

« Back to merge proposal