Code review comment for lp:~smspillaz/unity/unity.fix_877778

Sam Spilsbury (smspillaz) wrote :

> The tests shouldn't be calling the virtual methods. It should be dealing only with the interface methods.

As far as I can tell the tests are not calling virtual methods directly (in fact, they can't doing so would raise a compile error ...)

The ON_CALL and EXPECT_CALL macros however do need to be on the virtual methods, because that's what they are mocking.

« Back to merge proposal