Merge lp:~smspillaz/unity/unity.fix_835259 into lp:unity

Proposed by Sam Spilsbury
Status: Merged
Approved by: Sam Spilsbury
Approved revision: no longer in the source branch.
Merged at revision: 1672
Proposed branch: lp:~smspillaz/unity/unity.fix_835259
Merge into: lp:unity
Diff against target: 17 lines (+5/-2)
1 file modified
plugins/unityshell/src/unityshell.cpp (+5/-2)
To merge this branch: bzr merge lp:~smspillaz/unity/unity.fix_835259
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
Review via email: mp+77556@code.launchpad.net

Description of the change

Fix bug 835259

There's a race condition that can happen here where compiz would have already destroyed the window before bamf knows about the window being destroyed, so it will still be in bamf_view_get_children

To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/unityshell.cpp'
2--- plugins/unityshell/src/unityshell.cpp 2011-09-29 07:45:55 +0000
3+++ plugins/unityshell/src/unityshell.cpp 2011-09-29 15:22:14 +0000
4@@ -634,9 +634,12 @@
5 for (LayoutWindow::Ptr target : targets)
6 {
7 CompWindow* window = screen->findWindow(target->xid);
8- UnityWindow *unity_window = UnityWindow::get (window);
9+ if (window)
10+ {
11+ UnityWindow *unity_window = UnityWindow::get (window);
12
13- unity_window->paintThumbnail (target->result, target->alpha);
14+ unity_window->paintThumbnail (target->result, target->alpha);
15+ }
16 }
17 }
18