Merge lp:~smspillaz/unity/unity.fix_1185226 into lp:unity

Proposed by Sam Spilsbury
Status: Merged
Approved by: Francis Ginther
Approved revision: no longer in the source branch.
Merged at revision: 3356
Proposed branch: lp:~smspillaz/unity/unity.fix_1185226
Merge into: lp:unity
Diff against target: 10 lines (+1/-0)
1 file modified
CMakeLists.txt (+1/-0)
To merge this branch: bzr merge lp:~smspillaz/unity/unity.fix_1185226
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Stephen M. Webb (community) Approve
Review via email: mp+166163@code.launchpad.net

Commit message

Add a pkg-config dependency on xpathselect>=1.2

Technically we depend on xpathselect>=1.3 in debian/control, however
the latest -dev package in the distro claims the version is 1.2 and it
builds just fine with that.

(LP: #1185226)

Description of the change

Add a pkg-config dependency on xpathselect>=1.2

Technically we depend on xpathselect>=1.3 in debian/control, however
the latest -dev package in the distro claims the version is 1.2 and it
builds just fine with that.

(LP: #1185226)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Stephen M. Webb (bregma) wrote :

I'm OKing this because it's a correct and needed fix, pending the Jenkins gcov failure being resolved and getting a clean run.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Jenkins couldn't find the gpg key for the ppa its trying to add.

Revision history for this message
Francis Ginther (fginther) wrote :

Things appear to be functional again, re-approving.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-05-16 23:30:28 +0000
3+++ CMakeLists.txt 2013-05-29 01:44:27 +0000
4@@ -225,6 +225,7 @@
5 nux-4.0>=4.0.1
6 sigc++-2.0
7 unity-misc>=0.4.0
8+ xpathselect>=1.2
9 zeitgeist-1.0>=0.3.18
10 )
11