lp:~smspillaz/nux/nux.fix_1097281

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:nux at revision 761

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2013-02-25

Brandon Schaefer (community): Approve on 2013-02-02

Diff: 958 lines (+667/-18)

8 files modified

Nux/MainLoopGLib.cpp (+96/-0)
Nux/MainLoopGLib.h (+21/-0)
Nux/ProgramFramework/ProgramTemplate.cpp (+102/-1)
Nux/ProgramFramework/ProgramTemplate.h (+26/-0)
Nux/WindowThread.cpp (+108/-5)
Nux/WindowThread.h (+26/-0)
tests/gtest-nux-windowthread.cpp (+257/-8)
tests/xtest-text-entry.cpp (+31/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1097281: segmentation fault when running nux tests

Low

Fix Released

Link a bug report

Related blueprints

758. By Sam Spilsbury on 2013-02-01

Remove the main source too

757. By Sam Spilsbury on 2013-02-01

Implement a message-passing system in nux::WindowThread and nux::ProgramFramework.

This makes it possible to define and implement protocols for WindowThreads to
communicate with each other in a thread-safe way without having to resort to
using window system events or the like.

New file descriptors can be added for watching with a watch-callback executed
inside the window thread with nux::WindowThread::WatchFdForEvents. Only
read-data is supported right now.

When there is new data available to be read, the provided FdWatchCallback will
be called by the window thread, and executed inside the window thread. From
there, clients can safely modify data contained by the WindowThread object.

Remove a watched file descriptor with UnwatchFd.

It is safe to add file descriptors for watching during the call to the provided
ThreadUserInitFunc in CreateGUIThread. This is because the main loop
implementation must be created before those file descriptors are added for
watching (particularly in the case of GLib, because nux::WindowThread::InitGlibLoop
will use the default GMainContext the first time it is called, and then create
a new one for each window thereafter.

Added three new tests to demonstrate and cover this functionality.

[==========] Running 3 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 3 tests from TestWindowThread
[ RUN ] TestWindowThread.WatchFd
[ OK ] TestWindowThread.WatchFd (3213 ms)
[ RUN ] TestWindowThread.MultiWatchFd
[ OK ] TestWindowThread.MultiWatchFd (3163 ms)
[ RUN ] TestWindowThread.OneFdEvent
[ OK ] TestWindowThread.OneFdEvent (3155 ms)
[----------] 3 tests from TestWindowThread (9532 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 1 test case ran. (9532 ms total)
[ PASSED ] 3 tests.

Fixed segfaulting test xtest-text-input. That test unsafely mutated object
state contained by the WindowThread running in another thread inside of the
test thread. This resulted in a null pointer dereference because it had a
side effect of calling nux::GetWindowThread () which relies on up-to-date
thread-local-storage. That test now defines a protocol to communicate to
the running program to mutate the relevant state, and then communicate back
when it has completed execution.

(LP: #1097281)

756. By Ricardo Salveti on 2013-01-29

gtest.m4: avoid using AC_CHECK_FILES because it breaks cross-compilation.

Approved by Stephen M. Webb.

755. By Daniel d'Andrada on 2013-01-29

Fix "make check" when geis is located outside /usr.

Approved by Stephen M. Webb.

754. By Andrea Azzarone on 2013-01-28

Remove no longer needed code.

Approved by Marco Trevisan (Treviño).

753. By PS Jenkins bot on 2013-01-25

Releasing 4.0.0daily13.01.25-0ubuntu1 to ubuntu.

Approved by .

752. By Łukasz Zemczak on 2013-01-22

Bump the ABI version since the latest changes in trunk modified the ABI.

Approved by Nicolas d'Offay.

751. By Nicolas d'Offay on 2013-01-21

Added linear sample gaussian blur shader which halves the loop count of our vertical and horizontal blur drastically improving performance.

Approved by Nicolas d'Offay.

750. By PS Jenkins bot on 2013-01-19

Releasing 4.0.0daily13.01.18-0ubuntu1 to ubuntu.

Approved by .

749. By Andrea Azzarone on 2013-01-18

Don't use deprecated functions. Fixes: https://bugs.launchpad.net/bugs/1100927.

Approved by Andrea Azzarone, Łukasz Zemczak, Brandon Schaefer.