lp:folly

Branch merges

Related source package recipes

1 recipe using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

8991. By Simon Capper <email address hidden> 11 hours ago

Workaround compiler error with gcc version 5 &6

Summary: gcc versions 5 & 6 do not support template specializations outside the original namespace of the template even if the namespace is explicitly included in the template specialization.

Differential Revision: D24505812

fbshipit-source-id: 693e93de5bc5074866fdea713436a06d35762cb7

8990. By Andrii Grynenko <email address hidden> 15 hours ago

Make AtomicNotificationQueue::size() TSAN-clean

Summary:
taskExecuteCount_ can be incremented from a single thread, but reading it from another thread is still technically a data race. Mark it as atomic to make TSAN happy.
Also make sure we never return < 0 when called from a non-consumer thread (since we only have the synchronization guarantee on the consumer thread).

Differential Revision: D24523284

fbshipit-source-id: 6185125e132d71a83a3f29c909b7e4eab09e6e79

8989. By Dave Rigby <email address hidden> 16 hours ago

FindGlog: Add support for 'glogd' Debug library (#1479)

Summary:
Glog v0.4.0 when configured with Debug build type adds a 'd' suffix to
the library file. This results in FindGlog.cmake failing to locate it.

Update FindGlog.cmake to use check for 'glogd', and use
select_library_configurations() to set GLOG_LIBRARY to the correct
found filename.

(Note: this has no effect if a non-Debug type is used.)

Pull Request resolved: https://github.com/facebook/folly/pull/1479

Reviewed By: yfeldblum

Differential Revision: D24503510

Pulled By: Orvid

fbshipit-source-id: 705df05a4a3d7df2df8af3bb66c319fb044adbce

8988. By Andrii Grynenko <email address hidden> on 2020-10-23

Use alignas(folly::cacheline_align_v) to improve NotificationQueue perf

Summary: This also splits queue size counter into two to make sure we do fewer atomic operations on the consumer thread.

Differential Revision: D24490151

fbshipit-source-id: 69297a2fd0c5fddcd7355a28fe600b72320e81cd

8987. By Andrii Grynenko <email address hidden> on 2020-10-23

Minor AtomicNotificationQueue cleanup

Summary: Following up on some comments on the initial diff.

Differential Revision: D24489715

fbshipit-source-id: baea66c7b811ebabf4476d7fd6a1136ab9ec2282

8986. By Andrii Grynenko <email address hidden> on 2020-10-23

Use AtomicNotificationQueue in EventBase

Differential Revision: D24414496

fbshipit-source-id: ad552d3dd58b6c351c99e5f8c9056c5829c4c095

8985. By Victor Zverovich <email address hidden> on 2020-10-23

Add a StringPiece formatter

Summary: Add an {fmt} formatter for `StringPiece`. This is much faster than going through ostream `operator<<` which we fallback to otherwise.

Reviewed By: yfeldblum

Differential Revision: D24337424

fbshipit-source-id: c6f1775cf83cfa6bcaa25cb4f6b665a76672e7c3

8984. By Nanshu Chen <email address hidden> on 2020-10-23

clean up unnecessary c++ extern imports

Summary:
A lot of these imports with specialization is not necessary. Clean up them to use generic functions instead.

(Note: this ignores all push blocking failures!)

Reviewed By: yfeldblum

Differential Revision: D24236181

fbshipit-source-id: fe6e6c41f680561c625b263bc6adeba738ddb252

8983. By Sridhar Srinivasan <email address hidden> on 2020-10-22

Invoke life cycle observer callbacks during event base attach and

Summary: Inform LifecycleObservers when an EventBase is attached or detached from an AsyncSocket.

Reviewed By: bschlinker

Differential Revision: D24294292

fbshipit-source-id: 652ec438d0b6213a78742b8a8ef0d24d55ac9816

8982. By Margot Leibold <email address hidden> on 2020-10-22

Implement ReadMostlyTLObserver

Summary: Implement a thread local Observer that optimizes on the shared_ptr copy by using ReadMostlySharedPtr

Reviewed By: andriigrynenko

Differential Revision: D24439652

fbshipit-source-id: 9174be7f3f2fc34bdc79bd83eab571972b0c057d