lp:folly

Created by Sam Spilsbury on 2013-05-10 and last modified on 2018-07-21
Get this branch:
bzr branch lp:folly

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Sam Spilsbury
Project:
folly
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://github.com/facebook/folly.git.

The next import is scheduled to run in 5 hours.

Last successful import was 2 minutes ago.

Import started 2 minutes ago on izar and finished 2 minutes ago taking 15 seconds — see the log
Import started 6 hours ago on izar and finished 6 hours ago taking 20 seconds — see the log
Import started 12 hours ago on alnitak and finished 12 hours ago taking 20 seconds — see the log
Import started 18 hours ago on izar and finished 18 hours ago taking 20 seconds — see the log
Import started on 2018-07-21 on izar and finished on 2018-07-21 taking 15 seconds — see the log
Import started on 2018-07-21 on alnitak and finished on 2018-07-21 taking 20 seconds — see the log
Import started on 2018-07-21 on alnitak and finished on 2018-07-21 taking 20 seconds — see the log
Import started on 2018-07-20 on alnitak and finished on 2018-07-20 taking 20 seconds — see the log
Import started on 2018-07-20 on izar and finished on 2018-07-20 taking 20 seconds — see the log
Import started on 2018-07-20 on alnitak and finished on 2018-07-20 taking 20 seconds — see the log

Recent revisions

5705. By Yedidya Feldblum <email address hidden> on 2018-07-21

Generic conversion from Range in cases like std::string_view

Summary: [Folly] Generic conversion from `Range` in cases like `std::string_view` which are constructible with `Iter, size_type` instead of `Iter, Iter`.

Reviewed By: vitaut

Differential Revision: D8907212

fbshipit-source-id: 6f93581b7185d4d10925aa57175f130dff2576e3

5704. By Yedidya Feldblum <email address hidden> on 2018-07-21

Use traits in Range conversion functions

Summary:
[Folly] Use traits in `Range` conversion functions.

Dependent code requires this for msvc2015.

Reviewed By: vitaut

Differential Revision: D8929559

fbshipit-source-id: dbf4afbebdf92ee4eb46067ff443980823cd771d

5703. By Jason Rahman <email address hidden> on 2018-07-20

Rename HHWheelTimer::Callback::context_ -> requestContext_

Summary: HHWheelTimer::Callback is frequently used as a base class for callback objects, while context_ is a commonly desired member name in other classes that also serve as base classes for HHWheelTimer::Callback derived classes. Renaming in HHWheelTimer::Callback to free up availability of context_.

Reviewed By: yfeldblum

Differential Revision: D8937020

fbshipit-source-id: 8a4612bc57f28673762604cc118a91a347e5972d

5702. By Matthieu Martin <email address hidden> on 2018-07-20

Revert Folly NestedRequestContextGuard

Summary:
This attempted to provide a deep copy guard for folly request context.

Per brainstorming (see task), we don't think that deep copying all metadata has legitimate use cases. And in fact, this has no usage in our codebase currently. Because it default to reset (when createChild is not overriden), the behaviour is also very confusing.

Guards's goal is usually to copy 1 metadata. The solution for that is to provide a shallow copy guard. Something that I will do on top of this revert.
I'll wait for both changes to be discussed and accepted before landing this one.

Reviewed By: yfeldblum, LeeHowes

Differential Revision: D8906912

fbshipit-source-id: e8b9eed04cbe539009037ff75d51e28941502d88

5701. By Matthieu Martin <email address hidden> on 2018-07-20

Fix set/unset for default folly RequestContext

Summary:
My guess is that if we allow to set data in the default context, we also expect set/unset to work.
It currently doesn't. This fixes it (at least, the test repro passes), but not sure it's the right fix.

Reviewed By: djwatson

Differential Revision: D8910506

fbshipit-source-id: cedf1dd0ee91761d210137949da7477ed69fce31

5700. By Yedidya Feldblum <email address hidden> on 2018-07-20

Comments to document explicit conversions from Range

Summary: [Folly] Comments to document explicit conversions from `Range`.

Reviewed By: terrelln

Differential Revision: D8921990

fbshipit-source-id: 0728e0096738f9a86eecfaa5b05d4dfbcb0533b6

5699. By Yedidya Feldblum <email address hidden> on 2018-07-20

Cut non-const conversion overloads from Range

Summary: [Folly] Cut non-`const` conversion overloads from `Range`, for both `operator T` and `to<T>`: let them be `const` member functions so that the converted-to object cannot update `Range` internal state.

Reviewed By: terrelln, vitaut

Differential Revision: D8921428

fbshipit-source-id: eefc14b5fe2033cac43ebc274b27bdea95388488

5698. By Edwin Smith <email address hidden> on 2018-07-19

Fix visitContiguousRanges() for empty and single chunk containers

Summary:
lastOccupiedChunks has UB with an empty container, because
the end() iterator itemPtr_ is null.

And with a single chunk, we must enter the iteration loop.

Reviewed By: nbronson

Differential Revision: D8897447

fbshipit-source-id: 7e7fd06ec7a588236eebf28f43af9ef4ab2d39cd

5697. By Dan Melnic <email address hidden> on 2018-07-19

Fix threadlocal_detail::ElementWrapper::dispose crash due to array reallocation

Summary: Fix threadlocal_detail::ElementWrapper::dispose crash due array to reallocation

Reviewed By: yfeldblum, djwatson

Differential Revision: D8868394

fbshipit-source-id: dc0c91250f2ffbcba7ac4f0bcf0d048e7785d65f

5696. By Yang Zhang <email address hidden> on 2018-07-18

Add ThreadPoolExecutor::numActiveThreads()

Summary: ThreadPoolExecutor could dynamically adjust number of threads according to workload. Add numActiveThreads() so we can check how many active threads are actually there, while numThreads() returns the upper bound of threads.

Reviewed By: djwatson

Differential Revision: D8683795

fbshipit-source-id: 09f3b4ee8570e2f2f9f97e939061693f3e0639af

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers