lp:folly

Branch merges

Related source package recipes

1 recipe using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

8558. By Sotirios Delimanolis <email address hidden> 8 hours ago

Add FOLLY_OPENSSL_PREREQ macro function

Summary:
This diff introduces a new macro function to resolve whether the current OpenSSL version available is greater than or equal to the given (major, minor, fix) version tuple.

We used the rules defined in the [OPENSSL_VERSION_NUMBER man page](https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_VERSION_NUMBER.html), ie. nibbles for each of
```
 MNNFFPPS: major minor fix patch status
```

We choose to ignore `patch` and `status` for simplicity and because we don't expect to build against such versions.

The existing `FOLLY_OPENSSL_IS_110` variable already checks for greater than or equal to version number 1.1.0, so I didn't feel the need to modify it (nor the other variables). We can do some clean up in a future diff.

Reviewed By: yfeldblum, mingtaoy

Differential Revision: D22346692

fbshipit-source-id: 156ee69ecd619de12319d7d63239f28c323820a4

8557. By Kirk Shoop <email address hidden> 10 hours ago

create explicit instantiations for folly::Unit

Summary:
move template instantiations for folly::Unit of several types into explicit instantiations in cpp files.

`folly::Future<folly::Unit>`
`folly::SemiFuture<folly::Unit>`
`folly::Promise<folly::Unit>`
`folly::SharedPromise<folly::Unit>`
`folly::futures::detail::FutureBase<folly::Unit>`
`folly::futures::detail::Core<folly::Unit>`
`folly::Try<folly::Unit>`

Reviewed By: yfeldblum, ericniebler

Differential Revision: D22092858

fbshipit-source-id: b8faa1c8aedfc193c17e2c3bc2e5b0f429ae6b0f

8556. By Zeyi (Rice) Fan <email address hidden> on 2020-07-06

add retry flag to getdeps test

Summary: This commit adds a flag `--retry` to getdeps and teach it to run retry failed test. This allows us to still pass the tests when there are some flaky tests presents.

Reviewed By: wez

Differential Revision: D22291063

fbshipit-source-id: 572af48a52ceb4a9abbf530cc0154ded0120c0de

8555. By Pranav Thulasiram Bhat <email address hidden> on 2020-07-06

Add Task<void> specialization for taskWait

Summary:
`folly::coro::blockingWait(...)` returns `void` for `Task<void>`.

This diff implements a template specialization on taskWait for `Task<void>`

Differential Revision: D22265598

fbshipit-source-id: ff13d2b18b8706a6e8257ef706e407b315daf98a

8554. By Pranav Thulasiram Bhat <email address hidden> on 2020-07-06

Faster collectAll(args...)

Summary:
The variadic implementation of collectAll uses the futures APIs, and is likely to be slow.

This diff adds a fiber only version similar to fibers::foreach

Reviewed By: yfeldblum

Differential Revision: D22212232

fbshipit-source-id: f71765c5411d2c6ca4388fe373baafad65f1b01c

8553. By Zeyi (Rice) Fan <email address hidden> on 2020-07-06

avoid using relative path in fb_py_win_main

Summary:
After some experimenting, it is a little awkward if we want to specify a relative path based on the executable location. We'd need to add a bunch of path calculations to make it right, and I don't think the added complexity is really worth the effort.

As a result, let's just remove the use of relative path, and if we ever want to ship a copy of Python distribution, we can place it under the same directory as the binary.

Reviewed By: chadaustin

Differential Revision: D22394180

fbshipit-source-id: 86d27f6d16a03fe08826b5e5eafcef2a1c77997f

8552. By Shai Szulanski <email address hidden> on 2020-07-06

fix clang-format nits

Reviewed By: yfeldblum

Differential Revision: D22393040

fbshipit-source-id: 920a7dfbf1d4334aecb475add96d3799c89aa211

8551. By Giuseppe Ottaviano <email address hidden> on 2020-07-03

IOBufQueue::moveAsValue()

Summary: Added for symmetry with `IOBuf::cloneAsValue()`

Reviewed By: luciang

Differential Revision: D21737695

fbshipit-source-id: 40f5695565ffc7d7c389c9953bffc3ab85508ed1

8550. By Lukas Piatkowski <email address hidden> on 2020-07-03

eden/scm: provide getdeps.py way of building eden/scm on GitHub

Summary:
In order to do what the title says, this diff does:
1. Add the `eden/oss/.../third-party/rust/.../Cargo.toml` files. As mentioned in the previous diff, those are required by GitHub so that the third party dependencies that are local in fbsource are properly defined with a "git" dependency in order for Cargo to "link" crates properly.
2. Changes to `eden/scm/Makefile` to add build/install commands for getdeps to invoke. Those command knowing that they are called from withing getdeps context they link the dependencies brought by getdeps into their proper places that match their folder layout in fbsource. Those Makefile commands also pass a GETDEPS_BUILD env to the setup.py invocations so that it knows it is being called withing a getdeps build.
3. Changes to `eden/scm/setup.py` that add "thriftasset" that makes use of the getdeps.py provided "thrift" binary to build .py files out of thrift files.
4. Changes to `distutils_rust` to use the vendored crates dir provided by getdeps.
5. Changes to `getdeps/builder.py` and `getdeps/manifest.py` that enable more fine-grained configuratior of how Makefile builds are invoked.
6. Changes to `getdeps/buildopts.py` and `getdeps/manifest.py` to disable overriding PATH and pkgconfig env, so that "eden/scm" builds in getdeps using system libraries rather than getdeps-provided ones (NOTE: I've tried to use getdeps provided libraries, but the trickiest bit was that Rust links with Python, which is currently not providable by getdeps, so if you try to build everything the system provided Python libraries will collide with getdeps provided ones)
7. Added `opensource/fbcode_builder/manifests/eden_scm` for the getdeps build.

Reviewed By: quark-zju

Differential Revision: D22336485

fbshipit-source-id: 244d10c9e06ee83de61e97e62a1f2a2184d2312f

8549. By Giuseppe Ottaviano <email address hidden> on 2020-07-02

Revert D22211304: Eliminate need for reading upper bound at construction.

Differential Revision:
D22211304 (https://github.com/facebook/folly/commit/c9c5564232aaffbc0f1d3807b21bb2cd60ec4d2d)

Original commit changeset: 0dbe904c9fd8

fbshipit-source-id: 49cf24dab4f91fcebf9dc5a2db66d23683fcaa37