Merge lp:~smspillaz/compiz/compiz.fix_741656 into lp:~compiz/compiz/ubuntu

Proposed by Sam Spilsbury
Status: Superseded
Proposed branch: lp:~smspillaz/compiz/compiz.fix_741656
Merge into: lp:~compiz/compiz/ubuntu
Diff against target: 68 lines (+44/-1)
3 files modified
debian/patches/101_disable_2d_decorations.patch (+42/-0)
debian/patches/series (+1/-0)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~smspillaz/compiz/compiz.fix_741656
Reviewer Review Type Date Requested Status
Jason Smith (community) Approve
compiz packagers Pending
Review via email: mp+54725@code.launchpad.net

This proposal has been superseded by a proposal from 2011-04-04.

Description of the change

Makes window decorators not report that they support WINDOW_DECORATION_TYPE_WINDOW since this forces the 2D mode which is broken in spectacular ways.

To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :

+1 looks good

review: Approve
578. By Sam Spilsbury

Don't build debug

Unmerged revisions

578. By Sam Spilsbury

Don't build debug

577. By Sam Spilsbury

Added 101_disable_2d_decorations.patch

Disables 2D decorations from being launched since it is currently unsupported

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/patches/101_disable_2d_decorations.patch'
2--- debian/patches/101_disable_2d_decorations.patch 1970-01-01 00:00:00 +0000
3+++ debian/patches/101_disable_2d_decorations.patch 2011-03-24 16:22:20 +0000
4@@ -0,0 +1,42 @@
5+Index: compiz-0.9.4git20110322/gtk/window-decorator/gtk-window-decorator.c
6+===================================================================
7+--- compiz-0.9.4git20110322.orig/gtk/window-decorator/gtk-window-decorator.c 2011-03-22 16:46:56.000000000 +0800
8++++ compiz-0.9.4git20110322/gtk/window-decorator/gtk-window-decorator.c 2011-03-25 00:03:23.441180942 +0800
9+@@ -415,8 +415,7 @@
10+ switcher_p = gwd_get_decor_frame ("switcher");
11+
12+ decor_set_dm_check_hint (xdisplay, gdk_screen_get_number (gdkscreen),
13+- WINDOW_DECORATION_TYPE_PIXMAP |
14+- WINDOW_DECORATION_TYPE_WINDOW);
15++ WINDOW_DECORATION_TYPE_PIXMAP);
16+
17+ update_default_decorations (gdkscreen);
18+
19+Index: compiz-0.9.4git20110322/kde/window-decorator-kde4/main.cpp
20+===================================================================
21+--- compiz-0.9.4git20110322.orig/kde/window-decorator-kde4/main.cpp 2011-03-22 16:46:56.000000000 +0800
22++++ compiz-0.9.4git20110322/kde/window-decorator-kde4/main.cpp 2011-03-25 00:03:15.321169033 +0800
23+@@ -107,8 +107,7 @@
24+ }
25+
26+ decor_set_dm_check_hint (QX11Info::display (), QX11Info::appScreen (),
27+- WINDOW_DECORATION_TYPE_PIXMAP |
28+- WINDOW_DECORATION_TYPE_WINDOW);
29++ WINDOW_DECORATION_TYPE_PIXMAP);
30+
31+ if (!app->enableDecorations (timestamp))
32+ {
33+Index: compiz-0.9.4git20110322/unity/unity_window_decorator/src/gtk-window-decorator.c
34+===================================================================
35+--- compiz-0.9.4git20110322.orig/unity/unity_window_decorator/src/gtk-window-decorator.c 2011-03-25 00:03:15.201168862 +0800
36++++ compiz-0.9.4git20110322/unity/unity_window_decorator/src/gtk-window-decorator.c 2011-03-25 00:03:15.321169033 +0800
37+@@ -432,8 +432,7 @@
38+ }
39+
40+ decor_set_dm_check_hint (xdisplay, gdk_screen_get_number (gdkscreen),
41+- WINDOW_DECORATION_TYPE_PIXMAP |
42+- WINDOW_DECORATION_TYPE_WINDOW);
43++ WINDOW_DECORATION_TYPE_PIXMAP);
44+
45+ update_default_decorations (gdkscreen);
46+
47
48=== modified file 'debian/patches/series'
49--- debian/patches/series 2011-03-24 11:03:37 +0000
50+++ debian/patches/series 2011-03-24 16:22:20 +0000
51@@ -9,3 +9,4 @@
52 086_new_grid_defaults.patch
53 090_git_fix_new_invisible_windows.patch
54 100_bump_core.h.patch
55+101_disable_2d_decorations.patch
56
57=== modified file 'debian/rules'
58--- debian/rules 2011-03-01 12:31:42 +0000
59+++ debian/rules 2011-03-24 16:22:20 +0000
60@@ -12,7 +12,7 @@
61
62 override_dh_auto_configure:
63 # currently, segfault if CMAKE_BUILD_TYPE=Release
64- dh_auto_configure -- -DCOMPIZ_BUILD_WITH_RPATH=FALSE -DCOMPIZ_DEFAULT_PLUGINS=\"$(DEFAULT_PLUGINS)\" -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCOMPIZ_PACKAGING_ENABLED=TRUE
65+ dh_auto_configure -- -DCOMPIZ_BUILD_WITH_RPATH=FALSE -DCOMPIZ_DEFAULT_PLUGINS=\"$(DEFAULT_PLUGINS)\" -DCMAKE_BUILD_TYPE=Debug -DCOMPIZ_PACKAGING_ENABLED=TRUE
66
67 override_dh_install:
68 # Language packs

Subscribers

People subscribed via source and target branches

to all changes: