Created by Sam Spilsbury and last modified
Get this branch:
bzr branch lp:~smspillaz/compiz-plugins-main/compiz-plugins-main.work_923683
Only Sam Spilsbury can upload to this branch. If you are Sam Spilsbury please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Sam Spilsbury
Compiz Main Plugins

Recent revisions

28. By Sam Spilsbury

Use serverGeometry

27. By Sam Spilsbury

Don't increment the destroy ref count of a window unless an animation is
active. (LP: #940603)

It doesn't make any sense to increase the destroy reference count of a window
on CompWindowNotifyBeforeDestroy based on whether or not an an animation for
that window "could" be allowed - CompWindowNotifyBeforeDestroyed is called
on CompWindow::destroy (which under sane circumstances, should only ever be
called when the window is either reparented away from its parent or the root
window or when the window is destroyed).

In this case, we deregister all events on the window so it isn't possible to
determine through any normal means that a close animation is going to activate
on the window. And in any event, the unmap which causes close animations
always comes before the DestroyNotify or ReparentNotify anyways.

Even if the CompWindowNotifyClose were to somehow come after the window
received a ReparentNotify or DestroyNotify, the tradeoff then comes between
not playing animations for those corner case windows or keeping ghost windows
on screen because we kept a destroy reference and never got rid of it. In this
case, it is more sane to do the former.

26. By Sam Spilsbury

Added a flag to specify whether an animation actually needs a transformed
window. (LP: #976469)

25. By Daniel van Vugt

Fix stuttering animations on large/fullscreen windows by using the higher
performance rendering method (full screen damage). (LP: #930192)

24. By Daniel van Vugt

Don't pass through keystrokes you are using to the active window (LP: #953834)

23. By Łukasz Zemczak

Remove the terminate_button option as it's not referenced anywhere in the code.

The terminate_button option was defined in XML but is not actually used or referenced anywhere in the plugin code. Therefore actually using the binding resulted in compiz crashing. Fixes #954079.

21. By Daniel van Vugt

Update NEWS and AUTHORS for

20. By Sam Spilsbury

Merge rev 199 from lp:compiz-workarounds-plugin

revno: 119 [merge]
author: Łukasz Zemczak
committer: smspillaz <email address hidden>
branch nick: compiz-workarounds-plugin
timestamp: Tue 2012-02-28 16:40:47 +0800
  = Problem description =

  Sometimes, X returns strange XDamageNotifyEvent's to our processing damage callbacks. Those damage events seem to have invalid area coordinates, set to the same values as the geometry. One of the resulting bugs is, for instance, #931473 - as because of this sometimes menus on initial popup are not updated as they should.

  = The fix =

  As a workaround, we prepare a damageRect() callback that forces a complete window redraw for initial damage handling (as advised by Sam, thanks!)

  = Test coverage =

  It is possible to check if the fix works by trying to reproduce the #931473 bug with the fix applied. Fast titlebar context menu invoking now always shows the menu fully redrawn.

  Merge lp:~sil2100/compiz-workarounds-plugin/initial_damage into lp:compiz-workarounds-plugin

19. By Sam Spilsbury

Merge lp:compiz-plugins-main

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
This branch contains Public information 
Everyone can see this information.