lp:~smspillaz/compiz-plugins-main/compiz-plugins-main.fix_939228

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:compiz-plugins-main

Compiz Maintainers: Pending requested 2012-04-24

Diff: 455 lines (+336/-45)

8 files modified

wall/CMakeLists.txt (+4/-1)
wall/src/offset_movement/CMakeLists.txt (+57/-0)
wall/src/offset_movement/include/offset-movement.h (+41/-0)
wall/src/offset_movement/src/offset-movement.cpp (+62/-0)
wall/src/offset_movement/tests/CMakeLists.txt (+50/-0)
wall/src/offset_movement/tests/test-wall-offset-movement.cpp (+97/-0)
wall/src/wall.cpp (+22/-43)
wall/src/wall.h (+3/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

33. By Sam Spilsbury on 2012-04-24

Add dl

32. By Sam Spilsbury on 2012-04-24

checkin missing files

31. By Sam Spilsbury on 2012-04-24

Multimonitor aware window displacement algorithm LP#939228

30. By Daniel van Vugt on 2012-04-24

Prepare to release compiz-plugins-main 0.9.7.2

29. By Daniel van Vugt on 2012-04-24

Change the mouse pointer while dragging windows in expo. Just like the
ubuntu branches do. (LP: #987647)

28. By micove on 2012-04-24

Fix exec_prefix in some of the pc files. (LP: #959260)
---
Add missing library links. (LP: #959260)
I checked the buildlogs and found:
dpkg-shlibdeps: warning: debian/compiz-fusion-plugins-main/usr/lib/x86_64-linux-gnu/compiz/libwall.so
contains an unresolvable reference to symbol dlopen: it's probably a plugin.

dpkg-shlibdeps assumes that the program that loads the plugins provides these
symbols therefore not giving an error.

[Miguel Colon <email address hidden>, 2012-03-14]

27. By Sam Spilsbury on 2012-04-10

Don't increment the destroy ref count of a window unless an animation is
active. (LP: #940603)

It doesn't make any sense to increase the destroy reference count of a window
on CompWindowNotifyBeforeDestroy based on whether or not an an animation for
that window "could" be allowed - CompWindowNotifyBeforeDestroyed is called
on CompWindow::destroy (which under sane circumstances, should only ever be
called when the window is either reparented away from its parent or the root
window or when the window is destroyed).

In this case, we deregister all events on the window so it isn't possible to
determine through any normal means that a close animation is going to activate
on the window. And in any event, the unmap which causes close animations
always comes before the DestroyNotify or ReparentNotify anyways.

Even if the CompWindowNotifyClose were to somehow come after the window
received a ReparentNotify or DestroyNotify, the tradeoff then comes between
not playing animations for those corner case windows or keeping ghost windows
on screen because we kept a destroy reference and never got rid of it. In this
case, it is more sane to do the former.

26. By Sam Spilsbury on 2012-04-10

Added a flag to specify whether an animation actually needs a transformed
window. (LP: #976469)

25. By Daniel van Vugt on 2012-03-21

Fix stuttering animations on large/fullscreen windows by using the higher
performance rendering method (full screen damage). (LP: #930192)

24. By Daniel van Vugt on 2012-03-20

Don't pass through keystrokes you are using to the active window (LP: #953834)