Compiz Configuration Library

Code review comment for lp:~smspillaz/compiz-libcompizconfig/ccs-object

  1. ccs-object
  2. Merge into 0.9.8
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> > ccsObjectRemoveInterface assigns pointers "interfaces" and "interface_types"
> > to NULL without first freeing the memory referenced.
> >
> > ccsObjectAddInterface assigns pointers "interfaces" and "interface_types"> >
> > without first freeing the memory referenced.
>
> They use realloc, so I don't see why this is a problem ?

Ah, I wrongly assumed you were using a function with different semantics to avoid the problems discussed earlier (i.e. invalidating the object on failed realloc).

« Back to merge proposal