Merge lp:~smspillaz/compiz-core/compiz-core.work_923683 into lp:compiz-core

[Sam Spilsbury]

A lot of the work that I've wanted to do in order to properly fix this, but in a far more condensed form. (bug 923683). Proposing early so that ~vanvugt will see it :)

Always use the asynchronous codepaths in core. This commit changes the following:

 * CompWindow::move is now just a wrapper around CompWindow::configureXWindow
 * CompWindow::configureXWindow will always call through to moveNotify
 * moveNotify is only ever called pre-request to the server in the case of
   managed windows (SubstructureRedirectMask guaruntees they will end up in
   the right place) and post ConfigureNotify for override redirect windows
 * resizeNotify is always called post ConfigureNotify regardless of whether
   or not the window is managed or not
 * composite and opengl now use the geometry last sent to the server in order
   to compute display matrices and window positions as well as damage regions
 * decor now also does the above
 * const correctness in include/core/window.h
 * removed priv->width and priv->height , which was just redundant data used for
   window shading and honestly, is a ticking time bomb for future maintainers.
 * CompWindow::syncPosition is now deprecated and a no-op
 * Removed the majority of PrivateWindow::updateFrameWindow - this function had a lot
   of redundant code which PrivateWindow::reconfigureXWindow had anyways - the big work
   there was to send synthetic ConfigureNotify events to ourselves to notify about windows
   moving within frame windows that don't move themselves. Its safer to use reconfigureXWindow
   in this case and probably more sane too. We should look into removing the other update* functions.

Caveats:

 0) There are no tests yet
 1) Window movement performance will regress with this branch. This is *probably* due to the fact that for every slight movement, we send a full ConfigureWindow request to the X Server and it has to post back to us a full ConfigureNotify, for pretty much every pixel the window moves. In the case that we're not doing compositing thats fine, but in every other case its *super* chatty and largely unnecessary. This can probably be optimized a lot, but that will require work to gather up requests that we want to send to the X server - combine them (eg, merging the stack of requests based on the change mask and using the latest values where appropriate). Thats a lot of work and probably not appropriate in this branch
 2) The diff is a little big
 3) No tests
 4) Window shading is more than likely going to break again, mostly because I haven't tested it yet, but also because shading does some strange things and manipulated geometry values in strange ways
 5) No tests

Testing plan?

I would imagine here that the PendingConfigureRequests object can probably be split out into something testable, as can the logic to strip flags from frame window geometry and client window geometry updates.

[Sam Spilsbury (smspillaz)]

The diff is big and scary, but its not too complicated. I'll explain each separate part

1 === modified file 'include/core/window.h'
2 --- include/core/window.h 2012-01-20 15:20:44 +0000
3 +++ include/core/window.h 2012-01-31 17:12:59 +0000
4 @@ -398,9 +398,9 @@
5
6 bool hasUnmapReference ();
7
8 - bool resize (XWindowAttributes);
9 + bool resize (const XWindowAttributes &);
10
11 - bool resize (Geometry);
12 + bool resize (const Geometry &);
13
14 bool resize (int x, int y, int width, int height,
15 int border = 0);

const correctness

31 int x1, x2, y1, y2;
32
33 - CompWindow::Geometry geom = priv->window->geometry ();
34 - CompWindowExtents output = priv->window->output ();
35 + const CompWindow::Geometry &geom = priv->window->serverGeometry ();
36 + const CompWindowExtents &output = priv->window->output ();

more const correctness

35 + const CompWindow::Geometry &geom = priv->window->serverGeometry ();
36 + const CompWindowExtents &output = priv->window->output ();

Lots of this - in paint code we want to use serverFoo because it was the last thing sent to the server. And this is always guarunteed to come back to us.

166 - unsigned int width = window->size ().width ();
167 - unsigned int height = window->size ().height ();
168 + unsigned int width = window->geometry ().width ();
169 + unsigned int height = window->geometry ().height ();

CompWindow::size was just returning CompSize (priv->width, priv->height) which was just redundant data which should be removed. Replaced it with geometry () for clarity

299 + void move (int dx, int dy, bool sync);
300 + bool resize (int dx, int dy, int dwidth, int dheight, int dborder);
301 + bool resize (const CompWindow::Geometry &g);
302 + bool resize (const XWindowAttributes &attrib);
303 +

Added PrivateWindow::move and PrivateWindow::resize - to be called whenever a new position / size comes back from the server. (cut'n'paste code from CompWindow::move and CompWindow::resize

335 -
336 - gettimeofday (&lastConfigureRequest, NULL);
337 - /* Flush any changes made to serverFrameGeometry or serverGeometry to the server
338 - * since there is a race condition where geometries will go out-of-sync with
339 - * window movement */
340 -
341 - window->syncPosition ();
342 -
343 - if (serverInput.left || serverInput.right || serverInput.top || serverInput.bottom)
344 - {
345 - int bw = serverGeometry.border () * 2;
346 -
347 - xwc.x = serverGeometry.x () - serverInput.left;
348 - xwc.y = serverGeometry.y () - serverInput.top;
349 - xwc.width = serverGeometry.width () + serverInput.left + serverInput.right + bw;
350 - if (shaded)
351 - xwc.height = serverInput.top + serverInput.bottom + bw;
352 - else
353 - xwc.height = serverGeometry.height () + serverInput.top + serverInput.bottom + bw;
354 -
355 - if (shaded)
356 - height = serverInput.top + serverInput.bottom;
357 -
358 - if (serverFrameGeometry.x () == xwc.x)
359 - valueMask &= ~(CWX);
360 - else
361 - serverFrameGeometry.setX (xwc.x);
362 -
*snip*
616 - XMoveResizeWindow (screen->dpy (), id, 0, 0,
617 - serverGeometry.width (), serverGeometry.height ());
618 - window->sendConfigureNotify ();
619 - window->windowNotify (CompWindowNotifyFrameUpdate...

[Sam Spilsbury (smspillaz)]

824 -
825 - if (!pendingConfigures.pending ())
826 - {
827 - /* Tell plugins its ok to start doing stupid things again but
828 - * obviously FIXME */
829 - CompOption::Vector options;
830 - CompOption::Value v;
831 -
832 - options.push_back (CompOption ("window", CompOption::TypeInt));
833 - v.set ((int) id);
834 - options.back ().set (v);
835 - options.push_back (CompOption ("active", CompOption::TypeInt));
836 - v.set ((int) 0);
837 - options.back ().set (v);
838 -
839 - /* Notify other plugins that it is unsafe to change geometry or serverGeometry
840 - * FIXME: That API should not be accessible to plugins, this is a hack to avoid
841 - * breaking ABI */
842 -
843 - screen->handleCompizEvent ("core", "lock_position", options);
844 - }

DIE

924 -bool
925 -PrivateWindow::checkClear ()
926 -{
927 - if (pendingConfigures.pending ())
928 - {
929 - /* FIXME: This is a hack to avoid performance regressions
930 - * and must be removed in 0.9.6 */
931 - compLogMessage ("core", CompLogLevelWarn, "failed to receive ConfigureNotify event on 0x%x\n",
932 - id);
933 - pendingConfigures.dump ();
934 - pendingConfigures.clear ();
935 - }
936 -
937 - return false;
938 -}
939 -
940 void
941 compiz::X11::PendingEventQueue::add (PendingEvent::Ptr p)
942 {
943 @@ -2454,21 +2148,6 @@
944 mValueMask (valueMask),
945 mXwc (*xwc)
946 {
947 - CompOption::Vector options;
948 - CompOption::Value v;
949 -
950 - options.push_back (CompOption ("window", CompOption::TypeInt));
951 - v.set ((int) w);
952 - options.back ().set (v);
953 - options.push_back (CompOption ("active", CompOption::TypeInt));
954 - v.set ((int) 1);
955 - options.back ().set (v);
956 -
957 - /* Notify other plugins that it is unsafe to change geometry or serverGeometry
958 - * FIXME: That API should not be accessible to plugins, this is a hack to avoid
959 - * breaking ABI */
960 -
961 - screen->handleCompizEvent ("core", "lock_position", options);
962 }

DIE

[Daniel van Vugt (vanvugt)]

GOOD IN THEORY:

* Most of the description sounds like steps in the right direction.

* Simplified: Replacing 559 lines of code with 247.

UNSURE ABOUT THE THEORY:

* "composite and opengl now use the geometry last sent to the server"
This should give maximum performance, sure, but what if (for some reason) the server rejects the configure request as being somehow invalid? Would you ever encounter that, like moving a window to an invalid location?
For stability and correctness (which should be the primary goal right now) don't we want "composite and opengl now use the geometry last received from the server"?

* Caveat #1 is not really a caveat. It's the right (intended) design. But if you want to see a (buggy) example of how to solve the chattiness look at the timer code here:
https://code.launchpad.net/~vanvugt/compiz-core/fix-764330-trunk/+merge/86497
This was slightly buggy though as it broke keyboatrd-initiated moves (incorrect pointer warp). Simple to fix, probably.

* Still no XFlush's to ensure XConfigureWindow happens immediately. Or are there adequate XSyncs already?

BAD IN THEORY:

* The diff is too big for a mere mortal (who hasn't worked on all the code before) to fully load into their mental interpreter and evaluate its theoretical correctness. Please read that sentence again; it's important.

GOOD IN PRACTICE:

* Window movement is smooth and predictable, but not really better than in oneiric.

BAD IN PRACTICE:

* The bug introduced is worse than the bug being fixed; Window contents offset from the frame/decorations whenever a window is created or maximized.

* All that code, but we still haven't reduced the lag below oneiric-levels. Still not as good as Gnome Shell.

CONCLUSION:

The theory is mostly good but there is at least one serious bug that needs fixing. We probably shouldn't risk 0.9.7.0 any more with large changes like this. We should aim to get this code into a later release when it's more stable, not 0.9.7.0.

review: Needs Fixing

[Sam Spilsbury (smspillaz)]

> GOOD IN THEORY:
>
> * Most of the description sounds like steps in the right direction.
>
> * Simplified: Replacing 559 lines of code with 247.
>
>
> UNSURE ABOUT THE THEORY:
>
> * "composite and opengl now use the geometry last sent to the server"
> This should give maximum performance, sure, but what if (for some reason) the
> server rejects the configure request as being somehow invalid? Would you ever
> encounter that, like moving a window to an invalid location?
> For stability and correctness (which should be the primary goal right now)
> don't we want "composite and opengl now use the geometry last received from
> the server"?

See http://tronche.com/gui/x/xlib/window/XConfigureWindow.html

Since we have SubstructureRedirectMask, it is guarunteed that any ConfigureWindow request we make on a child of the root window is guarunteed to end up in that position (hence the event tracker).

The only error cases I can think of is where you ask for a window to be of a size < 0 or > MAXSHORT. Ideally we should check for that case.

>
> * Caveat #1 is not really a caveat. It's the right (intended) design. But if
> you want to see a (buggy) example of how to solve the chattiness look at the
> timer code here:
> https://code.launchpad.net/~vanvugt/compiz-core/fix-764330-trunk/+merge/86497
> This was slightly buggy though as it broke keyboatrd-initiated moves
> (incorrect pointer warp). Simple to fix, probably.
>

There are some optimizations that can be done here - for example, if a window is grabbed, you can withold sending positions to the server until it is ungrabbed, or there is some other reason why you would want to do that. When that happens you can send it all at once.

> * Still no XFlush's to ensure XConfigureWindow happens immediately. Or are
> there adequate XSyncs already?

The GLib mainloop work introduced an XFlush as soon as we have finished dispatching the X event source.

>
>
> BAD IN THEORY:
>
> * The diff is too big for a mere mortal (who hasn't worked on all the code
> before) to fully load into their mental interpreter and evaluate its
> theoretical correctness. Please read that sentence again; it's important.

Indeed. The good thing is that its mostly all deletion and consolidation.

>
>
> GOOD IN PRACTICE:
>
> * Window movement is smooth and predictable, but not really better than in
> oneiric.
>
>
> BAD IN PRACTICE:
>
> * The bug introduced is worse than the bug being fixed; Window contents offset
> from the frame/decorations whenever a window is created or maximized.

Alright. I haven't seen this yet, but I have an idea of what might cause it. Will have a look into it when I get some time.

>
> * All that code, but we still haven't reduced the lag below oneiric-levels.
> Still not as good as Gnome Shell.

This will be fixed once the chattyness goes away. (as above). Watch your X.org CPU usage as you move windows - it skyrockets because at the moment we flood it with requests.

>
>
> CONCLUSION:
>
> The theory is mostly good but there is at least one serious bug that needs
> fixing. We probably shouldn't risk 0.9.7.0 any more with large changes like
> this. We should aim to get this code into a later r...

[Alan Griffiths (alan-griffiths)]

OK, I'm still wading through the changes. But I feel like a rant...

1307 CompSize
1308 CompWindow::size () const
1309 {
1310 - return CompSize (priv->width + priv->geometry.border () * 2,
1311 - priv->height + priv->geometry.border () * 2);
1312 + return CompSize (priv->geometry.width () + priv->geometry.border () * 2,
1313 + priv->geometry.height () + priv->geometry.border () * 2);
1314 }

As a change this doesn't look too bad - but it ignores a horrid design!

1. Chained operations like "priv->geometry.width ()" imply too muck knowledge of the details of "priv".
   That is "priv->width ()" would reflect less coupling.

2. You're tracing the path "priv->geometry..." many times, which suggests that the logic belongs in "geometry".
   "return priv->geometry.size ()" or "return CompSize(priv->geometry)" would reflect better coherence.

So, assuming (because borders may be optional?) that there's an unambiguous mapping from CompWindow::Geometry:

a. Add a constructor to CompSize: "explicit CompSize(CompWindow::Geometry const& g) : mWidth(g.width () + g.border () * 2) ..."
b. Add an inline method "CompSize PrivateWindow::size () const { return CompSize(priv->geometry); }"
c. Rewrite the above as "CompSize CompWindow::size () const { "return priv->size ()"; }"

[Alan Griffiths (alan-griffiths)]

264 - /* been shaded */
265 + /* been shaded
266 if (w->priv->height == 0)
267 {
268 if (w->id () == priv->activeWindow)
269 w->moveInputFocusTo ();
270 - }
271 + }*/

Comments are not for storing old versions of the code - that's what we use bzr for. ;)

review: Needs Fixing

[Alan Griffiths (alan-griffiths)]

There's a lot of "<blah>.width () + <blah>.border () * 2" and "<blah>.height () + <blah>.border () * 2" around. Surely CompWindow::Geometry could have a "widthWithBorders" method - or maybe a free function?

I'm tempted by

template<Typename T>
inline int heightWithBorders(T const& blah) { return blah.height () + blah.border () * 2; }

[Sam Spilsbury (smspillaz)]

> OK, I'm still wading through the changes. But I feel like a rant...
>
> 1307 CompSize
> 1308 CompWindow::size () const
> 1309 {
> 1310 - return CompSize (priv->width + priv->geometry.border () * 2,
> 1311 - priv->height + priv->geometry.border () * 2);
> 1312 + return CompSize (priv->geometry.width () + priv->geometry.border ()
> * 2,
> 1313 + priv->geometry.height () + priv->geometry.border () * 2);
> 1314 }
>
> As a change this doesn't look too bad - but it ignores a horrid design!
>
> 1. Chained operations like "priv->geometry.width ()" imply too muck knowledge
> of the details of "priv".
> That is "priv->width ()" would reflect less coupling.

Probably, although priv is just a private member with implementation details, I don't really see this as a large design problem.

>
> 2. You're tracing the path "priv->geometry..." many times, which suggests that
> the logic belongs in "geometry".
> "return priv->geometry.size ()" or "return CompSize(priv->geometry)" would
> reflect better coherence.
>
> So, assuming (because borders may be optional?) that there's an unambiguous
> mapping from CompWindow::Geometry:
>
> a. Add a constructor to CompSize: "explicit CompSize(CompWindow::Geometry
> const& g) : mWidth(g.width () + g.border () * 2) ..."
> b. Add an inline method "CompSize PrivateWindow::size () const { return
> CompSize(priv->geometry); }"
> c. Rewrite the above as "CompSize CompWindow::size () const { "return
> priv->size ()"; }"

+1 for all three

[Sam Spilsbury (smspillaz)]

> 264 - /* been shaded */
> 265 + /* been shaded
> 266 if (w->priv->height == 0)
> 267 {
> 268 if (w->id () == priv->activeWindow)
> 269 w->moveInputFocusTo ();
> 270 - }
> 271 + }*/
>
> Comments are not for storing old versions of the code - that's what we use bzr
> for. ;)

Indeed, this is a small portion of the code and I'm not yet sure what to do with it. When I get around to revisiting this section (when I actually get time to look at this again, wanted to get it up for review early) I'll see what can be done.

[Sam Spilsbury (smspillaz)]

> There's a lot of "<blah>.width () + <blah>.border () * 2" and "<blah>.height
> () + <blah>.border () * 2" around. Surely CompWindow::Geometry could have a
> "widthWithBorders" method - or maybe a free function?
>
> I'm tempted by
>
> template<Typename T>
> inline int heightWithBorders(T const& blah) { return blah.height () +
> blah.border () * 2; }

I'm not really sure ?

The complexity here comes from a legacy part of the X Server coming into play - a window could have fixed dimentions, but also specify a "border" which would be exclusive of the fixed dimentions, so you'd have to take this into account for all positioning operations (Xterm comes to mind here).

I definitely agree that geom.width () + geom.border () * 2 feels fragile and indeed, that has tripped me up many times before. Maybe a default parameter with a bitflag makes sense here, eg IncludeBorder , IncludeBorderFirst , IncludeBorderSecond (as it is on both sides)

[Sam Spilsbury (smspillaz)]

I'll note that the above isn't *really* all that relevant to this merge though, but good things to keep in mind in any case. I'd rather not see the diff get any better except for adding tests.

[Daniel van Vugt (vanvugt)]

Please resubmit for target branch lp:compiz-core (0.9.7)

review: Needs Resubmitting

[Alan Griffiths (alan-griffiths)]

A lot of the above is about making the code better (which the proposal doesn't attempt). However, in a previous version I pointed out that:

> 264 - /* been shaded */
> 265 + /* been shaded
> 266 if (w->priv->height == 0)
> 267 {
> 268 if (w->id () == priv->activeWindow)
> 269 w->moveInputFocusTo ();
> 270 - }
> 271 + }*/
>
> Comments are not for storing old versions of the code - that's what we use bzr for. ;)

I still think that needs fixing.

review: Needs Fixing

[Sam Spilsbury (smspillaz)]

Alright, I've updated this so that there's no distorted windows on decoration size change. Was (ironically) a race condition.

[Sam Spilsbury (smspillaz)]

For the sake of not making this diff any bigger, I'm not going to introduce unit tests here.

As for testing this I'd say the following is appropriate:

 * Add testcase for PendingConfigureEvent
 * Add testcase for rectsToRegion (serverGeometry should really be DI'd here)

Notes for the future:

 * As alan has said - the whole priv->geometry ().width () + priv->geometry ().border () * 2 is /really/ awkward and error prone, but we need it to support windows like xterm that still use this (stupid, legacy) attribute on their windows. I would say that the role of compiz::window::Geometry should thus be expanded somewhat
   - it should also encapsulate priv->region and really, geometry::x and friends should be made with reference to that. Ideally we'll store two regions, one with borders and one without. That sucks, since its a little memory hungry, but at least the cost is only really born whenever those regions need to be updated (::translate on a region with one rectangle is basically free, slightly more complicated on regions with multiple rects (eg, shaped window). The default should be to return the size /without/ borders, and have a default-parameter enum to get the size with borders.

[Daniel van Vugt (vanvugt)]

Unfortunately still fails basic testing. The same bug remains;

* The bug introduced is worse than the bug being fixed; Window contents offset from the frame/decorations whenever a window is created or maximized.

review: Needs Fixing

[Daniel van Vugt (vanvugt)]

Also... I would have thought/hoped that a simplified/stable solution would eliminate "serverGeometry" completely.

        /**
        * Geometry retrieved from the
         * last ConfigureNotify event received
         */
        Geometry & geometry () const;

        /**
         * Geometry last sent to the server
         */
        Geometry & serverGeometry () const;

I understand why we have, and why we might want, serverGeometry. However it is an optimization which only makes sense to attempt if the code is stable and bug-free to begin with.

While serious bugs remain, I think the first goal should be to simplify the logic down to just using "geometry" and remove or stub "serverGeometry".

[Sam Spilsbury (smspillaz)]

> Also... I would have thought/hoped that a simplified/stable solution would
> eliminate "serverGeometry" completely.
>
> /**
> * Geometry retrieved from the
> * last ConfigureNotify event received
> */
> Geometry & geometry () const;
>
> /**
> * Geometry last sent to the server
> */
> Geometry & serverGeometry () const;
>
> I understand why we have, and why we might want, serverGeometry. However it is
> an optimization which only makes sense to attempt if the code is stable and
> bug-free to begin with.
>
> While serious bugs remain, I think the first goal should be to simplify the
> logic down to just using "geometry" and remove or stub "serverGeometry".

There are some usescases for when we need to know what the last /received/ geometry from the server is. That's why the whole geometry/serverGeometry thing exists.

[Sam Spilsbury (smspillaz)]

Also, I'm not seeing this offset problem - could you give me some steps to reproduce it ?

[Sam Spilsbury (smspillaz)]

> > Also... I would have thought/hoped that a simplified/stable solution would
> > eliminate "serverGeometry" completely.
> >
> > /**
> > * Geometry retrieved from the
> > * last ConfigureNotify event received
> > */
> > Geometry & geometry () const;
> >
> > /**
> > * Geometry last sent to the server
> > */
> > Geometry & serverGeometry () const;
> >
> > I understand why we have, and why we might want, serverGeometry. However it
> is
> > an optimization which only makes sense to attempt if the code is stable and
> > bug-free to begin with.
> >
> > While serious bugs remain, I think the first goal should be to simplify the
> > logic down to just using "geometry" and remove or stub "serverGeometry".
>
>
> There are some usescases for when we need to know what the last /received/
> geometry from the server is. That's why the whole geometry/serverGeometry
> thing exists.

Hmm, we could make it so that serverGeometry is returned for managed windows and geometry is returned for override redirect windows on the public API. That of course means that we have to break the public API and update all the plugins.

[Daniel van Vugt (vanvugt)]

The practical problem:

Just start compiz --replace composite opengl move resize decor
and gtk-window-decorator --replace
Then every window will have its contents horizontally shifted around 15 pixels from the correct location relative to its decorations. The shift occurs whenever a window is created, maximized or restored. The shift goes away (corrects itself) when you start moving the window. On a positive note, the lag *appears* totally fixed and dragging windows is performing as well as Gnome Shell now.

The theoretical problem:

You can ignore my comments about geometry/serverGeometry for now. They are insignificant compared to the above bug. And besides, the use of both geometry and serverGeometry now appears to be yielding the desired reduction in lag.

[Daniel van Vugt (vanvugt)]

Screenshot of the bug introduced by this branch:
https://launchpadlibrarian.net/92172452/shift.png

[Sam Spilsbury (smspillaz)]

Alright, I'll have another look into it ? (Not seeing it here :( )

[Daniel van Vugt (vanvugt)]

And it gets worse:
* The usual lag has come back. I have no idea how or why it was fixed when I ran it the first time.
* When dragging windows around, the area of desktop recently exposed flashes white.

So there is no improvement in performance and 2 serious regressions introduced :(

[Sam Spilsbury (smspillaz)]

    //XSynchronize (dpy, TRUE);

:) Haven't merged your other branch

[Daniel van Vugt (vanvugt)]

Yikes. That would be another regression to be missing:
src/screen.cpp: XSynchronize (dpy, synchronousX ? True : False);

[Daniel van Vugt (vanvugt)]

Perhaps remember to pull from trunk more often.

[Daniel van Vugt (vanvugt)]

where trunk == lp:compiz-core

[Daniel van Vugt (vanvugt)]

Why doesn't the removal of XSynchronize show up in the below diff? It's obvious if I merge the branch myself. Maybe LaunchPad needs a kick to update the below diff?

[Daniel van Vugt (vanvugt)]

I think the horizontal shift bug is coming from upstream lp:compiz-core, and is exposed moreso by this branch. I can reproduce the same kind of horizontal shift jitter using just lp:compiz-core and resizing a window rapidly.

[Alan Griffiths (alan-griffiths)]

> The default should be to return the size /without/ borders,
> and have a default-parameter enum to get the size with borders.

There are very few designs where default parameters are better than multiple functions. This isn't one.

auto sizeWithoutBorders = geometry.size();
auto sizeWithBorders = geometry.sizeWithBorders(); // not geometry.size(::compiz::geometry::WithBorders);

[Daniel van Vugt (vanvugt)]

OK, the horizontal shifting bug does not seem to be caused by this branch. Just made worse by this branch.

Sam, please review that nasty issue first: bug 928173.

[Sam Spilsbury (smspillaz)]

This branch will incidentally help with a lot of the resizing issues, so I think it should be merged first.

[Daniel van Vugt (vanvugt)]

I would prefer not to approve this branch so long as the offset/shift bug is as bad as it is. If absolutely necessary, we could release without a fix for bug 928173 because it is hidden by the default Ubuntu config. But introducing this branch makes the bug unacceptably worse, as the screenshot showed.

[Daniel van Vugt (vanvugt)]

To clarify, "unacceptably worse" means that the bug will no longer be hidden in Ubuntu and will occur on every new window that opens. At least on my machine (and presumably others).

[Sam Spilsbury (smspillaz)]

.... I'm still not even seeing this issue.

I can look into resizing tonight if you really think that this is a blocker.

[Daniel van Vugt (vanvugt)]

I think I may have confused the situation by suggesting the regression introduced by this branch is bug 928173. The symptoms are actually slightly different. It's only a theory that it's the same bug, because the size of the horizontal offset looks similar.

The bug I see with this branch would be worthy of a new bug report (a critical regression) that I don't want to log. And we won't have to log that bug so long as it's fixed before this branch is merged.

[Sam Spilsbury (smspillaz)]

On Wed, 8 Feb 2012, Daniel van Vugt wrote:

> I think I may have confused the situation by suggesting the regression introduced by this branch is bug 928173. The symptoms are actually slightly different. It's only a theory that it's the same bug, because the size of the horizontal offset looks similar.
>
> The bug I see with this branch would be worthy of a new bug report (a critical regression) that I don't want to log. And we won't have to log that bug so long as it's fixed before this branch is merged.
> --
> https://code.launchpad.net/~smspillaz/compiz-core/compiz-core.work_923683/+merge/91654
> You are the owner of lp:~smspillaz/compiz-core/compiz-core.work_923683.
>

Alright.

I am looking into the decor plugin for a way to resolve this.

[Daniel van Vugt (vanvugt)]

Despite the success of the fix for #928173: lp:~smspillaz/compiz-core/compiz-core.decor_928173
the offset bug introduced by this branch persists.

This confirms that the horizontal offset/shift problems introduced (or exposed) by this branch are certainly not the same as bug 928173.

review: Needs Fixing

[Sam Spilsbury (smspillaz)]

I still can't even observe this problem that you're referring to :(

Can you specify, exactly what windows this occurs on and /exact/ steps to reproduce it ?

[Daniel van Vugt (vanvugt)]

Steps to reproduce the issue:

1. Start with an exact clone of lp:compiz-core
2. Merge in lp:~smspillaz/compiz-core/compiz-core.work_923683
3. Build and install it.
4. Run compiz --replace composite opengl move resize decor
5. Run gtk-window-decorator --replace

Now every window will be corrupted. Not just the existing ones, but any new ones you open too. The corruption persists during window resizing, but vanishes as soon as you move a window.

Here is a new screenshot:
https://launchpadlibrarian.net/92390683/shifted2.png

[Sam Spilsbury (smspillaz)]

Is the window itself shifted (eg are the input regions correctly lined up) or is it just the image that is shifted ?

[Daniel van Vugt (vanvugt)]

The window itself is shifted. The input regions correctly line up with the image still.

However, it looks like the damage events are not shifted. This causes some redraw problems.

[Sam Spilsbury (smspillaz)]

Can you post the xwininfo -all of the window, xwininfo -all -id of the parent and xwininfo -all -parent of the parent of that ?

[Daniel van Vugt (vanvugt)]

Attachments sent via email. This is interesting though;

$ diff correct.xwininfo shifted.xwininfo
11c11
< 0x2c03ca7 (has no name): () 1x1+-1+-1 +45+69
---
> 0x2c03ca7 (has no name): () 1x1+-1+-1 +34+69
13c13
< Absolute upper-left X: 46
---
> Absolute upper-left X: 35
31,32c31,32
< Corners: +46+70 -1232+70 -1232-720 +46-720
< -geometry 80x24+35+41
---
> Corners: +35+70 -1243+70 -1243-720 +35-720
> -geometry 80x24+34+41

It looks like geometry/serverGeometry might be out of sync.

[Daniel van Vugt (vanvugt)]

And why do I have so many 1x1 pixel windows?! I swear occasionally I see them on screen too.

[Sam Spilsbury (smspillaz)]

On Sun, 12 Feb 2012, Daniel van Vugt wrote:

> And why do I have so many 1x1 pixel windows?!

Applications use them as a means of doing IPC. Gtk+ is a serial offender
here.

> I swear occasionally I see them on screen too.

Under what circumstances?

> --
> https://code.launchpad.net/~smspillaz/compiz-core/compiz-core.work_923683/+merge/91654
> You are the owner of lp:~smspillaz/compiz-core/compiz-core.work_923683.
>

[Sam Spilsbury (smspillaz)]

On Sun, 12 Feb 2012, Daniel van Vugt wrote:

The frame window is in the wrong position. This means that serverGeometry
isn't the last thing sent to the server. serverGeometry is still writable
in this branch, so it could be $evilplugin doing the wrong thing here.

I don't want to spend any more time on this until wednesday. So I'll pick
it up then.

(compiz run with --debug will have some logs which can confirm this btw)

Incidentally, you don't see any of those "unmatched ConfigureNotify"
warnings do you? They're all gone here but they indicate the first sign of
trouble.

> Attachments sent via email. This is interesting though;
>
> $ diff correct.xwininfo shifted.xwininfo
> 11c11
> < 0x2c03ca7 (has no name): () 1x1+-1+-1 +45+69
> ---
>> 0x2c03ca7 (has no name): () 1x1+-1+-1 +34+69
> 13c13
> < Absolute upper-left X: 46
> ---
>> Absolute upper-left X: 35
> 31,32c31,32
> < Corners: +46+70 -1232+70 -1232-720 +46-720
> < -geometry 80x24+35+41
> ---
>> Corners: +35+70 -1243+70 -1243-720 +35-720
>> -geometry 80x24+34+41
>
> It looks like geometry/serverGeometry might be out of sync.
> --
> https://code.launchpad.net/~smspillaz/compiz-core/compiz-core.work_923683/+merge/91654
> You are the owner of lp:~smspillaz/compiz-core/compiz-core.work_923683.
>

[Daniel van Vugt (vanvugt)]

It's random and very rare. But sometimes I see 1-pixel windows (with shadow). Can't ever seem to get xwininfo for them. Sometimes I also get very large white anonymous windows blocking my view. But it's all very hard to reproduce. And off-topic.

[Daniel van Vugt (vanvugt)]

Correct. I did stop getting "Warn: failed to receive ConfigureNotify event on ..." when using this branch.

[Sam Spilsbury (smspillaz)]

Well, you should stop getting "failed to receive" since I've removed the timeout which checks for unmatched events :) (A necessary hack coming up to the oneiric release).

I'm more interested in warnings that say "unmatched ConfigureNotify"

[Sam Spilsbury (smspillaz)]

Could you have a look again to see if the issue is still occurring for you ? I've just re-synced with trunk, so it may be fixed.

[Sam Spilsbury (smspillaz)]

OK, I found the issue. Its actually a bug that's been in the code for quite some time which would cause the client to not move within the frame when the frame was updated until the client position itself was updated.

[Sam Spilsbury (smspillaz)]

There's still one more issue here though to do with override redirect windows not getting their paint regions updated, so that needs to be looked into as well. And tests.

review: Needs Fixing

[Sam Spilsbury (smspillaz)]

^ Those fix the offset issue confirmed here (was finally able to reproduce it with qtcreator)

[Daniel van Vugt (vanvugt)]

1. Confirmed the shifted window regression is now fixed. Seems to work without any obvious bugs now.

2. I'm not entirely sure about replacing geometry with serverGeometry. I thought it would be a good idea to do the opposite. There would be a slight performance penalty, but using just "geometry" would guarantee that compiz always agrees with the actual server geometry, instead of guessing/assuming that serverGeometry is accepted by the server (which does not always seem to be true, hence bug 886192).

3. There are two instances of double semicolons ";;" in this proposal.

4. I suspect this proposal will conflict just slightly with the proposal for bug 940139. But it should be minor.

5. NEW REGRESSION:
375 - XSynchronize (dpy, synchronousX ? True : False);
376 +// priv->connection = XGetXCBConnection (priv->dpy);

6. Why always two spaces before "* 2" ?

review: Needs Fixing

[Sam Spilsbury (smspillaz)]

> 2. I'm not entirely sure about replacing geometry with serverGeometry. I
> thought it would be a good idea to do the opposite. There would be a slight
> performance penalty, but using just "geometry" would guarantee that compiz
> always agrees with the actual server geometry, instead of guessing/assuming
> that serverGeometry is accepted by the server (which does not always seem to
> be true, hence bug 886192).
>

serverGeometry will always be "accepted" by the server as long as the window is managed and the requested window geometry will not generate a BadValue error (eg, 0 < 1 < MAXINT) (eg, it is not override redirect and it is a child of a window for which we have a SubstructureRedirectMask.

Bug 886192 is not an example of this. In fact, the behaviour exhibited by bug 886192 is primarily /because/ we use the geometry last received from the server rather than geometry last sent, and the latency of which explains the reason why the window movement lags the cursor, because the server is "catching up".

The only case where you can't guaruntee that a similar update for geometry is going to be delivered by the server for serverGeometry as stored on XConfigureWindow is either in the case that A) Another client has SubstructureRedirectMask on the root window or a parent window owned by compiz and in that case compiz shouldn't even touch that window at all or B) override redirect windows, and as you can see in the code, we /always/ use geometry for override redirect windows in placement sensitive operations. Incidentally, override redirect windows are why getting window stacking right is such a nightmare, but thats a topic for another day.

> 3. There are two instances of double semicolons ";;" in this proposal.

Fix
>
> 4. I suspect this proposal will conflict just slightly with the proposal for
> bug 940139. But it should be minor.

Yes, fixable

>
> 5. NEW REGRESSION:
> 375 - XSynchronize (dpy, synchronousX ? True : False);
> 376 +// priv->connection = XGetXCBConnection (priv->dpy);

Please elaborate further on why this is a regression.

>
> 6. Why always two spaces before "* 2" ?

Most likely copy-and-paste errors

[Daniel van Vugt (vanvugt)]

#5 is a regression because it will make "--sync" be ignored. Line 375 is important and should not be deleted.

review: Needs Fixing

[Sam Spilsbury (smspillaz)]

On Mon, 27 Feb 2012, Daniel van Vugt wrote:

> Review: Needs Fixing
>
> #5 is a regression because it will make "--sync" be ignored. Line 375 is important and should not be deleted.

Thank you. Fixing.

> --
> https://code.launchpad.net/~smspillaz/compiz-core/compiz-core.work_923683/+merge/94683
> You are the owner of lp:~smspillaz/compiz-core/compiz-core.work_923683.
>

[Mikkel Kamstrup Erlandsen (kamstrup)]

> > #5 is a regression because it will make "--sync" be ignored. Line 375 is
> important and should not be deleted.
>
> Thank you. Fixing.

Be sure to add a comment there explaining why that call needs to be there - this review demonstrates that it should have been there in the first place :-)

[Daniel van Vugt (vanvugt)]

Comments are good. Though the string "synchronousX" is unique so its use should be quite clear already without a comment.

[lp:~smspillaz/compiz-core/compiz-core.work_923683]

2991. By Sam Spilsbury on 2012-02-28

Cleanup, fix removal of XSynchronize and detect error conditions

2992. By Sam Spilsbury on 2012-02-28

Fix silly typo

2993. By Sam Spilsbury on 2012-02-28

Merge lp:compiz-core

2994. By Sam Spilsbury on 2012-02-29

Use reference

2995. By Sam Spilsbury on 2012-04-03

Merge trunk

2996. By Sam Spilsbury on 2012-04-04

Removed a lot of width () / height () + border () * 2 sillyness, replace with
more sturdy abstraction

2997. By Sam Spilsbury on 2012-04-05

Fix LP #932520 - Update regions correctly when sending geometry updates

Use information last sent to server to determine window regions and shape
regions, update regions for resizing when we send the information to the server
as the shape rectangles will be correct anyways (even though it costs us a
round trip).

2998. By Sam Spilsbury on 2012-04-05

Replace instances of geometry with serverGeoemtry where appropriate

2999. By Sam Spilsbury on 2012-04-05

Merge lp:compiz-core

3000. By Sam Spilsbury on 2012-04-07

Fix typoo

3001. By Sam Spilsbury on 2012-04-11

Merge trunk

3002. By Sam Spilsbury on 2012-04-11

Remove abi breaks

3003. By Sam Spilsbury on 2012-04-11

Don't break abi

3004. By Sam Spilsbury on 2012-04-11

Use geometry last sent to server to calculate damage rects

3005. By Sam Spilsbury on 2012-04-11

Use server side rects for calculating clip regions

3006. By Sam Spilsbury on 2012-04-12

Use serverGeometry

3007. By Sam Spilsbury on 2012-04-12

Damage the screen when windows are resized

3008. By Sam Spilsbury on 2012-04-12

Style issue

3009. By Sam Spilsbury on 2012-04-14

Merged trunk and fixed a number of problems with resize synchronization

3010. By Sam Spilsbury on 2012-04-14

Send resize notification immediately for windows that aren't override redirect

3011. By Sam Spilsbury on 2012-04-14

Fix jumping around on resize because we were rebinding way too much at the wrong time.

Only rebind on paints.

3012. By Sam Spilsbury on 2012-04-14

Don't not update decorations when we're grabbed for resizing

3013. By Sam Spilsbury on 2012-04-14

Null check

3014. By Sam Spilsbury on 2012-04-15

resize: unconditionally finish the resize operation when releasing the button

3015. By Sam Spilsbury on 2012-04-16

Merge trunk

3016. By Sam Spilsbury on 2012-04-16

Don't send a moveNotify and resizeNotify if the window was moved and resized

3017. By Sam Spilsbury on 2012-04-16

Cleanup wobbly model update code

3018. By Sam Spilsbury on 2012-04-17

Ensure that override redirect windows get their regions set correctly.
Also they can't have input extents.

3019. By Sam Spilsbury on 2012-04-18

Force all override redirect windows to use geometry last received from
server. Force all managed windows to use geometry last sent.

The difference between geometry and server* is now moot and can be
removed in a future release

3020. By Sam Spilsbury on 2012-04-18

Clean some cruft

3021. By Sam Spilsbury on 2012-04-18

Update decoration matrix of shaded windows

3022. By Sam Spilsbury on 2012-04-18

Send a resizeNotify to indicate to plugins when map operations have completed

3023. By Sam Spilsbury on 2012-04-18

Merge lp:compiz-core

3024. By Sam Spilsbury on 2012-04-18

Don't notify plugins of unreparent in the right place

3025. By Sam Spilsbury on 2012-04-18

Merged lp:~vanvugt/compiz-core/compiz-core/fix-981703-properly

3026. By Sam Spilsbury on 2012-04-18

updateState is bitwise, so never clobber it

3027. By Sam Spilsbury on 2012-04-18

Base decision to send notifications to plugins on absolute position
changes

3028. By Sam Spilsbury on 2012-04-19

Don't set height = 0 if the window still has a pixmap

3029. By Sam Spilsbury on 2012-04-19

Remove some unnecessary cahgnes in the wobbly plugin

3030. By Sam Spilsbury on 2012-04-19

Merge lp:compiz-core

3031. By Sam Spilsbury on 2012-04-19

Now that geometry and serverGeometry both return the same thing, the changes
in client code don't make any sense to keep

3032. By Sam Spilsbury on 2012-04-20

Fix logic errors

3033. By Sam Spilsbury on 2012-04-20

!= 0 not necessary

3034. By Sam Spilsbury on 2012-04-23

Merge lp:compiz-core

Unmerged revisions

3034. By Sam Spilsbury on 2012-04-23

Merge lp:compiz-core

3033. By Sam Spilsbury on 2012-04-20

!= 0 not necessary

3032. By Sam Spilsbury on 2012-04-20

Fix logic errors

3031. By Sam Spilsbury on 2012-04-19

Now that geometry and serverGeometry both return the same thing, the changes
in client code don't make any sense to keep

3030. By Sam Spilsbury on 2012-04-19

Merge lp:compiz-core

3029. By Sam Spilsbury on 2012-04-19

Remove some unnecessary cahgnes in the wobbly plugin

3028. By Sam Spilsbury on 2012-04-19

Don't set height = 0 if the window still has a pixmap

3027. By Sam Spilsbury on 2012-04-18

Base decision to send notifications to plugins on absolute position
changes

3026. By Sam Spilsbury on 2012-04-18

updateState is bitwise, so never clobber it

3025. By Sam Spilsbury on 2012-04-18

Merged lp:~vanvugt/compiz-core/compiz-core/fix-981703-properly

=== modified file 'include/core/window.h'
--- include/core/window.h	2012-02-16 09:55:06 +0000
+++ include/core/window.h	2012-02-28 07:29:19 +0000
@@ -406,9 +406,9 @@
 
 	bool hasUnmapReference ();
 
-	bool resize (XWindowAttributes);
+	bool resize (const XWindowAttributes &);
 
-	bool resize (Geometry);
+	bool resize (const Geometry &);
 
 	bool resize (int x, int y, int width, int height,
 		     int border = 0);

=== modified file 'plugins/composite/src/window.cpp'
--- plugins/composite/src/window.cpp	2012-02-01 17:49:07 +0000
+++ plugins/composite/src/window.cpp	2012-02-28 07:29:19 +0000
@@ -250,7 +250,7 @@
 
     if (x2 > x1 && y2 > y1)
     {
-	CompWindow::Geometry geom = priv->window->geometry ();
+	CompWindow::Geometry geom = priv->window->serverGeometry ();
 
 	x1 += geom.x () + geom.border ();
 	y1 += geom.y () + geom.border ();
@@ -272,20 +272,20 @@
     {
 	int x1, x2, y1, y2;
 
-	CompWindow::Geometry geom = priv->window->geometry ();
-	CompWindowExtents output  = priv->window->output ();
+	const CompWindow::Geometry &geom = priv->window->serverGeometry ();
+	const CompWindowExtents &output  = priv->window->output ();
 
 	/* top */
 	x1 = -output.left - geom.border ();
 	y1 = -output.top - geom.border ();
-	x2 = priv->window->size ().width () + output.right - geom.border ();
+	x2 = priv->window->serverGeometry ().width () + geom.border () + output.right;
 	y2 = -geom.border ();
 
 	if (x1 < x2 && y1 < y2)
 	    addDamageRect (CompRect (x1, y1, x2 - x1, y2 - y1));
 
 	/* bottom */
-	y1 = priv->window->size ().height () - geom.border ();
+	y1 = priv->window->serverGeometry ().height () + geom.border ();
 	y2 = y1 + output.bottom - geom.border ();
 
 	if (x1 < x2 && y1 < y2)
@@ -295,13 +295,13 @@
 	x1 = -output.left - geom.border ();
 	y1 = -geom.border ();
 	x2 = -geom.border ();
-	y2 = priv->window->size ().height () - geom.border ();
+	y2 = priv->window->serverGeometry ().height () - geom.border ();
 
 	if (x1 < x2 && y1 < y2)
 	    addDamageRect (CompRect (x1, y1, x2 - x1, y2 - y1));
 
 	/* right */
-	x1 = priv->window->size ().width () - geom.border ();
+	x1 = priv->window->serverGeometry ().width () - geom.border ();
 	x2 = x1 + output.right - geom.border ();
 
 	if (x1 < x2 && y1 < y2)
@@ -322,7 +322,7 @@
 	x = rect.x ();
 	y = rect.y ();
 
-	CompWindow::Geometry geom = priv->window->geometry ();
+	const CompWindow::Geometry &geom = priv->window->serverGeometry ();
 	x += geom.x () + geom.border ();
 	y += geom.y () + geom.border ();
 
@@ -341,16 +341,16 @@
     if (priv->window->shaded () || force ||
 	(priv->window->isViewable ()))
     {
-	int    border = priv->window->geometry ().border ();
+	int    border = priv->window->serverGeometry ().border ();
 
 	int x1 = -MAX (priv->window->output ().left,
 		       priv->window->input ().left) - border;
 	int y1 = -MAX (priv->window->output ().top,
 		       priv->window->input ().top) - border;
-	int x2 = priv->window->size ().width () +
+	int x2 = priv->window->serverGeometry ().width () +
 		 MAX (priv->window->output ().right,
 		      priv->window->input ().right) ;
-	int y2 = priv->window->size ().height () +
+	int y2 = priv->window->serverGeometry ().height () +
 		 MAX (priv->window->output ().bottom,
 		      priv->window->input ().bottom) ;
 	CompRect r (x1, y1, x2 - x1, y2 - y1);
@@ -410,7 +410,7 @@
 
     if (!w->damageRect (initial, CompRect (x, y, width, height)))
     {
-	CompWindow::Geometry geom = w->priv->window->geometry ();
+	CompWindow::Geometry geom = w->priv->window->serverGeometry ();
 
 	x += geom.x () + geom.border ();
 	y += geom.y () + geom.border ();
@@ -622,14 +622,14 @@
     {
 	int x, y, x1, x2, y1, y2;
 
-	x = window->geometry ().x ();
-	y = window->geometry ().y ();
+	x = window->serverGeometry ().x ();
+	y = window->serverGeometry ().y ();
 
 	x1 = x - window->output ().left - dx;
 	y1 = y - window->output ().top - dy;
-	x2 = x + window->size ().width () +
+	x2 = x + window->serverGeometry ().width () +
 	     window->output ().right - dx;
-	y2 = y + window->size ().height () +
+	y2 = y + window->serverGeometry ().height () +
 	     window->output ().bottom - dy;
 
 	cScreen->damageRegion (CompRegion (CompRect (x1, y1, x2 - x1, y2 - y1)));

=== modified file 'plugins/decor/src/decor.cpp'
--- plugins/decor/src/decor.cpp	2012-02-27 09:58:19 +0000
+++ plugins/decor/src/decor.cpp	2012-02-28 07:29:19 +0000
@@ -91,7 +91,7 @@
 void
 DecorWindow::computeShadowRegion ()
 {
-    shadowRegion = CompRegion (window->outputRect ());
+    shadowRegion = CompRegion (window->serverOutputRect ());
 
     if (window->type () == CompWindowTypeDropdownMenuMask ||
         window->type () == CompWindowTypePopupMenuMask)
@@ -141,11 +141,11 @@
         if (window->type () == CompWindowTypeDropdownMenuMask &&
 	    shadowRegion == CompRegionRef (window->outputRect ().region ()))
         {
-            CompRect area (window->outputRect ().x1 (),
-                           window->outputRect ().y1 (),
-                           window->outputRect ().width (),
-			   window->inputRect ().y1 () -
-                           window->outputRect ().y1 ());
+	    CompRect area (window->serverOutputRect ().x1 (),
+			   window->serverOutputRect ().y1 (),
+			   window->serverOutputRect ().width (),
+			   window->serverInputRect ().y1 () -
+			   window->serverOutputRect ().y1 ());
 
 	    shadowRegion -= area;
         }
@@ -1072,8 +1072,8 @@
     for (i = 0; i < wd->nQuad; i++)
     {
 	int x, y;
-	unsigned int width = window->size ().width ();
-	unsigned int height = window->size ().height ();
+	unsigned int width = window->geometry ().width ();
+	unsigned int height = window->geometry ().height ();
 
 	if (window->shaded ())
 	    height = 0;
@@ -1082,8 +1082,8 @@
 			&x1, &y1, &x2, &y2, &sx, &sy);
 
 	/* Translate by x and y points of this window */
-	x = window->geometry ().x ();
-	y = window->geometry ().y ();
+	x = window->serverGeometry ().x ();
+	y = window->serverGeometry ().y ();
 
 	wd->quad[i].box.x1 = x1 + x;
 	wd->quad[i].box.y1 = y1 + y;
@@ -1111,8 +1111,8 @@
 bool
 DecorWindow::checkSize (const Decoration::Ptr &decoration)
 {
-    return (decoration->minWidth <= (int) window->size ().width () &&
-            decoration->minHeight <= (int) window->size ().height ());
+    return (decoration->minWidth <= (int) window->geometry ().width () &&
+	    decoration->minHeight <= (int) window->geometry ().height ());
 }
 
 /*
@@ -2124,8 +2124,8 @@
 	{
 	    int x, y;
 
-	    x = window->geometry (). x ();
-	    y = window->geometry (). y ();
+	    x = window->serverGeometry (). x ();
+	    y = window->serverGeometry (). y ();
 
 	    region += frameRegion.translated (x - wd->decor->input.left,
 					      y - wd->decor->input.top);
@@ -2146,7 +2146,7 @@
 void
 DecorWindow::updateWindowRegions ()
 {
-    const CompRect &input (window->inputRect ());
+    const CompRect &input (window->serverInputRect ());
 
     if (regions.size () != gWindow->textures ().size ())
 	regions.resize (gWindow->textures ().size ());

=== modified file 'plugins/move/src/move.cpp'
--- plugins/move/src/move.cpp	2012-02-16 05:31:28 +0000
+++ plugins/move/src/move.cpp	2012-02-28 07:29:19 +0000
@@ -138,8 +138,8 @@
 	    {
 		int xRoot, yRoot;
 
-		xRoot = w->geometry ().x () + (w->size ().width () / 2);
-		yRoot = w->geometry ().y () + (w->size ().height () / 2);
+		xRoot = w->serverGeometry ().x () + (w->size ().width () / 2);
+		yRoot = w->serverGeometry ().y () + (w->size ().height () / 2);
 
 		s->warpPointer (xRoot - pointerX, yRoot - pointerY);
 	    }
@@ -169,8 +169,8 @@
     if (ms->w)
     {
 	if (state & CompAction::StateCancel)
-	    ms->w->move (ms->savedX - ms->w->geometry ().x (),
-			 ms->savedY - ms->w->geometry ().y (), false);
+	    ms->w->move (ms->savedX - ms->w->serverGeometry ().x (),
+			 ms->savedY - ms->w->serverGeometry ().y (), false);
 
 	ms->w->syncPosition ();
 
@@ -314,12 +314,12 @@
 
 	w = ms->w;
 
-	wX      = w->geometry ().x ();
-	wY      = w->geometry ().y ();
-	wWidth  = w->geometry ().width () +
-		  w->geometry ().border () * 2;
-	wHeight = w->geometry ().height () +
-		  w->geometry ().border () * 2;
+	wX      = w->serverGeometry ().x ();
+	wY      = w->serverGeometry ().y ();
+	wWidth  = w->serverGeometry ().width () +
+		  w->serverGeometry ().border () * 2;
+	wHeight = w->serverGeometry ().height () +
+		  w->serverGeometry ().border () * 2;
 
 	ms->x += xRoot - lastPointerX;
 	ms->y += yRoot - lastPointerY;
@@ -484,8 +484,8 @@
 
 	if (dx || dy)
 	{
-	    w->move (wX + dx - w->geometry ().x (),
-		     wY + dy - w->geometry ().y (), false);
+	    w->move (wX + dx - w->serverGeometry ().x (),
+		     wY + dy - w->serverGeometry ().y (), false);
 
 	    if (!ms->optionGetLazyPositioning ())
 		w->syncPosition ();

=== modified file 'plugins/opengl/src/window.cpp'
--- plugins/opengl/src/window.cpp	2011-03-11 12:15:30 +0000
+++ plugins/opengl/src/window.cpp	2012-02-28 07:29:19 +0000
@@ -76,7 +76,7 @@
 void
 PrivateGLWindow::setWindowMatrix ()
 {
-    CompRect input (window->inputRect ());
+    CompRect input (window->serverInputRect ());
 
     if (textures.size () != matrices.size ())
 	matrices.resize (textures.size ());
@@ -344,7 +344,7 @@
 void
 PrivateGLWindow::updateWindowRegions ()
 {
-    CompRect input (window->inputRect ());
+    CompRect input (window->serverInputRect ());
 
     if (regions.size () != textures.size ())
 	regions.resize (textures.size ());

=== modified file 'src/event.cpp'
--- src/event.cpp	2012-02-22 05:13:00 +0000
+++ src/event.cpp	2012-02-28 07:29:19 +0000
@@ -1249,7 +1249,7 @@
 	    }
 
 	    /* been shaded */
-	    if (w->priv->height == 0)
+	    if (w->shaded ())
 	    {
 		if (w->id () == priv->activeWindow)
 		    w->moveInputFocusTo ();

=== modified file 'src/privatewindow.h'
--- src/privatewindow.h	2012-02-14 14:37:04 +0000
+++ src/privatewindow.h	2012-02-28 07:29:19 +0000
@@ -34,7 +34,6 @@
 #include <core/timer.h>
 #include "privatescreen.h"
 
-
 typedef CompWindowExtents CompFullscreenMonitorSet;
 
 class PrivateWindow {
@@ -167,6 +166,11 @@
 
 	bool handleSyncAlarm ();
 
+	void move (int dx, int dy, bool sync);
+	bool resize (int dx, int dy, int dwidth, int dheight, int dborder);
+	bool resize (const CompWindow::Geometry &g);
+	bool resize (const XWindowAttributes &attrib);
+
 	void configure (XConfigureEvent *ce);
 
 	void configureFrame (XConfigureEvent *ce);
@@ -207,8 +211,6 @@
 
 	void readIconHint ();
 
-	bool checkClear ();
-
     public:
 
 	PrivateWindow *priv;
@@ -240,13 +242,8 @@
 	XSizeHints	     sizeHints;
 	XWMHints             *hints;
 
-	struct timeval       lastGeometryUpdate;
-	struct timeval       lastConfigureRequest;
-
 	bool       inputHint;
 	bool       alpha;
-	int        width;
-	int        height;
 	CompRegion region;
 	CompRegion inputRegion;
 	CompRegion frameRegion;
@@ -289,8 +286,6 @@
 	typedef std::pair <XWindowChanges, unsigned int> XWCValueMask;
 
 	compiz::X11::PendingEventQueue pendingConfigures;
-	CompTimer                     mClearCheckTimeout;
-	bool pendingPositionUpdates;
 
 	char *startupId;
 	char *resName;
@@ -326,6 +321,8 @@
 
 	bool closeRequests;
 	Time lastCloseRequestTime;
+
+	bool nextMoveImmediate;
 };
 
 class CoreWindow

=== modified file 'src/screen.cpp'
--- src/screen.cpp	2012-02-24 12:18:12 +0000
+++ src/screen.cpp	2012-02-28 07:29:19 +0000
@@ -4536,6 +4536,8 @@
 	return false;
     }
 
+    /* Use synchronous behaviour when running with --sync, useful
+     * for getting stacktraces when X Errors occurr */
     XSynchronize (dpy, synchronousX ? True : False);
 
     snprintf (displayString, 255, "DISPLAY=%s",

=== modified file 'src/window.cpp'
--- src/window.cpp	2012-02-20 02:30:34 +0000
+++ src/window.cpp	2012-02-28 07:29:19 +0000
@@ -75,8 +75,8 @@
 PrivateWindow::isInvisible() const
 {
     return attrib.map_state != IsViewable ||
-     attrib.x + width  + output.right  <= 0 ||
-     attrib.y + height + output.bottom <= 0 ||
+     attrib.x + geometry.width ()  + output.right  <= 0 ||
+     attrib.y + geometry.height () + output.bottom <= 0 ||
      attrib.x - output.left >= (int) screen->width () ||
      attrib.y - output.top >= (int) screen->height ();
 }
@@ -808,292 +808,14 @@
     if (!serverFrame)
 	return;
 
-
-    gettimeofday (&lastConfigureRequest, NULL);
-    /* Flush any changes made to serverFrameGeometry or serverGeometry to the server
-     * since there is a race condition where geometries will go out-of-sync with
-     * window movement */
-
-    window->syncPosition ();
-
-    if (serverInput.left || serverInput.right || serverInput.top || serverInput.bottom)
-    {
-	int	   bw = serverGeometry.border () * 2;
-
-	xwc.x      = serverGeometry.x () - serverInput.left;
-	xwc.y      = serverGeometry.y () - serverInput.top;
-	xwc.width  = serverGeometry.width () + serverInput.left + serverInput.right + bw;
-	if (shaded)
-	    xwc.height = serverInput.top  + serverInput.bottom + bw;
-	else
-	    xwc.height = serverGeometry.height () + serverInput.top  + serverInput.bottom + bw;
-
-	if (shaded)
-	    height = serverInput.top + serverInput.bottom;
-
-	if (serverFrameGeometry.x () == xwc.x)
-	    valueMask &= ~(CWX);
-	else
-	    serverFrameGeometry.setX (xwc.x);
-
-	if (serverFrameGeometry.y ()  == xwc.y)
-	    valueMask &= ~(CWY);
-	else
-	    serverFrameGeometry.setY (xwc.y);
-
-	if (serverFrameGeometry.width () == xwc.width)
-	    valueMask &= ~(CWWidth);
-	else
-	    serverFrameGeometry.setWidth (xwc.width);
-
-	if (serverFrameGeometry.height () == xwc.height)
-	    valueMask &= ~(CWHeight);
-	else
-	    serverFrameGeometry.setHeight (xwc.height);
-
-	/* Geometry is the same, so we're not going to get a ConfigureNotify
-	 * event when the window is configured, which means that other plugins
-	 * won't know that the client, frame and wrapper windows got shifted
-	 * around (and might result in display corruption, eg in OpenGL */
-	if (valueMask == 0)
-	{
-	    XConfigureEvent xev;
-	    XWindowAttributes attrib;
-	    unsigned int      nchildren = 0;
-	    Window            rootRet = 0, parentRet = 0;
-	    Window            *children = NULL;
-
-	    xev.type   = ConfigureNotify;
-	    xev.event  = screen->root ();
-	    xev.window = priv->serverFrame;
-
-	    XGrabServer (screen->dpy ());
-
-	    if (XGetWindowAttributes (screen->dpy (), priv->serverFrame, &attrib))
-	    {
-		xev.x	     = attrib.x;
-		xev.y	     = attrib.y;
-		xev.width	     = attrib.width;
-		xev.height	     = attrib.height;
-		xev.border_width = attrib.border_width;
-		xev.above = None;
-
-		/* We need to ensure that the stacking order is
-		 * based on the current server stacking order so
-		 * find the sibling to this window's frame in the
-		 * server side stack and stack above that */
-		XQueryTree (screen->dpy (), screen->root (), &rootRet, &parentRet, &children, &nchildren);
-
-		if (nchildren)
-		{
-		    for (unsigned int i = 0; i < nchildren; i++)
-		    {
-			if (i + 1 == nchildren ||
-				children[i + 1] == ROOTPARENT (window))
-			{
-			    xev.above = children[i];
-			    break;
-			}
-		    }
-		}
-
-		if (children)
-		    XFree (children);
-
-		if (!xev.above)
-		    xev.above = (window->serverPrev) ? ROOTPARENT (window->serverPrev) : None;
-
-		xev.override_redirect = priv->attrib.override_redirect;
-
-	    }
-
-	    compiz::X11::PendingEvent::Ptr pc =
-		    boost::shared_static_cast<compiz::X11::PendingEvent> (compiz::X11::PendingConfigureEvent::Ptr (
-									      new compiz::X11::PendingConfigureEvent (
-										  screen->dpy (), serverFrame, valueMask, &xwc)));
-
-	    pendingConfigures.add (pc);
-	    if (priv->mClearCheckTimeout.active ())
-		priv->mClearCheckTimeout.stop ();
-	    priv->mClearCheckTimeout.start (boost::bind (&PrivateWindow::checkClear, priv),
-					    2000, 2500);
-
-	    XSendEvent (screen->dpy (), screen->root (), false,
-			SubstructureNotifyMask, (XEvent *) &xev);
-
-	    XUngrabServer (screen->dpy ());
-	    XSync (screen->dpy (), false);
-	}
-	else
-	{
-	    compiz::X11::PendingEvent::Ptr pc =
-		    boost::shared_static_cast<compiz::X11::PendingEvent> (compiz::X11::PendingConfigureEvent::Ptr (
-									      new compiz::X11::PendingConfigureEvent (
-										  screen->dpy (), serverFrame, valueMask, &xwc)));
-
-	    pendingConfigures.add (pc);
-	    if (priv->mClearCheckTimeout.active ())
-		priv->mClearCheckTimeout.stop ();
-	    priv->mClearCheckTimeout.start (boost::bind (&PrivateWindow::checkClear, priv),
-					    2000, 2500);
-	    XConfigureWindow (screen->dpy (), serverFrame, valueMask, &xwc);
-	}
-
-	if (shaded)
-	{
-	    XUnmapWindow (screen->dpy (), wrapper);
-	}
-	else
-	{
-	    XMapWindow (screen->dpy (), wrapper);
-	    XMoveResizeWindow (screen->dpy (), wrapper, serverInput.left, serverInput.top,
-			       serverGeometry.width (), serverGeometry.height ());
-	}
-	XMoveResizeWindow (screen->dpy (), id, 0, 0,
-			   serverGeometry.width (), serverGeometry.height ());
-	window->sendConfigureNotify ();
-	window->windowNotify (CompWindowNotifyFrameUpdate);
-    }
-    else
-    {
-	int	   bw = serverGeometry.border () * 2;
-
-	xwc.x      = serverGeometry.x ();
-	xwc.y      = serverGeometry.y ();
-	xwc.width  = serverGeometry.width () + bw;
-
-	/* FIXME: It doesn't make much sense to allow undecorated windows to be
-	 * shaded */
-	if (shaded)
-	    xwc.height = bw;
-	else
-	    xwc.height = serverGeometry.height () + bw;
-
-	if (serverFrameGeometry.x () == xwc.x)
-	    valueMask &= ~(CWX);
-	else
-	    serverFrameGeometry.setX (xwc.x);
-
-	if (serverFrameGeometry.y ()  == xwc.y)
-	    valueMask &= ~(CWY);
-	else
-	    serverFrameGeometry.setY (xwc.y);
-
-	if (serverFrameGeometry.width () == xwc.width)
-	    valueMask &= ~(CWWidth);
-	else
-	    serverFrameGeometry.setWidth (xwc.width);
-
-	if (serverFrameGeometry.height () == xwc.height)
-	    valueMask &= ~(CWHeight);
-	else
-	    serverFrameGeometry.setHeight (xwc.height);
-
-	/* Geometry is the same, so we're not going to get a ConfigureNotify
-	 * event when the window is configured, which means that other plugins
-	 * won't know that the client, frame and wrapper windows got shifted
-	 * around (and might result in display corruption, eg in OpenGL */
-	if (valueMask == 0)
-	{
-	    XConfigureEvent xev;
-	    XWindowAttributes attrib;
-	    unsigned int      nchildren = 0;
-	    Window            rootRet = 0, parentRet = 0;
-	    Window            *children = NULL;
-
-	    xev.type   = ConfigureNotify;
-	    xev.event  = screen->root ();
-	    xev.window = priv->serverFrame;
-
-	    XGrabServer (screen->dpy ());
-
-	    if (XGetWindowAttributes (screen->dpy (), priv->serverFrame, &attrib))
-	    {
-		xev.x	     = attrib.x;
-		xev.y	     = attrib.y;
-		xev.width	     = attrib.width;
-		xev.height	     = attrib.height;
-		xev.border_width = attrib.border_width;
-		xev.above = None;
-
-		/* We need to ensure that the stacking order is
-		 * based on the current server stacking order so
-		 * find the sibling to this window's frame in the
-		 * server side stack and stack above that */
-		XQueryTree (screen->dpy (), screen->root (), &rootRet, &parentRet, &children, &nchildren);
-
-		if (nchildren)
-		{
-		    for (unsigned int i = 0; i < nchildren; i++)
-		    {
-			if (i + 1 == nchildren ||
-				children[i + 1] == ROOTPARENT (window))
-			{
-			    xev.above = children[i];
-			    break;
-			}
-		    }
-		}
-
-		if (children)
-		    XFree (children);
-
-		if (!xev.above)
-		    xev.above = (window->serverPrev) ? ROOTPARENT (window->serverPrev) : None;
-
-		xev.override_redirect = priv->attrib.override_redirect;
-
-	    }
-
-	    compiz::X11::PendingEvent::Ptr pc =
-		    boost::shared_static_cast<compiz::X11::PendingEvent> (compiz::X11::PendingConfigureEvent::Ptr (
-									      new compiz::X11::PendingConfigureEvent (
-										  screen->dpy (), serverFrame, valueMask, &xwc)));
-
-	    pendingConfigures.add (pc);
-	    if (priv->mClearCheckTimeout.active ())
-		priv->mClearCheckTimeout.stop ();
-	    priv->mClearCheckTimeout.start (boost::bind (&PrivateWindow::checkClear, priv),
-					    2000, 2500);
-
-	    XSendEvent (screen->dpy (), screen->root (), false,
-			SubstructureNotifyMask, (XEvent *) &xev);
-
-	    XUngrabServer (screen->dpy ());
-	    XSync (screen->dpy (), false);
-	}
-	else
-	{
-	    compiz::X11::PendingEvent::Ptr pc =
-		    boost::shared_static_cast<compiz::X11::PendingEvent> (compiz::X11::PendingConfigureEvent::Ptr (
-									      new compiz::X11::PendingConfigureEvent (
-										  screen->dpy (), serverFrame, valueMask, &xwc)));
-
-	    pendingConfigures.add (pc);
-	    if (priv->mClearCheckTimeout.active ())
-		priv->mClearCheckTimeout.stop ();
-	    priv->mClearCheckTimeout.start (boost::bind (&PrivateWindow::checkClear, priv),
-					    2000, 2500);
-
-	    XConfigureWindow (screen->dpy (), serverFrame, valueMask, &xwc);
-	}
-
-	if (shaded)
-	{
-	    XUnmapWindow (screen->dpy (), wrapper);
-	}
-	else
-	{
-	    XMapWindow (screen->dpy (), wrapper);
-	    XMoveResizeWindow (screen->dpy (), wrapper, 0, 0,
-			       serverGeometry.width (), serverGeometry.height ());
-	}
-
-	XMoveResizeWindow (screen->dpy (), id, 0, 0,
-			   serverGeometry.width (), serverGeometry.height ());
-	window->sendConfigureNotify ();
-	window->windowNotify (CompWindowNotifyFrameUpdate);
-    }
+    xwc.x = serverGeometry.x ();
+    xwc.y = serverGeometry.y ();
+    xwc.width = serverGeometry.width ();
+    xwc.height = serverGeometry.height ();
+    xwc.border_width = serverGeometry.border ();
+
+    window->configureXWindow (valueMask, &xwc);
+    window->windowNotify (CompWindowNotifyFrameUpdate);
     window->recalcActions ();
 }
 
@@ -1136,8 +858,8 @@
 
     for (unsigned int i = 0; i < n; i++)
     {
-	x1 = rects[i].x + priv->geometry.border ();
-	y1 = rects[i].y + priv->geometry.border ();
+	x1 = rects[i].x + priv->serverGeometry.border ();
+	y1 = rects[i].y + priv->serverGeometry.border ();
 	x2 = x1 + rects[i].width;
 	y2 = y1 + rects[i].height;
 
@@ -1145,17 +867,17 @@
 	    x1 = 0;
 	if (y1 < 0)
 	    y1 = 0;
-	if (x2 > priv->width)
-	    x2 = priv->width;
-	if (y2 > priv->height)
-	    y2 = priv->height;
+	if (x2 > priv->serverGeometry.width ())
+	    x2 = priv->serverGeometry.height ();
+	if (y2 > priv->serverGeometry.width ())
+	    y2 = priv->serverGeometry.height ();
 
 	if (y1 < y2 && x1 < x2)
 	{
-	    x1 += priv->geometry.x ();
-	    y1 += priv->geometry.y ();
-	    x2 += priv->geometry.x ();
-	    y2 += priv->geometry.y ();
+	    x1 += priv->serverGeometry.x ();
+	    y1 += priv->serverGeometry.y ();
+	    x2 += priv->serverGeometry.x ();
+	    y2 += priv->serverGeometry.y ();
 
 	    ret += CompRect (x1, y1, x2 - x1, y2 - y1);
 	}
@@ -1183,17 +905,19 @@
     {
 	int order;
 
+	/* We should update the server here */
+	XSync (screen->dpy (), false);
+
 	boundingShapeRects = XShapeGetRectangles (screen->dpy (), priv->id,
 					 	  ShapeBounding, &nBounding, &order);
 	inputShapeRects = XShapeGetRectangles (screen->dpy (), priv->id,
 					       ShapeInput, &nInput, &order);
-
     }
 
-    r.x      = -priv->geometry.border ();
-    r.y      = -priv->geometry.border ();
-    r.width  = priv->width + priv->geometry.border ();
-    r.height = priv->height + priv->geometry.border ();
+    r.x      = -priv->serverGeometry.border ();
+    r.y      = -priv->serverGeometry.border ();
+    r.width  = priv->serverGeometry.width () + priv->serverGeometry.border ();
+    r.height = priv->serverGeometry.height () + priv->serverGeometry.border ();
 
     if (nBounding < 1)
     {
@@ -1726,7 +1450,7 @@
     priv->attrib.map_state = IsUnmapped;
     priv->invisible = true;
 
-    if (priv->shaded && priv->height)
+    if (priv->shaded)
     {
 	priv->updateFrameWindow ();
     }
@@ -1794,7 +1518,7 @@
 }
 
 bool
-CompWindow::resize (XWindowAttributes attr)
+CompWindow::resize (const XWindowAttributes &attr)
 {
     return resize (Geometry (attr.x, attr.y, attr.width, attr.height,
 			     attr.border_width));
@@ -1811,7 +1535,7 @@
 }
 
 bool
-CompWindow::resize (CompWindow::Geometry gm)
+PrivateWindow::resize (const CompWindow::Geometry &gm)
 {
     /* Input extents are now the last thing sent
      * from the server. This might not work in some
@@ -1828,12 +1552,8 @@
 	priv->geometry.height ()  != gm.height () ||
 	priv->geometry.border ()  != gm.border ())
     {
-	int pw, ph;
 	int dx, dy, dwidth, dheight;
 
-	pw = gm.width () + gm.border () * 2;
-	ph = gm.height () + gm.border () * 2;
-
 	dx      = gm.x () - priv->geometry.x ();
 	dy      = gm.y () - priv->geometry.y ();
 	dwidth  = gm.width () - priv->geometry.width ();
@@ -1843,37 +1563,60 @@
 			    gm.width (), gm.height (),
 			    gm.border ());
 
-	priv->width = pw;
-	priv->height = ph;
+	if (priv->attrib.override_redirect)
+	{
+	    priv->serverGeometry = priv->geometry;
+	    priv->serverFrameGeometry = priv->frameGeometry;
+	}
 
 	if (priv->mapNum)
 	    priv->updateRegion ();
 
-	resizeNotify (dx, dy, dwidth, dheight);
+	window->resizeNotify (dx, dy, dwidth, dheight);
 
 	priv->invisible = priv->isInvisible ();
     }
     else if (priv->geometry.x () != gm.x () || priv->geometry.y () != gm.y ())
     {
-	int dx, dy;
-
-	dx = gm.x () - priv->geometry.x ();
-	dy = gm.y () - priv->geometry.y ();
-
-	priv->geometry.setX (gm.x ());
-	priv->geometry.setY (gm.y ());
-
-	priv->region.translate (dx, dy);
-	priv->inputRegion.translate (dx, dy);
-	if (!priv->frameRegion.isEmpty ())
-	    priv->frameRegion.translate (dx, dy);
-
-	priv->invisible = priv->isInvisible ();
-
-	moveNotify (dx, dy, true);
+	move (gm.x () - priv->geometry.x (),
+	      gm.y () - priv->geometry.y (), true);
     }
 
-    updateFrameRegion ();
+    window->updateFrameRegion ();
+
+    return true;
+}
+
+bool
+PrivateWindow::resize (const XWindowAttributes &attr)
+{
+    return resize (CompWindow::Geometry (attr.x, attr.y, attr.width, attr.height,
+					 attr.border_width));
+}
+
+bool
+PrivateWindow::resize (int          x,
+		       int          y,
+		       int          width,
+		       int          height,
+		       int          border)
+{
+    return resize (CompWindow::Geometry (x, y, width, height, border));
+}
+
+bool
+CompWindow::resize (const CompWindow::Geometry &gm)
+{
+    XWindowChanges xwc = XWINDOWCHANGES_INIT;
+    unsigned int   valueMask = CWX | CWY | CWWidth | CWHeight | CWBorderWidth;
+
+    xwc.x = gm.x ();
+    xwc.y = gm.y ();
+    xwc.width = gm.width ();
+    xwc.height = gm.height ();
+    xwc.border_width = gm.border ();
+
+    configureXWindow (valueMask, &xwc);
 
     return true;
 }
@@ -2041,13 +1784,7 @@
 				ce->border_width);
     else
     {
-	if (ce->override_redirect)
-	{
-	    priv->serverGeometry.set (ce->x, ce->y, ce->width, ce->height,
-				      ce->border_width);
-	}
-
-	window->resize (ce->x, ce->y, ce->width, ce->height, ce->border_width);
+	resize (ce->x, ce->y, ce->width, ce->height, ce->border_width);
     }
 
     if (ce->event == screen->root ())
@@ -2128,7 +1865,7 @@
     if (priv->syncWait)
 	priv->syncGeometry.set (x, y, width, height, ce->border_width);
     else
-	window->resize (x, y, width, height, ce->border_width);
+	resize (x, y, width, height, ce->border_width);
 
     if (priv->restack (ce->above))
 	priv->updatePassiveButtonGrabs ();
@@ -2137,27 +1874,6 @@
 
     if (above)
 	above->priv->updatePassiveButtonGrabs ();
-
-    if (!pendingConfigures.pending ())
-    {
-	/* Tell plugins its ok to start doing stupid things again but
-	 * obviously FIXME */
-	CompOption::Vector options;
-	CompOption::Value  v;
-
-	options.push_back (CompOption ("window", CompOption::TypeInt));
-	v.set ((int) id);
-	options.back ().set (v);
-	options.push_back (CompOption ("active", CompOption::TypeInt));
-	v.set ((int) 0);
-	options.back ().set (v);
-
-	/* Notify other plugins that it is unsafe to change geometry or serverGeometry
-	 * FIXME: That API should not be accessible to plugins, this is a hack to avoid
-	 * breaking ABI */
-
-	screen->handleCompizEvent ("core", "lock_position", options);
-    }
 }
 
 void
@@ -2180,23 +1896,34 @@
 {
     if (dx || dy)
     {
-	gettimeofday (&priv->lastGeometryUpdate, NULL);
-
-	/* Don't allow window movement to overwrite working geometries
-	 * last received from the server if we know there are pending
-	 * ConfigureNotify events on this window. That's a clunky workaround
-	 * and a FIXME in any case, however, until we can break the API
-	 * and remove CompWindow::move, this will need to be the case */
-
-	if (!priv->pendingConfigures.pending ())
+	XWindowChanges xwc = XWINDOWCHANGES_INIT;
+	unsigned int   valueMask = CWX | CWY;
+
+	xwc.x = priv->serverGeometry.x () + dx;
+	xwc.y = priv->serverGeometry.y () + dy;
+
+	priv->nextMoveImmediate = immediate;
+
+	configureXWindow (valueMask, &xwc);
+    }
+}
+
+void
+PrivateWindow::move (int dx,
+		     int dy,
+		     bool immediate)
+{
+    if (dx || dy)
+    {
+	priv->geometry.setX (priv->geometry.x () + dx);
+	priv->geometry.setY (priv->geometry.y () + dy);
+	priv->frameGeometry.setX (priv->frameGeometry.x () + dx);
+	priv->frameGeometry.setY (priv->frameGeometry.y () + dy);
+
+	if (priv->attrib.override_redirect)
 	{
-	    priv->geometry.setX (priv->geometry.x () + dx);
-	    priv->geometry.setY (priv->geometry.y () + dy);
-	    priv->frameGeometry.setX (priv->frameGeometry.x () + dx);
-	    priv->frameGeometry.setY (priv->frameGeometry.y () + dy);
-
-	    priv->pendingPositionUpdates = true;
-
+	    priv->serverGeometry = priv->geometry;
+	    priv->serverFrameGeometry = priv->frameGeometry;
 	    priv->region.translate (dx, dy);
 	    priv->inputRegion.translate (dx, dy);
 	    if (!priv->frameRegion.isEmpty ())
@@ -2204,19 +1931,7 @@
 
 	    priv->invisible = priv->isInvisible ();
 
-	    moveNotify (dx, dy, immediate);
-	}
-	else
-	{
-	    XWindowChanges xwc = XWINDOWCHANGES_INIT;
-	    unsigned int   valueMask = CWX | CWY;
-	    compLogMessage ("core", CompLogLevelDebug, "pending configure notifies on 0x%x, "\
-			    "moving window asyncrhonously!", (unsigned int) priv->serverId);
-
-	    xwc.x = priv->serverGeometry.x () + dx;
-	    xwc.y = priv->serverGeometry.y () + dy;
-
-	    configureXWindow (valueMask, &xwc);
+	    window->moveNotify (dx, dy, true);
 	}
     }
 }
@@ -2227,22 +1942,6 @@
     return !mEvents.empty ();
 }
 
-bool
-PrivateWindow::checkClear ()
-{
-    if (pendingConfigures.pending ())
-    {
-	/* FIXME: This is a hack to avoid performance regressions
-	 * and must be removed in 0.9.6 */
-	compLogMessage ("core", CompLogLevelWarn, "failed to receive ConfigureNotify event on 0x%x\n",
-			id);
-	pendingConfigures.dump ();
-	pendingConfigures.clear ();
-    }
-
-    return false;
-}
-
 void
 compiz::X11::PendingEventQueue::add (PendingEvent::Ptr p)
 {
@@ -2464,21 +2163,6 @@
     mValueMask (valueMask),
     mXwc (*xwc)
 {
-    CompOption::Vector options;
-    CompOption::Value  v;
-
-    options.push_back (CompOption ("window", CompOption::TypeInt));
-    v.set ((int) w);
-    options.back ().set (v);
-    options.push_back (CompOption ("active", CompOption::TypeInt));
-    v.set ((int) 1);
-    options.back ().set (v);
-
-    /* Notify other plugins that it is unsafe to change geometry or serverGeometry
-     * FIXME: That API should not be accessible to plugins, this is a hack to avoid
-     * breaking ABI */
-
-    screen->handleCompizEvent ("core", "lock_position", options);
 }
 
 compiz::X11::PendingConfigureEvent::~PendingConfigureEvent ()
@@ -2488,57 +2172,6 @@
 void
 CompWindow::syncPosition ()
 {
-    gettimeofday (&priv->lastConfigureRequest, NULL);
-
-    unsigned int   valueMask = CWX | CWY;
-    XWindowChanges xwc = XWINDOWCHANGES_INIT;
-
-    if (priv->pendingPositionUpdates && !priv->pendingConfigures.pending ())
-    {
-	if (priv->serverFrameGeometry.x () == priv->frameGeometry.x ())
-	    valueMask &= ~(CWX);
-	if (priv->serverFrameGeometry.y () == priv->frameGeometry.y ())
-	    valueMask &= ~(CWY);
-
-	/* Because CompWindow::move can update the geometry last
-	 * received from the server, we must indicate that no values
-	 * changed, because when the ConfigureNotify comes around
-	 * the values are going to be the same. That's obviously
-	 * broken behaviour and worthy of a FIXME, but requires
-	 * larger changes to the window movement system. */
-	if (valueMask)
-	{
-	    priv->serverGeometry.setX (priv->geometry.x ());
-	    priv->serverGeometry.setY (priv->geometry.y ());
-	    priv->serverFrameGeometry.setX (priv->frameGeometry.x ());
-	    priv->serverFrameGeometry.setY (priv->frameGeometry.y ());
-
-	    xwc.x = priv->serverFrameGeometry.x ();
-	    xwc.y = priv->serverFrameGeometry.y ();
-
-	    compiz::X11::PendingEvent::Ptr pc =
-		    boost::shared_static_cast<compiz::X11::PendingEvent> (compiz::X11::PendingConfigureEvent::Ptr (
-									      new compiz::X11::PendingConfigureEvent (
-										  screen->dpy (), priv->serverFrame, 0, &xwc)));
-
-	    priv->pendingConfigures.add (pc);
-
-	    /* Got 3 seconds to get its stuff together */
-	    if (priv->mClearCheckTimeout.active ())
-		priv->mClearCheckTimeout.stop ();
-	    priv->mClearCheckTimeout.start (boost::bind (&PrivateWindow::checkClear, priv),
-					    2000, 2500);
-	    XConfigureWindow (screen->dpy (), ROOTPARENT (this), valueMask, &xwc);
-
-	    if (priv->serverFrame)
-	    {
-		XMoveWindow (screen->dpy (), priv->wrapper,
-			     priv->serverInput.left, priv->serverInput.top);
-		sendConfigureNotify ();
-	    }
-	}
-	priv->pendingPositionUpdates = false;
-    }
 }
 
 bool
@@ -3360,14 +2993,23 @@
 {
     unsigned int frameValueMask = 0;
 
-    /* Immediately sync window position
-     * if plugins were updating w->geometry () directly
-     * in order to avoid a race condition */
-
-    window->syncPosition ();
+    if (id == screen->root ())
+    {
+	compLogMessage ("core", CompLogLevelWarn, "attempted to reconfigure root window");
+	return;
+    }
 
     /* Remove redundant bits */
 
+    xwc->x = valueMask & CWX ? xwc->x : serverGeometry.x ();
+    xwc->y = valueMask & CWY ? xwc->y : serverGeometry.y ();
+    xwc->width = valueMask & CWWidth ? xwc->width : serverGeometry.width ();
+    xwc->height = valueMask & CWHeight ? xwc->height : serverGeometry.height ();
+    xwc->border_width = valueMask & CWBorderWidth ? xwc->border_width : serverGeometry.border ();
+
+    /* FIXME: This is a total fallacy for the reparenting case
+     * at least since the client doesn't actually move here, it only
+     * moves within the frame */
     if (valueMask & CWX && serverGeometry.x () == xwc->x)
 	valueMask &= ~(CWX);
 
@@ -3434,18 +3076,15 @@
 	    compLogMessage ("core", CompLogLevelWarn, "restack_mode not Above");
     }
 
-    frameValueMask = valueMask;
+    frameValueMask = CWX | CWY | CWWidth | CWHeight | (valueMask & (CWStackMode | CWSibling));
 
-    if (frameValueMask & CWX &&
-	serverFrameGeometry.x () == xwc->x - serverGeometry.border () - serverInput.left)
+    if (serverFrameGeometry.x () == xwc->x - serverGeometry.border () - serverInput.left)
 	frameValueMask &= ~(CWX);
 
-    if (frameValueMask & CWY &&
-	serverFrameGeometry.y () == xwc->y - serverGeometry.border () - serverInput.top)
+    if (serverFrameGeometry.y () == xwc->y - serverGeometry.border () - serverInput.top)
 	frameValueMask &= ~(CWY);
 
-   if (frameValueMask & CWWidth &&
-	serverFrameGeometry.width () == xwc->width + serverGeometry.border () * 2
+   if (serverFrameGeometry.width () == xwc->width + serverGeometry.border () * 2
 				      + serverInput.left + serverInput.right)
 	frameValueMask &= ~(CWWidth);
 
@@ -3455,19 +3094,76 @@
 
     if (shaded)
     {
-	if (frameValueMask & CWHeight &&
-	    serverFrameGeometry.height () == serverGeometry.border () * 2
+	if (serverFrameGeometry.height () == serverGeometry.border () * 2
 	    + serverInput.top + serverInput.bottom)
 	    frameValueMask &= ~(CWHeight);
     }
     else
     {
-	if (frameValueMask & CWHeight &&
-	    serverFrameGeometry.height () == xwc->height + serverGeometry.border () * 2
+	if (serverFrameGeometry.height () == xwc->height + serverGeometry.border () * 2
 	    + serverInput.top + serverInput.bottom)
 	    frameValueMask &= ~(CWHeight);
     }
 
+    /* Don't allow anything that might generate a BadValue */
+    if (valueMask & CWWidth && !xwc->width)
+    {
+	compLogMessage ("core", CompLogLevelWarn, "Attempted to set < 1 width on a window");
+	xwc->width = 1;
+    }
+
+    if (valueMask & CWHeight && !xwc->height)
+    {
+	compLogMessage ("core", CompLogLevelWarn, "Attempted to set < 1 height on a window");
+	xwc->height = 1;
+    }
+
+    if (valueMask & CWStackMode &&
+        ((xwc->stack_mode != TopIf) && (xwc->stack_mode != BottomIf) && (xwc->stack_mode != Opposite) &&
+	 (xwc->stack_mode != Above) && (xwc->stack_mode != Below)))
+    {
+	compLogMessage ("core", CompLogLevelWarn, "Invalid stack mode %i", xwc->stack_mode);
+	valueMask &= ~(CWStackMode | CWSibling);
+    }
+
+    /* Don't allow anything that might cause a BadMatch error */
+
+    if (valueMask & CWSibling && !(valueMask & CWStackMode))
+    {
+	compLogMessage ("core", CompLogLevelWarn, "Didn't specify a CWStackMode for CWSibling");
+	valueMask &= ~CWSibling;
+    }
+
+    if (valueMask & CWSibling && xwc->sibling == (serverFrame ? serverFrame : id))
+    {
+	compLogMessage ("core", CompLogLevelWarn, "Can't restack a window relative to itself");
+	valueMask &= ~CWSibling;
+    }
+
+    if (valueMask & CWBorderWidth && attrib.c_class == InputOnly)
+    {
+	compLogMessage ("core", CompLogLevelWarn, "Cannot set border_width of an input_only window");
+	valueMask &= ~CWBorderWidth;
+    }
+
+    if (valueMask & CWSibling)
+    {
+	CompWindow *sibling = screen->findTopLevelWindow (xwc->sibling);
+
+	if (!sibling)
+	{
+	    compLogMessage ("core", CompLogLevelWarn, "Attempted to restack relative to 0x%x which is "\
+			    "not a child of the root window or a window compiz owns", static_cast <unsigned int> (xwc->sibling));
+	    valueMask &= ~(CWSibling | CWStackMode);
+	}
+	else if (sibling->frame () && xwc->sibling != sibling->frame ())
+	{
+	    compLogMessage ("core", CompLogLevelWarn, "Attempted to restack relative to 0x%x which is "\
+			    "not a child of the root window", static_cast <unsigned int> (xwc->sibling));
+	    valueMask &= ~(CWSibling | CWStackMode);
+	}
+    }
+
     /* Can't set the border width of frame windows */
     frameValueMask &= ~(CWBorderWidth);
 
@@ -3494,11 +3190,8 @@
 					   + serverInput.top + serverInput.bottom);
     }
 
-
     if (serverFrame)
     {
-	gettimeofday (&lastConfigureRequest, NULL);
-
 	if (frameValueMask)
 	{
 	    XWindowChanges wc = *xwc;
@@ -3514,15 +3207,20 @@
 										  screen->dpy (), priv->serverFrame, frameValueMask, &wc)));
 
 	    pendingConfigures.add (pc);
-	    if (priv->mClearCheckTimeout.active ())
-		priv->mClearCheckTimeout.stop ();
-	    priv->mClearCheckTimeout.start (boost::bind (&PrivateWindow::checkClear, priv),
-					    2000, 2500);
 
 	    XConfigureWindow (screen->dpy (), serverFrame, frameValueMask, &wc);
 	}
+
 	valueMask &= ~(CWSibling | CWStackMode);
 
+	/* If the frame has changed position (eg, serverInput.top
+	 * or serverInput.left have changed) then we also need to
+	 * update the client and wrapper position */
+	if (!(valueMask & CWX))
+	    valueMask |= frameValueMask & CWX;
+	if (!(valueMask & CWY))
+	    valueMask |= frameValueMask & CWY;
+
 	if (valueMask)
 	{
 	    xwc->x = serverInput.left;
@@ -3710,6 +3408,9 @@
 CompWindow::configureXWindow (unsigned int valueMask,
 			      XWindowChanges *xwc)
 {
+    int dx = valueMask & CWX ? xwc->x - priv->serverGeometry.x () : 0;
+    int dy = valueMask & CWY ? xwc->y - priv->serverGeometry.y () : 0;
+
     if (priv->managed && (valueMask & (CWSibling | CWStackMode)))
     {
 	CompWindowList transients;
@@ -3764,6 +3465,16 @@
     {
 	priv->reconfigureXWindow (valueMask, xwc);
     }
+
+    if (!overrideRedirect () && (dx || dy))
+    {
+	priv->region.translate (dx, dy);
+	priv->inputRegion.translate (dx, dy);
+	if (!priv->frameRegion.isEmpty ())
+	    priv->frameRegion.translate (dx, dy);
+	moveNotify (dx, dy, priv->nextMoveImmediate);
+	priv->nextMoveImmediate = true;
+    }
 }
 
 int
@@ -4315,10 +4026,6 @@
 											  screen->dpy (), serverFrame, valueMask, &lxwc)));
 
 		    pendingConfigures.add (pc);
-		    if (priv->mClearCheckTimeout.active ())
-			priv->mClearCheckTimeout.stop ();
-		    priv->mClearCheckTimeout.start (boost::bind (&PrivateWindow::checkClear, priv),
-						    2000, 2500);
 		}
 
 		/* Below with no sibling puts the window at the bottom
@@ -5489,7 +5196,7 @@
 	m = priv->geometry.x () + offX;
 	if (m - priv->input.left < (int) s->width () - vWidth)
 	    rv.setX (offX + vWidth);
-	else if (m + priv->width + priv->input.right > vWidth)
+	else if (m + priv->geometry.width () + priv->input.right > vWidth)
 	    rv.setX (offX - vWidth);
 	else
 	    rv.setX (offX);
@@ -5504,7 +5211,7 @@
 	m = priv->geometry.y () + offY;
 	if (m - priv->input.top < (int) s->height () - vHeight)
 	    rv.setY (offY + vHeight);
-	else if (m + priv->height + priv->input.bottom > vHeight)
+	else if (m + priv->geometry.height () + priv->input.bottom > vHeight)
 	    rv.setY (offY - vHeight);
 	else
 	    rv.setY (offY);
@@ -6080,7 +5787,7 @@
 
 	    if (m - priv->output.left < (int) screen->width () - vWidth)
 		wx = tx + vWidth;
-	    else if (m + priv->width + priv->output.right > vWidth)
+	    else if (m + priv->geometry.width () + priv->output.right > vWidth)
 		wx = tx - vWidth;
 	}
 
@@ -6090,7 +5797,7 @@
 
 	    if (m - priv->output.top < (int) screen->height () - vHeight)
 		wy = ty + vHeight;
-	    else if (m + priv->height + priv->output.bottom > vHeight)
+	    else if (m + priv->geometry.height () + priv->output.bottom > vHeight)
 		wy = ty - vHeight;
 	}
 
@@ -6316,9 +6023,6 @@
     priv->serverFrameGeometry = priv->frameGeometry = priv->syncGeometry
 	    = priv->geometry = priv->serverGeometry;
 
-    priv->width  = priv->attrib.width  + priv->attrib.border_width * 2;
-    priv->height = priv->attrib.height + priv->attrib.border_width * 2;
-
     priv->sizeHints.flags = 0;
 
     priv->recalcNormalHints ();
@@ -6340,8 +6044,7 @@
 
     if (priv->attrib.c_class != InputOnly)
     {
-	priv->region = CompRegion (priv->attrib.x, priv->attrib.y,
-				   priv->width, priv->height);
+	priv->region = CompRegion (priv->serverGeometry);
 	priv->inputRegion = priv->region;
 
 	/* need to check for DisplayModal state on all windows */
@@ -6586,8 +6289,6 @@
     hints (NULL),
     inputHint (true),
     alpha (false),
-    width (0),
-    height (0),
     region (),
     wmType (0),
     type (CompWindowTypeUnknownMask),
@@ -6622,7 +6323,6 @@
     pendingUnmaps (0),
     pendingMaps (0),
     pendingConfigures (screen->dpy ()),
-    pendingPositionUpdates (false),
 
     startupId (0),
     resName (0),
@@ -6824,8 +6524,8 @@
 	    priv->frameRegion &= CompRegion (r);
 	}
 
-	x = priv->geometry.x () - priv->input.left;
-	y = priv->geometry.y () - priv->input.top;
+	x = priv->serverGeometry.x () - priv->input.left;
+	y = priv->serverGeometry.y () - priv->input.top;
 
 	XShapeCombineRegion (screen->dpy (), priv->serverFrame,
 			     ShapeBounding, -x, -y,
@@ -6866,6 +6566,11 @@
 
 	priv->updateSize ();
 	priv->updateFrameWindow ();
+
+	/* Always send a moveNotify
+	 * whenever the frame extents update
+	 * so that plugins can re-position appropriately */
+	moveNotify (0, 0, true);
     }
 
     /* Use b for _NET_WM_FRAME_EXTENTS here because

=== modified file 'src/windowgeometry.cpp'
--- src/windowgeometry.cpp	2012-01-23 05:44:19 +0000
+++ src/windowgeometry.cpp	2012-02-28 07:29:19 +0000
@@ -61,22 +61,22 @@
 int
 CompWindow::width () const
 {
-    return priv->width +
+    return priv->geometry.width () +
 	    priv->geometry.border ()  * 2;
 }
 
 int
 CompWindow::height () const
 {
-    return priv->height +
+    return priv->geometry.height () +
 	    priv->geometry.border ()  * 2;;
 }
 
 CompSize
 CompWindow::size () const
 {
-    return CompSize (priv->width + priv->geometry.border ()  * 2,
-		     priv->height + priv->geometry.border ()  * 2);
+    return CompSize (priv->geometry.width () + priv->geometry.border ()  * 2,
+		     priv->geometry.height () + priv->geometry.border ()  * 2);
 }
 
 int