Code review comment for lp:~smspillaz/compiz-core/compiz-core.work_923683

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> The default should be to return the size /without/ borders,
> and have a default-parameter enum to get the size with borders.

There are very few designs where default parameters are better than multiple functions. This isn't one.

auto sizeWithoutBorders = geometry.size();
auto sizeWithBorders = geometry.sizeWithBorders(); // not geometry.size(::compiz::geometry::WithBorders);

« Back to merge proposal