Code review comment for lp:~smspillaz/compiz-core/compiz-core.work_923683

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Pointless use of abs(): All uses of the abs() function in the diff appear to be numerically pointless;
    if (abs (foo))
is the same as:
    if (foo)

Pointless temporary creation/destruction:
1345 + priv->region = priv->inputRegion = CompRegion ();
Should just assign emptyRegion I think.

review: Needs Fixing

« Back to merge proposal