Merge lp:~smspillaz/compiz-core/compiz-core.fix_969108 into lp:compiz-core

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 3080
Proposed branch: lp:~smspillaz/compiz-core/compiz-core.fix_969108
Merge into: lp:compiz-core
Diff against target: 35 lines (+9/-1)
2 files modified
NEWS (+7/-0)
src/window.cpp (+2/-1)
To merge this branch: bzr merge lp:~smspillaz/compiz-core/compiz-core.fix_969108
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Review via email: mp+100110@code.launchpad.net

Description of the change

== Problem ==

priv->invisible was not updated when the window is mapped, even though it reflects whether or not the window is mapped

== Solution ==

update priv->invisible when window is mapped

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Argh. Another typo! This proposal is meant to be for bug 969102.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2012-03-30 07:55:31 +0000
3+++ NEWS 2012-03-30 11:46:21 +0000
4@@ -1,3 +1,10 @@
5+Release 0.9.7.6 (2012-04-02 Sam Spilsbury <sam.spilsbury@canonical.com>)
6+========================================================================
7+
8+Bugs fixed (https://launchpad.net/compiz-core/+milestone/0.9.7.6)
9+
10+ 969102 - priv->invisible is not updated when the window is mapped
11+
12 Release 0.9.7.4 (2012-04-02 Daniel van Vugt <daniel.van.vugt@canonical.com>)
13 ============================================================================
14
15
16=== modified file 'src/window.cpp'
17--- src/window.cpp 2012-03-30 06:26:33 +0000
18+++ src/window.cpp 2012-03-30 11:46:21 +0000
19@@ -1606,6 +1606,7 @@
20 {
21 windowNotify (CompWindowNotifyBeforeMap);
22
23+ /* Previously not viewable */
24 if (!isViewable ())
25 {
26 if (priv->pendingMaps > 0)
27@@ -1626,7 +1627,7 @@
28 if (!overrideRedirect ())
29 screen->priv->setWmState (NormalState, priv->id);
30
31- priv->invisible = true;
32+ priv->invisible = priv->isInvisible ();
33 priv->alive = true;
34
35 priv->lastPong = screen->priv->lastPing;

Subscribers

People subscribed via source and target branches