Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix_969101

Alan Griffiths (alan-griffiths) wrote :

I agree with Sam that the "after" code is cleaner and that the majority of the diff is low risk (adding tests & build script).

I'd quibble with making destructors pure, and NVPI but it seems to run fine.

Cleaner, unit tested code... what's not to like?

review: Approve

« Back to merge proposal