Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix_969101

Alan Griffiths (alan-griffiths) wrote :

The killer: tests are not added to "make test"

Also, pure virtual functions should be private (not protected).

And there's no point to making destructors pure => "virtual ~DecorClippableInterface () {}"

Comment only: I (and almost everyone except Herb) don't see the point of NVPI.

review: Needs Fixing

« Back to merge proposal