Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix_939228

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Needs Information:
As far as I can tell, the bug is already fixed by the prerequisite wall fix, which is now committed. I can't reproduce the bug any more so why do we need to complicate viewportForGeometry or change it at all?

Needs Fixing:
This branch introduces odd viewport bugs where windows suddenly change the viewport they're on when you select (zoom into) a new viewport using expo. lp:compiz-core has no such bugs.

So the bug doesn't exist any more, and this branch introduces a worse one.

If you would still like to submit this to keep the test cases, please:
1. Fix the regression; and
2. Disassociate the branch from the bug numbers.

review: Needs Fixing

« Back to merge proposal