Merge lp:~smspillaz/compiz-core/compiz-core.fix_890947 into lp:compiz-core/0.9.5

[Sam Spilsbury]

Fix bug 890947

There's a race when sending synthetic configure notify events to clients where just after being reparented the geometry is queried, but we don't offset it correctly since we haven't received the frame reference from the server yet, so use XTranslateCoordinates there directly as we're in synchronous operation.

[Gord Allott (gordallott)]

review: Approve

=== modified file 'src/window.cpp'
--- src/window.cpp	2011-11-07 02:27:18 +0000
+++ src/window.cpp	2011-12-12 11:56:24 +0000
@@ -1532,7 +1532,7 @@
     XConfigureEvent xev;
     XWindowAttributes attrib;
     unsigned int      nchildren;
-    Window            rootRet, parentRet;
+    Window            rootRet, parentRet = 0;
     Window            *children;
 
     xev.type   = ConfigureNotify;
@@ -1554,25 +1554,9 @@
 	xev.border_width = attrib.border_width;
 	xev.above = None;
 
-	if (priv->frame)
-	{
-	    XWindowAttributes fAttrib;
-	    XWindowAttributes wAttrib;
-
-	    /* Add offset between wrapper and client */
-	    if (XGetWindowAttributes (screen->dpy (), priv->wrapper, &wAttrib))
-	    {
-		xev.x += wAttrib.x;
-		xev.y += wAttrib.y;
-	    }
-
-	    /* Add offset between frame and client */
-	    if (XGetWindowAttributes (screen->dpy (), priv->frame, &fAttrib))
-	    {
-		xev.x += fAttrib.x;
-		xev.y += fAttrib.y;
-	    }
-	}
+	/* Translate co-ordinates to root space */
+	XTranslateCoordinates (screen->dpy (), priv->id, screen->root (), 0, 0,
+			       &xev.x, &xev.y, &parentRet);
 
 	/* We need to ensure that the stacking order is
 	 * based on the current server stacking order so