lp:~smspillaz/compiz-animation-plugin/compiz-animation-plugion.fix_940603

Created by Sam Spilsbury on 2012-04-10 and last modified on 2012-04-10
Get this branch:
bzr branch lp:~smspillaz/compiz-animation-plugin/compiz-animation-plugion.fix_940603
Only Sam Spilsbury can upload to this branch. If you are Sam Spilsbury please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Sam Spilsbury
Project:
Compiz Animations Plugin
Status:
Merged

Recent revisions

396. By Sam Spilsbury on 2012-04-10

Don't increment the destroy ref count of a window unless an animation is active.

It doesn't make any sense to increase the destroy reference count of a window
on CompWindowNotifyBeforeDestroy based on whether or not an an animation for
that window "could" be allowed - CompWindowNotifyBeforeDestroyed is called
on CompWindow::destroy (which under sane circumstances, should only ever be called
when the window is either reparented away from its parent or the root window
or when the window is destroyed).

In this case, we deregister all events on the window so it isn't possible to determine
through any normal means that a close animation is going to activate on the window. And
in any event, the unmap which causes close animations always comes before the DestroyNotify
or ReparentNotify anyways.

Even if the CompWindowNotifyClose were to somehow come after the window received a ReparentNotify
or DestroyNotify, the tradeoff then comes between not playing animations for those corner case
windows or keeping ghost windows on screen because we kept a destroy reference and never
got rid of it. In this case, it is more sane to do the former.

Fix LP #940603

395. By Daniel van Vugt on 2012-03-21

Fix stuttering animations on large/fullscreen windows by using the higher
performance rendering method (full screen damage). (LP: #930192)

393. By Sam Spilsbury on 2011-10-03

Merge

391. By Sam Spilsbury on 2011-09-19

Merge

390. By Sam Spilsbury on 2011-09-19

Merge

389. By Sam Spilsbury on 2011-09-18

Merge

388. By Sam Spilsbury on 2011-09-18

Merge in paint list locking and delayed cleanup work

387. By Sam Spilsbury on 2011-09-17

Merge

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:compiz-animation-plugin
This branch contains Public information 
Everyone can see this information.

Subscribers