lp:~smspillaz/compiz-animation-plugin/compiz-animation-plugion.fix_940603
- Get this branch:
- bzr branch lp:~smspillaz/compiz-animation-plugin/compiz-animation-plugion.fix_940603
Branch merges
- Daniel van Vugt: Approve
-
Diff: 27 lines (+5/-5)1 file modifiedsrc/animation.cpp (+5/-5)
Related source package recipes
Related bugs
Related blueprints
Branch information
Recent revisions
- 396. By Sam Spilsbury
-
Don't increment the destroy ref count of a window unless an animation is active.
It doesn't make any sense to increase the destroy reference count of a window
on CompWindowNotifyBeforeDestroy based on whether or not an an animation for
that window "could" be allowed - CompWindowNotifyBeforeDestroye d is called
on CompWindow::destroy (which under sane circumstances, should only ever be called
when the window is either reparented away from its parent or the root window
or when the window is destroyed).In this case, we deregister all events on the window so it isn't possible to determine
through any normal means that a close animation is going to activate on the window. And
in any event, the unmap which causes close animations always comes before the DestroyNotify
or ReparentNotify anyways.Even if the CompWindowNotif
yClose were to somehow come after the window received a ReparentNotify
or DestroyNotify, the tradeoff then comes between not playing animations for those corner case
windows or keeping ghost windows on screen because we kept a destroy reference and never
got rid of it. In this case, it is more sane to do the former.Fix LP #940603
- 395. By Daniel van Vugt
-
Fix stuttering animations on large/fullscreen windows by using the higher
performance rendering method (full screen damage). (LP: #930192)
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:compiz-animation-plugin
