Merge lp:~smoser/vmbuilder/jenkins_kvm.img-maas-git into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

Proposed by Scott Moser
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp:~smoser/vmbuilder/jenkins_kvm.img-maas-git
Merge into: lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm
Diff against target: 16 lines (+6/-0)
1 file modified
templates/img-maas.tmpl (+6/-0)
To merge this branch: bzr merge lp:~smoser/vmbuilder/jenkins_kvm.img-maas-git
Reviewer Review Type Date Requested Status
Scott Moser (community) Disapprove
Francis Ginther Pending
Robert C Jennings Pending
Review via email: mp+357841@code.launchpad.net

Commit message

img-maas.tmpl: Install git if it is not present.

img-maas.tmpl uses git to check out maas-images. That does not work
if there is no 'git' command. 14.04 images do not have git by default.

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :
review: Disapprove

Unmerged revisions

813. By Scott Moser

img-maas.tmpl: Install git if it is not present.

img-maas.tmpl uses git to check out maas-images. That does not work
if there is no 'git' command. 14.04 images do not have git by default.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/img-maas.tmpl'
2--- templates/img-maas.tmpl 2018-09-24 20:22:02 +0000
3+++ templates/img-maas.tmpl 2018-10-25 19:02:25 +0000
4@@ -38,6 +38,12 @@
5
6 # Set up the code paths
7 cd /tmp
8+if ! which git; then
9+ echo "Installing git."
10+ sudo apt-get update --quiet &&
11+ sudo apt-get install --quiet --assume-yes git ||
12+ fail "Failed to install git with apt-get."
13+fi
14 echo "Checking out maas-image from git"
15 git clone "${MAAS_GIT_REPO}" "${SRC_D}" ||
16 fail "Failed to check out the GIT branch"

Subscribers

People subscribed via source and target branches