VMBuilder

Merge lp:~smoser/vmbuilder/automated-ec2-builds-tar-xattr into lp:~ubuntu-on-ec2/vmbuilder/automated-ec2-builds

  1. automated-ec2-builds-tar-xattr
  2. Merge into automated-ec2-builds
Proposed by Scott Moser
Status: Merged
Merge reported by: Ben Howard
Merged at revision: not available
Proposed branch: lp:~smoser/vmbuilder/automated-ec2-builds-tar-xattr
Merge into: lp:~ubuntu-on-ec2/vmbuilder/automated-ec2-builds
Diff against target: 15 lines (+5/-0)
1 file modified
img2roottgz (+5/-0)
To merge this branch: bzr merge lp:~smoser/vmbuilder/automated-ec2-builds-tar-xattr
Reviewer Review Type Date Requested Status
Ben Howard Pending
Review via email: mp+217486@code.launchpad.net

Description of the change

-root.tar.gz: collect xattr and acl information if tar supports it

The -root.tar.gz files do not contain xattr info, and xattr info is
required for fully functional /bin/ping on 14.04.

This lets us create the tarball with the correct data if tar can do
that. Its up to the consumer (lxc or other) to extract correctly.

To post a comment you must log in.
Revision history for this message
Ben Howard (darkmuggle-deactivatedaccount) wrote :

Merged. Thanks for the MP.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'img2roottgz'
2--- img2roottgz 2014-03-12 16:29:28 +0000
3+++ img2roottgz 2014-04-28 18:03:50 +0000
4@@ -49,7 +49,12 @@
5 fi
6 slist=( $(shopt -s dotglob && cd "$mp" && ls -d *) )
7
8+attropts=( )
9+if tar --help 2>&1 | grep -q xattr; then
10+ attropts=( "--xattrs" "--xattrs-include=*" "--acls" )
11+fi
12 tar --use-compress-program=gzip-rsyncable \
13+ "${attropts[@]}" \
14 -C "$mp" -Scpf - "${slist[@]}"
15 '
16

Subscribers

People subscribed via source and target branches