Merge lp:~smoser/simplestreams/trunk.ppc64el-no-whitelist into lp:~smoser/simplestreams/trunk

Proposed by Scott Moser
Status: Merged
Merged at revision: 421
Proposed branch: lp:~smoser/simplestreams/trunk.ppc64el-no-whitelist
Merge into: lp:~smoser/simplestreams/trunk
Diff against target: 88 lines (+9/-6)
3 files modified
debian/control (+2/-0)
tests/unittests/test_contentsource.py (+7/-3)
tools/toolutil.py (+0/-3)
To merge this branch: bzr merge lp:~smoser/simplestreams/trunk.ppc64el-no-whitelist
Reviewer Review Type Date Requested Status
Dan Watkins Pending
Scott Moser Pending
Review via email: mp+282631@code.launchpad.net

Commit message

tools/make-test-data: Fix missing lxc/lxd files for ppc64el builds.

We had a whitelist on ppc64el ever since the first ppc64el builds.
Removing that whitelist means we will now get correct file information
for all ppc64el builds.

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :

for reference, this now produces:
$ sstream-query "--output-format=%(release)s %(ftype)s" exdata/fake/daily/streams/v1/index.json arch=ppc64el
trusty tar.gz
trusty disk1.img
trusty manifest
trusty root.tar.gz
trusty root.tar.xz
trusty lxd.tar.xz
vivid tar.gz
vivid disk1.img
vivid manifest
vivid root.tar.gz
vivid root.tar.xz
vivid lxd.tar.xz
vivid tar.gz
vivid disk1.img
vivid manifest
vivid root.tar.gz
vivid root.tar.xz
vivid lxd.tar.xz
vivid tar.gz
vivid disk1.img
vivid manifest
vivid root.tar.gz
vivid root.tar.xz
vivid lxd.tar.xz
vivid tar.gz
vivid disk1.img
vivid manifest
vivid root.tar.gz
vivid root.tar.xz
vivid lxd.tar.xz
wily tar.gz
wily disk1.img
wily manifest
wily root.tar.gz
wily root.tar.xz
wily lxd.tar.xz
wily tar.gz
wily disk1.img
wily manifest
wily root.tar.gz
wily root.tar.xz
wily lxd.tar.xz
xenial tar.gz
xenial disk1.img
xenial manifest
xenial root.tar.gz
xenial root.tar.xz
xenial lxd.tar.xz
xenial tar.gz
xenial disk1.img
xenial manifest
xenial root.tar.gz
xenial root.tar.xz
xenial lxd.tar.xz

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-12-08 20:29:22 +0000
3+++ debian/control 2016-01-14 16:59:45 +0000
4@@ -8,11 +8,13 @@
5 python-all,
6 python-mock,
7 python-nose,
8+ python-requests (>= 1.1),
9 python-setuptools,
10 python-yaml,
11 python3,
12 python3-mock,
13 python3-nose,
14+ python3-requests (>= 1.1),
15 python3-setuptools,
16 python3-yaml
17 Homepage: http://launchpad.net/simplestreams
18
19=== modified file 'tests/unittests/test_contentsource.py'
20--- tests/unittests/test_contentsource.py 2015-12-08 20:10:40 +0000
21+++ tests/unittests/test_contentsource.py 2016-01-14 16:59:45 +0000
22@@ -6,7 +6,7 @@
23 from simplestreams import objectstores
24 from simplestreams import contentsource
25 from subprocess import Popen, PIPE, STDOUT
26-from unittest import TestCase
27+from unittest import TestCase, skipIf
28 from nose.tools import raises
29
30
31@@ -69,8 +69,7 @@
32
33 def getcs(self, path, url_reader=None):
34 return contentsource.UrlContentSource(
35- self.server.url_for(path),
36- url_reader=contentsource.RequestsUrlReader)
37+ self.server.url_for(path), url_reader=url_reader)
38
39 def test_default_url_read_handles_None(self):
40 scs = contentsource.UrlContentSource(self.server.url_for(self.fpath))
41@@ -94,21 +93,25 @@
42 data = scs.read(-1)
43 self.assertEqual(data, self.fdata)
44
45+ @skipIf(contentsource.requests is None, "requests not available")
46 def test_requests_url_read_handles_None(self):
47 scs = self.getcs(self.fpath, contentsource.RequestsUrlReader)
48 data = scs.read(None)
49 self.assertEqual(data, self.fdata)
50
51+ @skipIf(contentsource.requests is None, "requests not available")
52 def test_requests_url_read_handles_negative_size(self):
53 scs = self.getcs(self.fpath, contentsource.RequestsUrlReader)
54 data = scs.read(None)
55 self.assertEqual(data, self.fdata)
56
57+ @skipIf(contentsource.requests is None, "requests not available")
58 def test_requests_url_read_handles_no_size(self):
59 scs = self.getcs(self.fpath, contentsource.RequestsUrlReader)
60 data = scs.read()
61 self.assertEqual(data, self.fdata)
62
63+ @skipIf(contentsource.requests is None, "requests not available")
64 def test_requests_url_read_handles_int(self):
65 scs = self.getcs(self.fpath, contentsource.RequestsUrlReader)
66 data = scs.read(3)
67@@ -259,6 +262,7 @@
68 self.assertEqual(content, self.fdata)
69
70
71+@skipIf(contentsource.requests is None, "requests not available")
72 class TestRequestsUrlReader(BaseReaderTest, TestCase):
73 reader = contentsource.RequestsUrlReader
74 http = True
75
76=== modified file 'tools/toolutil.py'
77--- tools/toolutil.py 2015-11-20 18:01:09 +0000
78+++ tools/toolutil.py 2016-01-14 16:59:45 +0000
79@@ -70,9 +70,6 @@
80 if arch == "ppc64el":
81 if rel < "trusty" or serial <= "20140326":
82 return False
83- ppc64el_suffs = (".tar.gz", "-root.tar.gz", "-disk1.img", ".manifest")
84- if suffix not in ppc64el_suffs:
85- return False
86
87 if suffix == ".ova":
88 # OVA images become available after 20150407.4 (vivid beta-3)

Subscribers

People subscribed via source and target branches

to all changes: