Merge lp:~smoser/maas/maas-cli into lp:maas/trunk
Proposed by
Dave Walker
on 2012-04-10
| Status: | Rejected |
|---|---|
| Rejected by: | Andres Rodriguez on 2016-02-23 |
| Proposed branch: | lp:~smoser/maas/maas-cli |
| Merge into: | lp:maas/trunk |
| Diff against target: |
425 lines (+376/-1) 6 files modified
.bzrignore (+1/-0) maas-cli/maascli.py (+116/-0) maas-cli/maasclient/auth.py (+60/-0) maas-cli/maasclient/maas.py (+194/-0) maas-cli/my.cfg.example (+3/-0) src/maas/settings.py (+2/-1) |
| To merge this branch: | bzr merge lp:~smoser/maas/maas-cli |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| MAAS Maintainers | 2012-04-10 | Pending | |
|
Review via email:
|
|||
To post a comment you must log in.
| Julian Edwards (julian-edwards) wrote : | # |
| Scott Moser (smoser) wrote : | # |
On Wed, 11 Apr 2012, Julian Edwards wrote:
> This is going to be very useful! I know you said to ignore but here's some pre-review help:
>
> * the oauth code has been cargo culted from juju and still contains juju references
ok. i'll wipe that.
> * please don't pollute the top-level dir, add this to contrib/ instead.
yeah, i agree. I knew it wasn't right when I did it. but just started
somewhere.
Unmerged revisions
- 372. By Scott Moser on 2012-03-30
-
functional release node
- 371. By Scott Moser on 2012-03-30
-
fix maascli, removing twisted
- 370. By Scott Moser on 2012-03-30
-
change from twisted client to urllib2
- 369. By Scott Moser on 2012-03-30
-
merge trunk
- 368. By Scott Moser on 2012-03-29
-
initial commit of maas-cli


This is going to be very useful! I know you said to ignore but here's some pre-review help:
* the oauth code has been cargo culted from juju and still contains juju references
* please don't pollute the top-level dir, add this to contrib/ instead.