Merge lp:~smoser/maas/lp1103716 into lp:~maas-committers/maas/trunk
Proposed by
Scott Moser
Status: | Merged |
---|---|
Approved by: | Scott Moser |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1429 |
Proposed branch: | lp:~smoser/maas/lp1103716 |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
11 lines (+1/-1) 1 file modified
src/metadataserver/commissioning/user_data.template (+1/-1) |
To merge this branch: | bzr merge lp:~smoser/maas/lp1103716 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raphaël Badin (community) | Approve | ||
Review via email: mp+146863@code.launchpad.net |
Commit message
fix typo in commiss template causing ipmi to always be passed.
- if [ ! -z "power_settings" ]; then
+ if [ ! -z "$power_settings" ]; then
The literal string 'power_settings' will never be zero length.
Description of the change
fix simple typo
To post a comment you must log in.
Thanks for fixing this Scott. That's the kind of bug that gives me the goosebumps… anything we can do to improve the test coverage here and catch that kind of bug?