Merge lp:~smoser/maas/iscsi-root-equal into lp:~maas-committers/maas/trunk
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Scott Moser | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 1428 | ||||
Proposed branch: | lp:~smoser/maas/iscsi-root-equal | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
42 lines (+7/-6) 2 files modified
src/provisioningserver/kernel_opts.py (+6/-5) src/provisioningserver/tests/test_kernel_opts.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~smoser/maas/iscsi-root-equal | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Raphaël Badin (community) | Approve | ||
Andres Rodriguez (community) | Approve | ||
Review via email: mp+146016@code.launchpad.net |
Commit message
in ephemeral/
previously we were booting iscsi root with 'LABEL=
There were a few issues with that:
a.) that implied/required that all ephemeral images would have this root
filesystem label.
b.) if there was a filesystem on the local system with the given label
the selected device would be non-determinable.
This could happen innocently, or potentially on purpose as an attempt
to retain control of a system after it had been returned.
By booting with a /dev/disks/by-path, we're explicitly telling the
initramfs that is being sent that we want the root device to come over
iscsi. The tradeoff here is that we're now expecting the kernel/initramfs
to consistently provide this path.
Description of the change
in ephemeral/
previously we were booting iscsi root with 'LABEL=
There were a few issues with that:
a.) that implied/required that all ephemeral images would have this root
filesystem label.
b.) if there was a filesystem on the local system with the given label
the selected device would be non-determinable.
This could happen innocently, or potentially on purpose as an attempt
to retain control of a system after it had been returned.
By booting with a /dev/disks/by-path, we're explicitly telling the
initramfs that is being sent that we want the root device to come over
iscsi. The tradeoff here is that we're now expecting the kernel/initramfs
to consistently provide this path.
Looks good to me.