Merge lp:~smoser/maas/ipmi-locate-fallback into lp:~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Francis J. Lacoste |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1264 |
Proposed branch: | lp:~smoser/maas/ipmi-locate-fallback |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
58 lines (+10/-0) 2 files modified
contrib/preseeds_v2/enlist_userdata (+5/-0) etc/maas/commissioning-user-data (+5/-0) |
To merge this branch: | bzr merge lp:~smoser/maas/ipmi-locate-fallback |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Francis J. Lacoste (community) | Approve | ||
Review via email: mp+129202@code.launchpad.net |
Commit message
if ipmi-locate fails, but /dev/ipmi[0-9] exists continue down ipmi path
on quantal, the version of ipmi-locate in freeipmi (1.1.5-3ubuntu2) was
failing to locate ipmi on armhf boards. ipmi-locate did produce a postive
result on precise (0.8.12-3ubuntu1).
This works around that, and continues down the path if the /dev/ipmi
device is present.
Also, added here is a 'udevadm settle', which is really required any time
you load a module to prevent a race condition before attempting to access
the named device.
It would seem likelyhood of false positive here is very small, and at
this point it would seem that the end result would be a node enlisted
with empty power settings.
Description of the change
if ipmi-locate fails, but /dev/ipmi[0-9] exists continue down ipmi path
on quantal, the version of ipmi-locate in freeipmi (1.1.5-3ubuntu2) was
failing to locate ipmi on armhf boards. ipmi-locate did produce a postive
result on precise (0.8.12-3ubuntu1).
This works around that, and continues down the path if the /dev/ipmi
device is present.
Also, added here is a 'udevadm settle', which is really required any time
you load a module to prevent a race condition before attempting to access
the named device.
It would seem likelyhood of false positive here is very small, and at
this point it would seem that the end result would be a node enlisted
with empty power settings.
Looks good to me