Merge lp:~smoser/maas-images/trunk.lp1640519 into lp:maas-images

Proposed by Scott Moser
Status: Merged
Merged at revision: 350
Proposed branch: lp:~smoser/maas-images/trunk.lp1640519
Merge into: lp:maas-images
Diff against target: 24 lines (+11/-3)
1 file modified
bin/maas-cloudimg2ephemeral (+11/-3)
To merge this branch: bzr merge lp:~smoser/maas-images/trunk.lp1640519
Reviewer Review Type Date Requested Status
Lee Trager (community) Approve
Review via email: mp+312064@code.launchpad.net

Commit message

Never add u-boot-tools to image on zesty or newer.

u-boot-tools was added to arm64 and armhf images as a crutch in order to
aid curtin in installation of older releases. In newer curtin this is
fixed by dynamic installation similar to how grub is handled.

See LP: #1640519 for more information.

To post a comment you must log in.
Revision history for this message
Lee Trager (ltrager) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/maas-cloudimg2ephemeral'
2--- bin/maas-cloudimg2ephemeral 2016-09-23 19:00:56 +0000
3+++ bin/maas-cloudimg2ephemeral 2016-11-29 16:19:53 +0000
4@@ -297,9 +297,17 @@
5 rel_pkgs="${rel_pkgs} maas-enlist";;
6 esac
7
8- case "$arch" in
9- arm64|armhf) arch_pkgs="u-boot-tools";;
10- esac
11+ change="add u-boot-tools to arch_pkgs for arch '$arch' (LP: #1640519)"
12+ if [ "$arch" = "arm64" -o "$arch" = "armhf" ]; then
13+ case "$release" in
14+ precise|quantal|raring|saucy|trusty|utopic|vivid|wily|\
15+ xenial|yakkety)
16+ arch_pkgs="${arch_pkgs} u-boot-tools"
17+ debug 1 "release '$release' <= yakkety: $change"
18+ ;;
19+ *) debug 1 "release '$release' > yakkety: do not $change";;
20+ esac
21+ fi
22
23 local removes="^linux-.*" keeps="^linux-base$" pkglist=""
24 pkglist=$(dpkg-query --show) || { error "failed dpkg-query"; return 1; }

Subscribers

People subscribed via source and target branches