Merge lp:~smoser/glance/ubuntu-chown-trailing-slash into lp:~openstack-ubuntu-packagers/glance/ubuntu

Proposed by Scott Moser
Status: Merged
Merged at revision: 55
Proposed branch: lp:~smoser/glance/ubuntu-chown-trailing-slash
Merge into: lp:~openstack-ubuntu-packagers/glance/ubuntu
Diff against target: 26 lines (+4/-1)
2 files modified
debian/changelog (+3/-0)
debian/glance.postinst (+1/-1)
To merge this branch: bzr merge lp:~smoser/glance/ubuntu-chown-trailing-slash
Reviewer Review Type Date Requested Status
Thierry Carrez (community) Approve
Review via email: mp+71793@code.launchpad.net

Description of the change

This fixes the case where the user would do something like this:
sudo mkdir -p /opt/lib/glance
sudo ln -s /opt/lib/glance /var/lib/glance

sudo apt-get install glance

Generally, if you expect for a thing to be a directory, it makes sense to use the trailing / to chown.

To post a comment you must log in.
Revision history for this message
Thierry Carrez (ttx) wrote :

Looks good, merging

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-08-16 19:17:28 +0000
3+++ debian/changelog 2011-08-17 01:00:26 +0000
4@@ -3,6 +3,9 @@
5 * New upstream release.
6 * Added python-kombu as Depends and Build-depends.
7
8+ [ Scott Moser ]
9+ * glance.postinst: use a trailing slash when using chown on directories
10+
11 -- Monty Taylor <mordred@inaugust.com> Fri, 12 Aug 2011 12:53:06 -0400
12
13 glance (2011.3~d4~20110811.980-0ubuntu1) oneiric; urgency=low
14
15=== modified file 'debian/glance.postinst'
16--- debian/glance.postinst 2011-05-10 17:37:39 +0000
17+++ debian/glance.postinst 2011-08-17 01:00:26 +0000
18@@ -8,7 +8,7 @@
19 then
20 adduser --system --home /var/lib/glance --no-create-home --shell /bin/bash glance
21 fi
22- chown glance -R /var/lib/glance /var/log/glance
23+ chown glance -R /var/lib/glance/ /var/log/glance/
24 if ! grep sql_connection /etc/glance/glance-registry.conf | grep -qv "sql_connection = sqlite:////var/lib/glance/glance.sqlite"
25 then
26 su -c 'glance-manage db_sync' glance

Subscribers

People subscribed via source and target branches