vmtests: Let a raised SkipTest go through skip_by_date.
There was a general logic error in skip_by_date. If a setUpClass
raised a SkipTest and the fix-by date had not been raised then
we would swallow that SkipTest. Th result was that the test methods
would fail as the install had not been done.
We saw this specifically at the end of Artful's support. The
artful setUpClass would then raise SkipTest due to
'is_unsupported_ubuntu'. skip_by_date was swallowing that.
The change here is to just let a SkipTest bubble through the
skip_by_date wrapper.
vmtests: Increase root fs to give upgrades to -proposed more space.
Our new jenkins job curtin-vmtest-devel-amd64-proposed runs with
CURTIN_VMTEST_ADD_REPOS=proposed . That causes an
'apt-get update && apt-get dist-upgrade' to occur in the installed
system.
The change here simply increases by 500M the size of the root
disk tests that use examples/tests/mirrorboot-msdos-partition.yaml.
We can simply do this because the md0-part1 was on md0 which was a
5G disk, but we were creating 2x2G partitions. So now we still have
some wiggle room there.
This particular build failed because of 2 reasons
a.) the HWE variety meant additional kernels installed
b.) the trusty images are well out of date at thsi point (2018-05-02)
so lots of apt downloads and upgrades.
vmtest: Order the vmtest_pollinate late_command earlier.
The TestInstallUnmount verifies that 'install: {umount: disabled}' does
leave filesystems mounted, but its late_commands were unmounting
the target. Those conflicted with the late_commands here as we
expected the fs to be mounted.
Fix here is just to move the un-mounting late commands till '99' time
frame and move the vmtest_pollinate one earlier.
vmtests: make skip_by_date a decorator that runs and reports.
Previously when we marked something 'skip_by_date', it would not
run until the 'fixby' date. At that point one of 2 things would happen:
a.) it fails and we have to bump the date out.
b.) it passes, and then at the 'remove_by' we see the error and respond
with removal.
'b' works as designed, but there was a problem with 'a' in that we are
basically blind about these tests until fixby.
The change here is to turn skip_by_date into a decorator that will
run the tests, but raise SkipTest until fixby. At that point, then
it will behave as before.
skip_by_date can be given 'install=False' which means the setUpClass
will raise a skipTest. This is used if the test install or boot will
hang, simply to avoid long timeouts in our tests as a result of known
failures.
The additional benefit of the generator here is that adding and
removing skip_by_date is entirely a one line change. No additional
imports, no adding a subclass definition and calling super().
