Merge ~smoser/curtin:test-git into curtin:master
| Status: | Merged |
|---|---|
| Merged at revision: | c5cb03e197f0a5066188530f50b2c6c1f15a904a |
| Proposed branch: | ~smoser/curtin:test-git |
| Merge into: | curtin:master |
| Diff against target: |
551 lines (+262/-111) 12 files modified
.gitignore (+1/-0) curtin/version.py (+7/-7) debian/changelog.trunk (+1/-1) debian/control (+0/-2) dev/null (+0/-61) doc/topics/development.rst (+5/-6) tests/unittests/test_block_iscsi.py (+2/-2) tests/unittests/test_version.py (+5/-5) tools/build-deb (+21/-26) tools/make-tarball (+50/-0) tools/new-upstream-snapshot (+169/-0) tox.ini (+1/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ryan Harper | Approve on 2017-12-20 | ||
| Server Team CI bot | continuous-integration | Needs Fixing on 2017-12-20 | |
| Chad Smith | 2017-12-19 | Approve on 2017-12-20 | |
|
Review via email:
|
|||
Description of the Change
Two commits that might as well be kept separate.
-----
debian/control: drop conflicts that had bzr version
this is fine as the bzr version (~bzr54) is not in any supported
release.. trusty is at 126-0ubuntu1 in released version even.
----
Switch uses of bzr to git, borrow from cloud-init git workflow.
Basically replace all references to bzr. git-describe and experience
in cloud-init make this fairly painless.
- curtin/version.py
replace usage of 'bzr revno' with 'git-describe'.
versions 'packed' from git will show a version like 17.1-5-gdfd3389f.
- debian/
remove the hard coded version string.
- tools/export-
replace export-tarball with a version of make-tarball taken from
cloud-init.
- tools/build-deb, update to use git-describe and make-tarball.
Also set some default parameters (-S -d -us -uc).
- doc/, tox.ini, just replace bzr with git.
| Chad Smith (chad.smith) wrote : | # |
| Chad Smith (chad.smith) wrote : | # |
Should we be performing the git log relative to our tags?
git log ubuntu/
| Scott Moser (smoser) wrote : | # |
will fix
FAILED: Continuous integration, rev:fa213606f01
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
FAILED: Continuous integration, rev:82ebcd8bb99
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
FAILED: Continuous integration, rev:3d308c785bd
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Chad Smith (chad.smith) wrote : | # |
Thanks for the updates here, new-upstream-
from jenkins
+ bzr branch 'lp:~smoser/curtin' curtin-709
bzr: ERROR: Invalid url supplied to transport: "lp:~smoser/curtin": ~smoser/curtin is too short to be a branch name. Try '~<owner>
| Chad Smith (chad.smith) wrote : | # |
Thanks for the fixes new-upstream-
FAILED: Continuous integration, rev:ad5063461e1
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
FAILED: Continuous integration, rev:5fe7fe8f2a2
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
FAILED: Continuous integration, rev:45caf272b50
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/

Generally looks like a good first pass, but trying to run this on artful hits issues parsing old changelog containing *bzr* and trying to run git log against that version versus master
fatal: ambiguous argument '0.1.0~ bzr532. .master' : unknown revision or path not in the working tree. .master
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
failed git log 0.1.0~bzr532.