lp:~smoser/cloud-utils/trunk.lp1630274

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:cloud-utils at revision 304

Registry Administrators: Pending requested 2016-10-04

Diff: 107 lines (+37/-34)

1 file modified

bin/mount-image-callback (+37/-34)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1630274: mount-image-callback may not mount overlay when it could

High

Fix Released

Link a bug report

Related blueprints

304. By Scott Moser on 2016-10-04

mount-image-callback: try mounting overlay rather than checking first

The logic to determine if mount would work was flawed in it assumed
that both or neither of the following would succeed:
  modprobe --quiet --use-blacklist fstype
  mount -t fstype would succeed

That logic failed when modprobe could not load the module due to
being in a chroot or some other reason. The change here is to just
do try the mount. In order to avoid confusing output about trying
to mount overlayfs we first try mounting overlay. If that fails
and 'overlay' seems present in /proc/filesystems, then do not bother
trying to mount overlayfs.

303. By Scott Moser on 2016-09-28

mount-image-callback: support 'overlay' filesystem type rather
than ubuntu specific 'overlayfs' (LP: #1493188)

302. By Scott Moser on 2016-09-01

debian: add auto package test.

301. By Scott Moser on 2016-09-01

do not use sgdisk for creating gpt partitions

this does require a new enough util-linux to have gpt support in sfdisk.

300. By Scott Moser on 2016-09-01

update Changelog and debian/changelog for missing entries.

299. By Scott Moser on 2016-09-01

growpart: ignore sfdisk failure in 2.28.1 when due to reread failing

version 2.28.1 exits failure when kernel re-read of partition table
fails. That is expected behavior in growpart, and addressed elsewhere.

See util-linux git commit 78e7f78896f2c for list of exit values when.

298. By Scott Moser on 2016-09-01

mount-image-callback: add -S short flag for --system-mounts

297. By Scott Moser on 2016-09-01

growpart: improved error messages on failure.

296. By Scott Moser on 2016-07-18

bin/ubuntu-cloudimg-query: default to ebs-ssd for xenial and later

ebs root (the old block storage based ebs root) image types were dropped
in xenial. So xenial+, default to ebs-ssd.

295. By Ryan Harper on 2016-07-18

fix mount-image-callback short option parsing

mount-image-callback didn't configure getopt short options parsing
correctly, missing that the '-m' and '-P' options require input, getopt
uses the ':' value to indicate input is required.