lp:~smoser/cloud-utils/trunk.1715994-drop-lxd

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:cloud-utils at revision 321

Registry Administrators: Pending requested 2017-10-25

Diff: 130 lines (+11/-72)

1 file modified

bin/mount-image-callback (+11/-72)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1715994: mount-image-callback lxd: is broken with lxd 2.17

Medium

Fix Released

Link a bug report

Related blueprints

319. By Scott Moser on 2018-01-03

merge with trunk

318. By Scott Moser on 2018-01-03

better unsupported message

317. By Scott Moser on 2017-10-25

mount-image-callback: Drop support for mounting lxd containers.

The 'lxd:' support in mount-image-callback only worked in some cases,
and then stopped working in all cases with lxc 2.17.

This drops the lxd support, but leaves in the 'mchroot' support which
came with it.

316. By Scott Moser on 2017-04-14

update changelog

315. By Scott Moser on 2017-04-14

mount-image-callback: fix nbd mounting with rw.

mount was getting called with -o '' due to bad variable name.

314. By Scott Moser on 2017-01-13

tools/make-dist-tarball: do not include .bzr in upstream tarball

using tar cf file.tar.gz directory/ --exclude directory/.bzr
was not correctly excluding .bzr.

the --exclude needs to be before 'directory/'.

It is is just as easy and more straight forward to just remove the .bzr
dir in our pristine directory.

313. By Scott Moser on 2016-10-24

mount-image-callback: update usage to mention 'mchroot'

312. By Scott Moser on 2016-10-24

mount-image-callback: support 'chroot' to lxd containers

This adds support for mount-image-callback to do its magic on a
local lxd container.

  $ lxc init ubuntu-daily:xenial mic-test
  $ sudo mount-image-callback mic-test -- apt-get update -q
  $ sudo ./bin/mount-image-callback lxd:mic-test --system-resolvconf -- \
       mchroot apt-get update -q

In doing so, it adds some helpers to the PATH before executing the
command provided:
  uns-switch: switch to the appropriate lxc namespace
  mchroot: chroot into the _MOUNTPOINT_ (automatically calls uns-switch)

311. By Scott Moser on 2016-10-05

test/test-mic: tests for unmounting unexpected mounts and system-mounts.

these 2 tests verify that
 - "unexpected" mounts under the mount point get unmounted.
   mounts not made by mount-image-callback should still get unmounted.
 - tests that --system-mounts works as expected.

310. By Scott Moser on 2016-10-05

bin/mount-image-callback: do unmounts in reverse order.

This still uses umount_r which unmounts under the mount point
recursively. The reason for doing it in reverse order is so
that umount_r can be expected to have done something.

Rather than
  mount -o loop img my-dir
  mount --bind /dev my-dir/dev
  mount --bind /sys my-dir/sys
Then
  umount_r my-dir
We do:
  umount_r my-dir/sys
  umount_r my-dir/dev
  umount_r my-dir